Commit 0f0ced70 authored by Miroslav Benes's avatar Miroslav Benes Committed by Greg Kroah-Hartman
Browse files

livepatch: Nullify obj->mod in klp_module_coming()'s error path

[ Upstream commit 4ff96fb5


klp_module_coming() is called for every module appearing in the system.
It sets obj->mod to a patched module for klp_object obj. Unfortunately
it leaves it set even if an error happens later in the function and the
patched module is not allowed to be loaded.

klp_is_object_loaded() uses obj->mod variable and could currently give a
wrong return value. The bug is probably harmless as of now.
Signed-off-by: default avatarMiroslav Benes <>
Reviewed-by: default avatarPetr Mladek <>
Acked-by: default avatarJosh Poimboeuf <>
Signed-off-by: default avatarPetr Mladek <>
Signed-off-by: default avatarSasha Levin <>
parent 78a11386
...@@ -1027,6 +1027,7 @@ int klp_module_coming(struct module *mod) ...@@ -1027,6 +1027,7 @@ int klp_module_coming(struct module *mod)
pr_warn("patch '%s' failed for module '%s', refusing to load module '%s'\n", pr_warn("patch '%s' failed for module '%s', refusing to load module '%s'\n",
patch->mod->name, obj->mod->name, obj->mod->name); patch->mod->name, obj->mod->name, obj->mod->name);
mod->klp_alive = false; mod->klp_alive = false;
obj->mod = NULL;
klp_cleanup_module_patches_limited(mod, patch); klp_cleanup_module_patches_limited(mod, patch);
mutex_unlock(&klp_mutex); mutex_unlock(&klp_mutex);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment