Commit 26c45428 authored by Ira Weiny's avatar Ira Weiny Committed by Doug Ledford
Browse files

IB/user_mad: Fix buggy usage of port index



The addition of the rdma_cap_ib_mad is technically broken in ib_umad_remove_one
because the loop "i" value is not a port value.

This bug resulted in the ib_umad failing to properly remove its resources when
the core capability functions were converted to bit fields.

NOTE: e17371d73908 did not result in broken behavior on its own.  It was only
an issue when the implementation of rdma_cap_ib_mad was changed.

Pass the port value to rdma_cap_ib_mad.

Fixes: e17371d73908 ("IB/Verbs: Use management helper rdma_cap_ib_mad()")
Signed-off-by: default avatarIra Weiny <ira.weiny@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent ab8be619
...@@ -1325,7 +1325,7 @@ static void ib_umad_remove_one(struct ib_device *device) ...@@ -1325,7 +1325,7 @@ static void ib_umad_remove_one(struct ib_device *device)
return; return;
for (i = 0; i <= rdma_end_port(device) - rdma_start_port(device); ++i) { for (i = 0; i <= rdma_end_port(device) - rdma_start_port(device); ++i) {
if (rdma_cap_ib_mad(device, i)) if (rdma_cap_ib_mad(device, i + rdma_start_port(device)))
ib_umad_kill_port(&umad_dev->port[i]); ib_umad_kill_port(&umad_dev->port[i]);
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment