Commit bb7f8f19 authored by Parav Pandit's avatar Parav Pandit Committed by Doug Ledford
Browse files

IB/core: Fix possible crash to access NULL netdev

resolved_dev returned might be NULL as ifindex is transient number.
Ignoring NULL check of resolved_dev might crash the kernel.
Therefore perform NULL check before accessing resolved_dev.

Additionally rdma_resolve_ip_route() invokes addr_resolve() which
performs check and address translation for loopback ifindex.
Therefore, checking it again in rdma_resolve_ip_route() is not helpful.
Therefore, the code is simplified to avoid IFF_LOOPBACK check.

Fixes: 20029832

 ("IB/core: Validate route when we init ah")
Reviewed-by: default avatarDaniel Jurgens <>
Signed-off-by: default avatarParav Pandit <>
Signed-off-by: default avatarLeon Romanovsky <>
Signed-off-by: default avatarDoug Ledford <>
parent 942c9b6c
......@@ -1291,10 +1291,9 @@ int ib_init_ah_attr_from_path(struct ib_device *device, u8 port_num,
resolved_dev = dev_get_by_index(,
if (resolved_dev->flags & IFF_LOOPBACK) {
resolved_dev = idev;
if (!resolved_dev) {
return -ENODEV;
ndev = ib_get_ndev_from_path(rec);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment