checkpatch.pl 41.8 KB
Newer Older
1
2
#!/usr/bin/perl -w
# (c) 2001, Dave Jones. <davej@codemonkey.org.uk> (the file handling bit)
3
# (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4
5
6
7
8
9
# (c) 2007, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite, etc)
# Licensed under the terms of the GNU GPL License version 2

use strict;

my $P = $0;
10
$P =~ s@.*/@@g;
11

12
my $V = '0.12';
13
14
15
16
17
18
19

use Getopt::Long qw(:config no_auto_abbrev);

my $quiet = 0;
my $tree = 1;
my $chk_signoff = 1;
my $chk_patch = 1;
20
my $tst_type = 0;
21
my $emacs = 0;
22
my $terse = 0;
23
24
my $file = 0;
my $check = 0;
25
26
my $summary = 1;
my $mailback = 0;
27
my $root;
28
GetOptions(
29
	'q|quiet+'	=> \$quiet,
30
31
32
	'tree!'		=> \$tree,
	'signoff!'	=> \$chk_signoff,
	'patch!'	=> \$chk_patch,
33
	'test-type!'	=> \$tst_type,
34
	'emacs!'	=> \$emacs,
35
	'terse!'	=> \$terse,
36
37
38
39
	'file!'		=> \$file,
	'subjective!'	=> \$check,
	'strict!'	=> \$check,
	'root=s'	=> \$root,
40
41
	'summary!'	=> \$summary,
	'mailback!'	=> \$mailback,
42
43
44
45
46
) or exit;

my $exit = 0;

if ($#ARGV < 0) {
47
	print "usage: $P [options] patchfile\n";
48
49
50
	print "version: $V\n";
	print "options: -q           => quiet\n";
	print "         --no-tree    => run without a kernel tree\n";
51
	print "         --terse      => one line per report\n";
52
53
54
55
	print "         --emacs      => emacs compile window format\n";
	print "         --file       => check a source file\n";
	print "         --strict     => enable more subjective tests\n";
	print "         --root       => path to the kernel tree root\n";
56
57
58
	exit(1);
}

59
60
61
62
63
if ($terse) {
	$emacs = 1;
	$quiet++;
}

64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
if ($tree) {
	if (defined $root) {
		if (!top_of_kernel_tree($root)) {
			die "$P: $root: --root does not point at a valid tree\n";
		}
	} else {
		if (top_of_kernel_tree('.')) {
			$root = '.';
		} elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
						top_of_kernel_tree($1)) {
			$root = $1;
		}
	}

	if (!defined $root) {
		print "Must be run from the top-level dir. of a kernel tree\n";
		exit(2);
	}
82
83
}

84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
my $emitted_corrupt = 0;

our $Ident       = qr{[A-Za-z_][A-Za-z\d_]*};
our $Storage	= qr{extern|static|asmlinkage};
our $Sparse	= qr{
			__user|
			__kernel|
			__force|
			__iomem|
			__must_check|
			__init_refok|
			__kprobes|
			fastcall
		}x;
our $Attribute	= qr{
			const|
			__read_mostly|
			__kprobes|
			__(?:mem|cpu|dev|)(?:initdata|init)
		  }x;
our $Inline	= qr{inline|__always_inline|noinline};
our $Member	= qr{->$Ident|\.$Ident|\[[^]]*\]};
our $Lval	= qr{$Ident(?:$Member)*};

our $Constant	= qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*};
our $Assignment	= qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
our $Operators	= qr{
			<=|>=|==|!=|
			=>|->|<<|>>|<|>|!|~|
			&&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/
		  }x;

116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
our $NonptrType;
our $Type;
our $Declare;

our @typeList = (
	qr{void},
	qr{char},
	qr{short},
	qr{int},
	qr{long},
	qr{unsigned},
	qr{float},
	qr{double},
	qr{bool},
	qr{long\s+int},
	qr{long\s+long},
	qr{long\s+long\s+int},
	qr{(?:__)?(?:u|s|be|le)(?:8|16|32|64)},
	qr{struct\s+$Ident},
	qr{union\s+$Ident},
	qr{enum\s+$Ident},
	qr{${Ident}_t},
	qr{${Ident}_handler},
	qr{${Ident}_handler_fn},
);

sub build_types {
	my $all = "(?:  \n" . join("|\n  ", @typeList) . "\n)";
	$NonptrType	= qr{
			\b
			(?:const\s+)?
			(?:unsigned\s+)?
			$all
			(?:\s+$Sparse|\s+const)*
			\b
		  }x;
	$Type	= qr{
			\b$NonptrType\b
			(?:\s*\*+\s*const|\s*\*+|(?:\s*\[\s*\])+)?
			(?:\s+$Sparse|\s+$Attribute)*
		  }x;
	$Declare	= qr{(?:$Storage\s+)?$Type};
}
build_types();
160
161
162

$chk_signoff = 0 if ($file);

163
164
my @dep_includes = ();
my @dep_functions = ();
165
166
167
168
my $removal = "Documentation/feature-removal-schedule.txt";
if ($tree && -f "$root/$removal") {
	open(REMOVE, "<$root/$removal") ||
				die "$P: $removal: open failed - $!\n";
169
	while (<REMOVE>) {
170
171
172
		if (/^Check:\s+(.*\S)/) {
			for my $entry (split(/[, ]+/, $1)) {
				if ($entry =~ m@include/(.*)@) {
173
174
					push(@dep_includes, $1);

175
176
177
				} elsif ($entry !~ m@/@) {
					push(@dep_functions, $entry);
				}
178
			}
179
180
181
182
		}
	}
}

183
my @rawlines = ();
184
185
186
187
188
189
190
for my $filename (@ARGV) {
	if ($file) {
		open(FILE, "diff -u /dev/null $filename|") ||
			die "$P: $filename: diff failed - $!\n";
	} else {
		open(FILE, "<$filename") ||
			die "$P: $filename: open failed - $!\n";
191
	}
192
193
194
195
196
197
198
199
200
	while (<FILE>) {
		chomp;
		push(@rawlines, $_);
	}
	close(FILE);
	if (!process($filename, @rawlines)) {
		$exit = 1;
	}
	@rawlines = ();
201
202
203
204
205
}

exit($exit);

sub top_of_kernel_tree {
206
207
208
209
210
211
212
213
214
215
216
217
	my ($root) = @_;

	my @tree_check = (
		"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
		"README", "Documentation", "arch", "include", "drivers",
		"fs", "init", "ipc", "kernel", "lib", "scripts",
	);

	foreach my $check (@tree_check) {
		if (! -e $root . '/' . $check) {
			return 0;
		}
218
	}
219
	return 1;
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
}

sub expand_tabs {
	my ($str) = @_;

	my $res = '';
	my $n = 0;
	for my $c (split(//, $str)) {
		if ($c eq "\t") {
			$res .= ' ';
			$n++;
			for (; ($n % 8) != 0; $n++) {
				$res .= ' ';
			}
			next;
		}
		$res .= $c;
		$n++;
	}

	return $res;
}
242
243
244
245
246
247
248
249
250
251
252
253
254
255
sub copy_spacing {
	my ($str) = @_;

	my $res = '';
	for my $c (split(//, $str)) {
		if ($c eq "\t") {
			$res .= $c;
		} else {
			$res .= ' ';
		}
	}

	return $res;
}
256

257
258
259
260
261
262
263
264
265
266
267
268
269
sub line_stats {
	my ($line) = @_;

	# Drop the diff line leader and expand tabs
	$line =~ s/^.//;
	$line = expand_tabs($line);

	# Pick the indent from the front of the line.
	my ($white) = ($line =~ /^(\s*)/);

	return (length($line), length($white));
}

270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
sub sanitise_line {
	my ($line) = @_;

	my $res = '';
	my $l = '';

	my $quote = '';

	foreach my $c (split(//, $line)) {
		if ($l ne "\\" && ($c eq "'" || $c eq '"')) {
			if ($quote eq '') {
				$quote = $c;
				$res .= $c;
				$l = $c;
				next;
			} elsif ($quote eq $c) {
				$quote = '';
			}
		}
		if ($quote && $c ne "\t") {
			$res .= "X";
		} else {
			$res .= $c;
		}

		$l = $c;
	}

	return $res;
}

301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
sub ctx_statement_block {
	my ($linenr, $remain, $off) = @_;
	my $line = $linenr - 1;
	my $blk = '';
	my $soff = $off;
	my $coff = $off - 1;

	my $type = '';
	my $level = 0;
	my $c;
	my $len = 0;
	while (1) {
		#warn "CSB: blk<$blk>\n";
		# If we are about to drop off the end, pull in more
		# context.
		if ($off >= $len) {
			for (; $remain > 0; $line++) {
				next if ($rawlines[$line] =~ /^-/);
				$remain--;
				$blk .= sanitise_line($rawlines[$line]) . "\n";
				$len = length($blk);
				$line++;
				last;
			}
			# Bail if there is no further context.
			#warn "CSB: blk<$blk> off<$off> len<$len>\n";
			if ($off == $len) {
				last;
			}
		}
		$c = substr($blk, $off, 1);

		#warn "CSB: c<$c> type<$type> level<$level>\n";
		# Statement ends at the ';' or a close '}' at the
		# outermost level.
		if ($level == 0 && $c eq ';') {
			last;
		}

		if (($type eq '' || $type eq '(') && $c eq '(') {
			$level++;
			$type = '(';
		}
		if ($type eq '(' && $c eq ')') {
			$level--;
			$type = ($level != 0)? '(' : '';

			if ($level == 0 && $coff < $soff) {
				$coff = $off;
			}
		}
		if (($type eq '' || $type eq '{') && $c eq '{') {
			$level++;
			$type = '{';
		}
		if ($type eq '{' && $c eq '}') {
			$level--;
			$type = ($level != 0)? '{' : '';

			if ($level == 0) {
				last;
			}
		}
		$off++;
	}

	my $statement = substr($blk, $soff, $off - $soff + 1);
	my $condition = substr($blk, $soff, $coff - $soff + 1);

	#warn "STATEMENT<$statement>\n";
	#warn "CONDITION<$condition>\n";

	return ($statement, $condition);
}

376
sub ctx_block_get {
377
	my ($linenr, $remain, $outer, $open, $close, $off) = @_;
378
379
380
381
382
383
384
	my $line;
	my $start = $linenr - 1;
	my $blk = '';
	my @o;
	my @c;
	my @res = ();

385
	my $level = 0;
386
387
388
389
390
	for ($line = $start; $remain > 0; $line++) {
		next if ($rawlines[$line] =~ /^-/);
		$remain--;

		$blk .= $rawlines[$line];
391
392
393
394
395
396
		foreach my $c (split(//, $rawlines[$line])) {
			##print "C<$c>L<$level><$open$close>O<$off>\n";
			if ($off > 0) {
				$off--;
				next;
			}
397

398
399
400
401
402
403
404
			if ($c eq $close && $level > 0) {
				$level--;
				last if ($level == 0);
			} elsif ($c eq $open) {
				$level++;
			}
		}
405

406
		if (!$outer || $level <= 1) {
407
			push(@res, $rawlines[$line]);
408
409
		}

410
		last if ($level == 0);
411
412
	}

413
	return ($level, @res);
414
415
416
417
}
sub ctx_block_outer {
	my ($linenr, $remain) = @_;

418
419
	my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
	return @r;
420
421
422
423
}
sub ctx_block {
	my ($linenr, $remain) = @_;

424
425
	my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
	return @r;
426
427
}
sub ctx_statement {
428
429
430
431
432
433
	my ($linenr, $remain, $off) = @_;

	my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
	return @r;
}
sub ctx_block_level {
434
435
	my ($linenr, $remain) = @_;

436
	return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
437
}
438
439
440
441
442
sub ctx_statement_level {
	my ($linenr, $remain, $off) = @_;

	return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
}
443
444
445
446
447

sub ctx_locate_comment {
	my ($first_line, $end_line) = @_;

	# Catch a comment on the end of the line itself.
448
	my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*$@);
449
450
451
452
453
454
455
	return $current_comment if (defined $current_comment);

	# Look through the context and try and figure out if there is a
	# comment.
	my $in_comment = 0;
	$current_comment = '';
	for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
456
457
		my $line = $rawlines[$linenr - 1];
		#warn "           $line\n";
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
		if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
			$in_comment = 1;
		}
		if ($line =~ m@/\*@) {
			$in_comment = 1;
		}
		if (!$in_comment && $current_comment ne '') {
			$current_comment = '';
		}
		$current_comment .= $line . "\n" if ($in_comment);
		if ($line =~ m@\*/@) {
			$in_comment = 0;
		}
	}

	chomp($current_comment);
	return($current_comment);
}
sub ctx_has_comment {
	my ($first_line, $end_line) = @_;
	my $cmt = ctx_locate_comment($first_line, $end_line);

480
	##print "LINE: $rawlines[$end_line - 1 ]\n";
481
482
483
484
485
	##print "CMMT: $cmt\n";

	return ($cmt ne '');
}

486
487
488
sub cat_vet {
	my ($vet) = @_;
	my ($res, $coded);
489

490
491
492
493
494
495
	$res = '';
	while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
		$res .= $1;
		if ($2 ne '') {
			$coded = sprintf("^%c", unpack('C', $2) + 64);
			$res .= $coded;
496
497
		}
	}
498
	$res =~ s/$/\$/;
499

500
	return $res;
501
502
}

503
504
sub annotate_values {
	my ($stream, $type) = @_;
505

506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
	my $res;
	my $cur = $stream;

	my $debug = 0;

	print "$stream\n" if ($debug);

	##my $type = 'N';
	my $pos = 0;
	my $preprocessor = 0;
	my $paren = 0;
	my @paren_type;

	while (length($cur)) {
		print " <$type> " if ($debug);
		if ($cur =~ /^(\s+)/o) {
			print "WS($1)\n" if ($debug);
			if ($1 =~ /\n/ && $preprocessor) {
				$preprocessor = 0;
				$type = 'N';
			}

528
		} elsif ($cur =~ /^($Type)/) {
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
			print "DECLARE($1)\n" if ($debug);
			$type = 'T';

		} elsif ($cur =~ /^(#\s*define\s*$Ident)(\(?)/o) {
			print "DEFINE($1)\n" if ($debug);
			$preprocessor = 1;
			$paren_type[$paren] = 'N';

		} elsif ($cur =~ /^(#\s*(?:ifdef|ifndef|if|else|endif))/o) {
			print "PRE($1)\n" if ($debug);
			$preprocessor = 1;
			$type = 'N';

		} elsif ($cur =~ /^(\\\n)/o) {
			print "PRECONT($1)\n" if ($debug);

		} elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
			print "SIZEOF($1)\n" if ($debug);
			if (defined $2) {
				$paren_type[$paren] = 'V';
			}
			$type = 'N';

552
		} elsif ($cur =~ /^(if|while|typeof|for)\b/o) {
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
			print "COND($1)\n" if ($debug);
			$paren_type[$paren] = 'N';
			$type = 'N';

		} elsif ($cur =~/^(return|case|else)/o) {
			print "KEYWORD($1)\n" if ($debug);
			$type = 'N';

		} elsif ($cur =~ /^(\()/o) {
			print "PAREN('$1')\n" if ($debug);
			$paren++;
			$type = 'N';

		} elsif ($cur =~ /^(\))/o) {
			$paren-- if ($paren > 0);
			if (defined $paren_type[$paren]) {
				$type = $paren_type[$paren];
				undef $paren_type[$paren];
				print "PAREN('$1') -> $type\n" if ($debug);
			} else {
				print "PAREN('$1')\n" if ($debug);
			}

		} elsif ($cur =~ /^($Ident)\(/o) {
			print "FUNC($1)\n" if ($debug);
			$paren_type[$paren] = 'V';

		} elsif ($cur =~ /^($Ident|$Constant)/o) {
			print "IDENT($1)\n" if ($debug);
			$type = 'V';

		} elsif ($cur =~ /^($Assignment)/o) {
			print "ASSIGN($1)\n" if ($debug);
			$type = 'N';

		} elsif ($cur =~ /^(;|{|}|\?|:|\[)/o) {
			print "END($1)\n" if ($debug);
			$type = 'N';

		} elsif ($cur =~ /^($Operators)/o) {
			print "OP($1)\n" if ($debug);
			if ($1 ne '++' && $1 ne '--') {
				$type = 'N';
			}

		} elsif ($cur =~ /(^.)/o) {
			print "C($1)\n" if ($debug);
		}
		if (defined $1) {
			$cur = substr($cur, length($1));
			$res .= $type x length($1);
		}
605
	}
606

607
	return $res;
608
609
}

610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
sub possible {
	my ($possible) = @_;

	#print "CHECK<$possible>\n";
	if ($possible !~ /^(?:$Storage|$Type|DEFINE_\S+)$/ &&
	    $possible ne 'goto' && $possible ne 'return' &&
	    $possible ne 'struct' && $possible ne 'enum' &&
	    $possible ne 'case' && $possible ne 'else' &&
	    $possible ne 'typedef') {
		#print "POSSIBLE<$possible>\n";
		push(@typeList, $possible);
		build_types();
	}
}

625
626
my $prefix = '';

627
628
my @report = ();
sub report {
629
630
631
632
633
	my $line = $prefix . $_[0];

	$line = (split('\n', $line))[0] . "\n" if ($terse);

	push(@report, $line);
634
635
636
637
}
sub report_dump {
	@report;
}
638
sub ERROR {
639
	report("ERROR: $_[0]\n");
640
	our $clean = 0;
641
	our $cnt_error++;
642
643
}
sub WARN {
644
	report("WARNING: $_[0]\n");
645
	our $clean = 0;
646
	our $cnt_warn++;
647
648
}
sub CHK {
649
650
651
652
653
	if ($check) {
		report("CHECK: $_[0]\n");
		our $clean = 0;
		our $cnt_chk++;
	}
654
655
}

656
657
658
659
660
661
662
663
sub process {
	my $filename = shift;
	my @lines = @_;

	my $linenr=0;
	my $prevline="";
	my $stashline="";

664
	my $length;
665
666
667
668
	my $indent;
	my $previndent=0;
	my $stashindent=0;

669
	our $clean = 1;
670
671
672
	my $signoff = 0;
	my $is_patch = 0;

673
674
675
676
677
	our $cnt_lines = 0;
	our $cnt_error = 0;
	our $cnt_warn = 0;
	our $cnt_chk = 0;

678
679
680
681
682
683
684
685
	# Trace the real file/line as we go.
	my $realfile = '';
	my $realline = 0;
	my $realcnt = 0;
	my $here = '';
	my $in_comment = 0;
	my $first_line = 0;

686
	my $prev_values = 'N';
687

688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
	# Pre-scan the patch looking for any __setup documentation.
	my @setup_docs = ();
	my $setup_docs = 0;
	foreach my $line (@lines) {
		if ($line=~/^\+\+\+\s+(\S+)/) {
			$setup_docs = 0;
			if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
				$setup_docs = 1;
			}
			next;
		}

		if ($setup_docs && $line =~ /^\+/) {
			push(@setup_docs, $line);
		}
	}

705
706
	$prefix = '';

707
708
709
	foreach my $line (@lines) {
		$linenr++;

710
711
		my $rawline = $line;

712

713
714
715
#extract the filename as it passes
		if ($line=~/^\+\+\+\s+(\S+)/) {
			$realfile=$1;
716
			$realfile =~ s@^[^/]*/@@;
717
718
719
720
			$in_comment = 0;
			next;
		}
#extract the line range in the file after the patch is applied
721
		if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
722
			$is_patch = 1;
723
			$first_line = $linenr + 1;
724
725
726
727
728
729
730
			$in_comment = 0;
			$realline=$1-1;
			if (defined $2) {
				$realcnt=$3+1;
			} else {
				$realcnt=1+1;
			}
731
			$prev_values = 'N';
732
733
734
			next;
		}

735
736
737
738
# track the line number as we move through the hunk, note that
# new versions of GNU diff omit the leading space on completely
# blank context lines so we need to count that too.
		if ($line =~ /^( |\+|$)/) {
739
			$realline++;
740
			$realcnt-- if ($realcnt != 0);
741

742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
			# Guestimate if this is a continuing comment.  Run
			# the context looking for a comment "edge".  If this
			# edge is a close comment then we must be in a comment
			# at context start.
			if ($linenr == $first_line) {
				my $edge;
				for (my $ln = $first_line; $ln < ($linenr + $realcnt); $ln++) {
					($edge) = ($lines[$ln - 1] =~ m@(/\*|\*/)@);
					last if (defined $edge);
				}
				if (defined $edge && $edge eq '*/') {
					$in_comment = 1;
				}
			}

757
758
759
			# Guestimate if this is a continuing comment.  If this
			# is the start of a diff block and this line starts
			# ' *' then it is very likely a comment.
760
			if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
761
762
				$in_comment = 1;
			}
763
764
765
766
767
768
769
770

			# Find the last comment edge on _this_ line.
			while (($line =~ m@(/\*|\*/)@g)) {
				if ($1 eq '/*') {
					$in_comment = 1;
				} else {
					$in_comment = 0;
				}
771
772
			}

773
774
			# Measure the line length and indent.
			($length, $indent) = line_stats($line);
775
776
777
778

			# Track the previous line.
			($prevline, $stashline) = ($stashline, $line);
			($previndent, $stashindent) = ($stashindent, $indent);
779

780
781
		} elsif ($realcnt == 1) {
			$realcnt--;
782
783
784
		}

#make up the handle for any error we report on this line
785
786
		$here = "#$linenr: " if (!$file);
		$here = "#$realline: " if ($file);
787
		$here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
788

789
		my $hereline = "$here\n$line\n";
790
791
		my $herecurr = "$here\n$line\n";
		my $hereprev = "$here\n$prevline\n$line\n";
792

793
794
795
796
		$prefix = "$filename:$realline: " if ($emacs && $file);
		$prefix = "$filename:$linenr: " if ($emacs && !$file);
		$cnt_lines++ if ($realcnt != 0);

797
#check the patch for a signoff:
798
		if ($line =~ /^\s*signed-off-by:/i) {
799
800
			# This is a signoff, if ugly, so do not double report.
			$signoff++;
801
			if (!($line =~ /^\s*Signed-off-by:/)) {
802
803
				WARN("Signed-off-by: is the preferred form\n" .
					$herecurr);
804
805
			}
			if ($line =~ /^\s*signed-off-by:\S/i) {
806
807
				WARN("need space after Signed-off-by:\n" .
					$herecurr);
808
809
810
			}
		}

811
# Check for wrappage within a valid hunk of the file
812
		if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
813
			ERROR("patch seems to be corrupt (line wrapped?)\n" .
814
				$herecurr) if (!$emitted_corrupt++);
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
		}

# UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
		if (($realfile =~ /^$/ || $line =~ /^\+/) &&
		     !($line =~ m/^(
				[\x09\x0A\x0D\x20-\x7E]              # ASCII
				| [\xC2-\xDF][\x80-\xBF]             # non-overlong 2-byte
				|  \xE0[\xA0-\xBF][\x80-\xBF]        # excluding overlongs
				| [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2}  # straight 3-byte
				|  \xED[\x80-\x9F][\x80-\xBF]        # excluding surrogates
				|  \xF0[\x90-\xBF][\x80-\xBF]{2}     # planes 1-3
				| [\xF1-\xF3][\x80-\xBF]{3}          # planes 4-15
				|  \xF4[\x80-\x8F][\x80-\xBF]{2}     # plane 16
				)*$/x )) {
			ERROR("Invalid UTF-8\n" . $herecurr);
830
831
832
833
		}

#ignore lines being removed
		if ($line=~/^-/) {next;}
834

835
836
# check we are in a valid source file if not then ignore this hunk
		next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
837
838

#trailing whitespace
839
840
841
842
843
		if ($line =~ /^\+.*\015/) {
			my $herevet = "$here\n" . cat_vet($line) . "\n";
			ERROR("DOS line endings\n" . $herevet);

		} elsif ($line =~ /^\+.*\S\s+$/ || $line =~ /^\+\s+$/) {
844
845
			my $herevet = "$here\n" . cat_vet($line) . "\n";
			ERROR("trailing whitespace\n" . $herevet);
846
847
		}
#80 column limit
848
		if ($line =~ /^\+/ && !($prevline=~/\/\*\*/) && $length > 80) {
849
			WARN("line over 80 characters\n" . $herecurr);
850
851
		}

852
853
854
855
856
# check for adding lines without a newline.
		if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
			WARN("adding a line without newline at end of file\n" . $herecurr);
		}

857
858
859
860
861
862
# check we are in a valid source file *.[hc] if not then ignore this hunk
		next if ($realfile !~ /\.[hc]$/);

# at the beginning of a line any tabs must come first and anything
# more than 8 must use tabs.
		if ($line=~/^\+\s* \t\s*\S/ or $line=~/^\+\s*        \s*/) {
863
864
			my $herevet = "$here\n" . cat_vet($line) . "\n";
			ERROR("use tabs not spaces\n" . $herevet);
865
866
		}

867
# Remove comments from the line before processing.
868
869
870
871
872
873
874
875
		my $comment_edge = ($line =~ s@/\*.*\*/@@g) +
				   ($line =~ s@/\*.*@@) +
				   ($line =~ s@^(.).*\*/@$1@);

# The rest of our checks refer specifically to C style
# only apply those _outside_ comments.  Only skip
# lines in the middle of comments.
		next if (!$comment_edge && $in_comment);
876

877
878
879
# Standardise the strings and chars within the input to simplify matching.
		$line = sanitise_line($line);

880
881
882
# Check for potential 'bare' types
		if ($realcnt &&
		    $line !~ /$Ident:\s*$/ &&
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
		    ($line =~ /^.\s*$Ident\s*\(\*+\s*$Ident\)\s*\(/ ||
		     $line !~ /^.\s*$Ident\s*\(/)) {
			# definitions in global scope can only start with types
			if ($line =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b/) {
				possible($1);

			# declarations always start with types
			} elsif ($prev_values eq 'N' && $line =~ /^.\s*(?:$Storage\s+)?($Ident)\b\s*\**\s*$Ident\s*(?:;|=)/) {
				possible($1);

			# any (foo ... *) is a pointer cast, and foo is a type
			} elsif ($line =~ /\(($Ident)(?:\s+$Sparse)*\s*\*+\s*\)/) {
				possible($1);
			}

			# Check for any sort of function declaration.
			# int foo(something bar, other baz);
			# void (*store_gdt)(x86_descr_ptr *);
			if ($prev_values eq 'N' && $line =~ /^(.(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/) {
				my ($name_len) = length($1);
				my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, $name_len);
				my $ctx = join("\n", @ctx);

				$ctx =~ s/\n.//;
				substr($ctx, 0, $name_len + 1) = '';
				$ctx =~ s/\)[^\)]*$//;
				for my $arg (split(/\s*,\s*/, $ctx)) {
					if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/ || $arg =~ /^($Ident)$/) {

						possible($1);
					}
				}
915
			}
916

917
918
		}

919
920
921
#
# Checks which may be anchored in the context.
#
922

923
924
# Check for switch () and associated case and default
# statements should be at the same indent.
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
		if ($line=~/\bswitch\s*\(.*\)/) {
			my $err = '';
			my $sep = '';
			my @ctx = ctx_block_outer($linenr, $realcnt);
			shift(@ctx);
			for my $ctx (@ctx) {
				my ($clen, $cindent) = line_stats($ctx);
				if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
							$indent != $cindent) {
					$err .= "$sep$ctx\n";
					$sep = '';
				} else {
					$sep = "[...]\n";
				}
			}
			if ($err ne '') {
941
				ERROR("switch and case should be at the same indent\n$hereline$err");
942
943
944
945
946
947
			}
		}

# if/while/etc brace do not go on next line, unless defining a do while loop,
# or if that brace on the next line is for something else
		if ($line =~ /\b(?:(if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.#/) {
948
			my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
949
950
951
952
			my $ctx_ln = $linenr + $#ctx + 1;
			my $ctx_cnt = $realcnt - $#ctx - 1;
			my $ctx = join("\n", @ctx);

953
			# Skip over any removed lines in the context following statement.
954
955
956
957
958
959
960
			while ($ctx_cnt > 0 && $lines[$ctx_ln - 1] =~ /^-/) {
				$ctx_ln++;
				$ctx_cnt--;
			}
			##warn "line<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>";

			if ($ctx !~ /{\s*/ && $ctx_cnt > 0 && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
961
				ERROR("That open brace { should be on the previous line\n" .
962
					"$here\n$ctx\n$lines[$ctx_ln - 1]");
963
			}
964
965
966
967
968
969
970
			if ($level == 0 && $ctx =~ /\)\s*\;\s*$/ && defined $lines[$ctx_ln - 1]) {
				my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
				if ($nindent > $indent) {
					WARN("Trailing semicolon indicates no statements, indent implies otherwise\n" .
						"$here\n$ctx\n$lines[$ctx_ln - 1]");
				}
			}
971
972
		}

973
974
975
976
977
978
979
980
		# Track the 'values' across context and added lines.
		my $opline = $line; $opline =~ s/^./ /;
		my $curr_values = annotate_values($opline . "\n", $prev_values);
		$curr_values = $prev_values . $curr_values;
		#warn "--> $opline\n";
		#warn "--> $curr_values ($prev_values)\n";
		$prev_values = substr($curr_values, -1);

981
982
983
#ignore lines not being added
		if ($line=~/^[^\+]/) {next;}

984
985
# TEST: allow direct testing of the type matcher.
		if ($tst_type && $line =~ /^.$Declare$/) {
986
			ERROR("TEST: is type $Declare\n" . $herecurr);
987
988
989
			next;
		}

990
991
992
993
994
995
# check for initialisation to aggregates open brace on the next line
		if ($prevline =~ /$Declare\s*$Ident\s*=\s*$/ &&
		    $line =~ /^.\s*{/) {
			ERROR("That open brace { should be on the previous line\n" . $hereprev);
		}

996
997
998
999
1000
1001
1002
1003
#
# Checks which are anchored on the added line.
#

# check for malformed paths in #include statements (uses RAW line)
		if ($rawline =~ m{^.#\s*include\s+[<"](.*)[">]}) {
			my $path = $1;
			if ($path =~ m{//}) {
1004
1005
				ERROR("malformed #include filename\n" .
					$herecurr);
1006
1007
1008
1009
1010
			}
			# Sanitise this special form of string.
			$path = 'X' x length($path);
			$line =~ s{\<.*\>}{<$path>};
		}
1011

1012
# no C99 // comments
1013
		if ($line =~ m{//}) {
1014
			ERROR("do not use C99 // comments\n" . $herecurr);
1015
		}
1016
		# Remove C99 comments.
1017
		$line =~ s@//.*@@;
1018
		$opline =~ s@//.*@@;
1019
1020

#EXPORT_SYMBOL should immediately follow its function closing }.
1021
1022
1023
		if (($line =~ /EXPORT_SYMBOL.*\((.*)\)/) ||
		    ($line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
			my $name = $1;
1024
1025
			if (($prevline !~ /^}/) &&
			   ($prevline !~ /^\+}/) &&
1026
			   ($prevline !~ /^ }/) &&
1027
			   ($prevline !~ /\b\Q$name\E(?:\s+$Attribute)?\s*(?:;|=)/)) {
1028
				WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
1029
1030
1031
			}
		}

1032
1033
1034
1035
1036
# check for external initialisers.
		if ($line =~ /^.$Type\s*$Ident\s*=\s*(0|NULL);/) {
			ERROR("do not initialise externals to 0 or NULL\n" .
				$herecurr);
		}
1037
# check for static initialisers.
1038
		if ($line =~ /\s*static\s.*=\s*(0|NULL);/) {
1039
1040
			ERROR("do not initialise statics to 0 or NULL\n" .
				$herecurr);
1041
1042
		}

1043
1044
1045
# check for new typedefs, only function parameters and sparse annotations
# make sense.
		if ($line =~ /\btypedef\s/ &&
1046
		    $line !~ /\btypedef\s+$Type\s+\(\s*\*?$Ident\s*\)\s*\(/ &&
1047
		    $line !~ /\b__bitwise(?:__|)\b/) {
1048
			WARN("do not add new typedefs\n" . $herecurr);
1049
1050
1051
		}

# * goes on variable not on type
1052
		if ($line =~ m{\($NonptrType(\*+)(?:\s+const)?\)}) {
1053
1054
			ERROR("\"(foo$1)\" should be \"(foo $1)\"\n" .
				$herecurr);
1055
1056

		} elsif ($line =~ m{\($NonptrType\s+(\*+)(?!\s+const)\s+\)}) {
1057
1058
			ERROR("\"(foo $1 )\" should be \"(foo $1)\"\n" .
				$herecurr);
1059

1060
		} elsif ($line =~ m{$NonptrType(\*+)(?:\s+(?:$Attribute|$Sparse))?\s+[A-Za-z\d_]+}) {
1061
1062
			ERROR("\"foo$1 bar\" should be \"foo $1bar\"\n" .
				$herecurr);
1063

1064
		} elsif ($line =~ m{$NonptrType\s+(\*+)(?!\s+(?:$Attribute|$Sparse))\s+[A-Za-z\d_]+}) {
1065
1066
			ERROR("\"foo $1 bar\" should be \"foo $1bar\"\n" .
				$herecurr);
1067
1068
1069
1070
1071
1072
1073
1074
1075
		}

# # no BUG() or BUG_ON()
# 		if ($line =~ /\b(BUG|BUG_ON)\b/) {
# 			print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
# 			print "$herecurr";
# 			$clean = 0;
# 		}

1076
1077
1078
1079
		if ($line =~ /\bLINUX_VERSION_CODE\b/) {
			WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged" . $herecurr);
		}

1080
1081
1082
1083
1084
# printk should use KERN_* levels.  Note that follow on printk's on the
# same line do not need a level, so we use the current block context
# to try and find and validate the current printk.  In summary the current
# printk includes all preceeding printk's which have no newline on the end.
# we assume the first bad printk is the one to report.
1085
		if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
			my $ok = 0;
			for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
				#print "CHECK<$lines[$ln - 1]\n";
				# we have a preceeding printk if it ends
				# with "\n" ignore it, else it is to blame
				if ($lines[$ln - 1] =~ m{\bprintk\(}) {
					if ($rawlines[$ln - 1] !~ m{\\n"}) {
						$ok = 1;
					}
					last;
				}
			}
			if ($ok == 0) {
1099
				WARN("printk() should include KERN_ facility level\n" . $herecurr);
1100
			}
1101
1102
		}

1103
1104
# function brace can't be on same line, except for #defines of do while,
# or if closed on same line
1105
		if (($line=~/$Type\s*[A-Za-z\d_]+\(.*\).* {/) and
1106
		    !($line=~/\#define.*do\s{/) and !($line=~/}/)) {
1107
			ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr);
1108
		}
1109

1110
1111
1112
1113
1114
1115
# open braces for enum, union and struct go on the same line.
		if ($line =~ /^.\s*{/ &&
		    $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
			ERROR("open brace '{' following $1 go on the same line\n" . $hereprev);
		}

1116
# check for spaces between functions and their parentheses.
1117
1118
1119
1120
1121
		while ($line =~ /($Ident)\s+\(/g) {
			if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/ &&
		            $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) {
				WARN("no space between function name and open parenthesis '('\n" . $herecurr);
			}
1122
		}
1123
# Check operator spacing.
1124
		if (!($line=~/\#\s*include/)) {
1125
1126
1127
1128
1129
1130
1131
			my $ops = qr{
				<<=|>>=|<=|>=|==|!=|
				\+=|-=|\*=|\/=|%=|\^=|\|=|&=|
				=>|->|<<|>>|<|>|=|!|~|
				&&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/
			}x;
			my @elements = split(/($ops|;)/, $opline);
1132
			my $off = 0;
1133
1134
1135

			my $blank = copy_spacing($opline);

1136
			for (my $n = 0; $n < $#elements; $n += 2) {
1137
1138
1139
1140
1141
1142
1143
1144
1145
				$off += length($elements[$n]);

				my $a = '';
				$a = 'V' if ($elements[$n] ne '');
				$a = 'W' if ($elements[$n] =~ /\s$/);
				$a = 'B' if ($elements[$n] =~ /(\[|\()$/);
				$a = 'O' if ($elements[$n] eq '');
				$a = 'E' if ($elements[$n] eq '' && $n == 0);

1146
				my $op = $elements[$n + 1];
1147
1148

				my $c = '';
1149
				if (defined $elements[$n + 2]) {
1150
1151
1152
1153
					$c = 'V' if ($elements[$n + 2] ne '');
					$c = 'W' if ($elements[$n + 2] =~ /^\s/);
					$c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
					$c = 'O' if ($elements[$n + 2] eq '');
1154
					$c = 'E' if ($elements[$n + 2] =~ /\s*\\$/);
1155
1156
				} else {
					$c = 'E';
1157
1158
				}

1159
				# Pick up the preceeding and succeeding characters.
1160
				my $ca = substr($opline, 0, $off);
1161
				my $cc = '';
1162
				if (length($opline) >= ($off + length($elements[$n + 1]))) {
1163
					$cc = substr($opline, $off + length($elements[$n + 1]));
1164
				}
1165
				my $cb = "$ca$;$cc";
1166

1167
1168
1169
1170
				my $ctx = "${a}x${c}";

				my $at = "(ctx:$ctx)";

1171
				my $ptr = substr($blank, 0, $off) . "^";
1172
				my $hereptr = "$hereline$ptr\n";
1173

1174
1175
1176
				# Classify operators into binary, unary, or
				# definitions (* only) where they have more
				# than one mode.
1177
1178
1179
1180
1181
1182
1183
1184
1185
				my $op_type = substr($curr_values, $off + 1, 1);
				my $op_left = substr($curr_values, $off, 1);
				my $is_unary;
				if ($op_type eq 'T') {
					$is_unary = 2;
				} elsif ($op_left eq 'V') {
					$is_unary = 0;
				} else {
					$is_unary = 1;
1186
1187
				}
				#if ($op eq '-' || $op eq '&' || $op eq '*') {
1188
				#	print "UNARY: <$op_left$op_type $is_unary $a:$op:$c> <$ca:$op:$cc> <$unary_ctx>\n";
1189
				#}
1190

1191
1192
				# ; should have either the end of line or a space or \ after it
				if ($op eq ';') {
1193
1194
1195
					if ($ctx !~ /.x[WEB]/ && $cc !~ /^\\/ &&
					    $cc !~ /^;/) {
						ERROR("need space after that '$op' $at\n" . $hereptr);
1196
1197
1198
1199
					}

				# // is a comment
				} elsif ($op eq '//') {
1200
1201
1202

				# -> should have no spaces
				} elsif ($op eq '->') {
1203
					if ($ctx =~ /Wx.|.xW/) {
1204
						ERROR("no spaces around that '$op' $at\n" . $hereptr);
1205
1206
1207
1208
					}

				# , must have a space on the right.
				} elsif ($op eq ',') {
1209
					if ($ctx !~ /.xW|.xE/ && $cc !~ /^}/) {
1210
						ERROR("need space after that '$op' $at\n" . $hereptr);
1211
1212
					}

1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
				# '*' as part of a type definition -- reported already.
				} elsif ($op eq '*' && $is_unary == 2) {
					#warn "'*' is part of type\n";

				# unary operators should have a space before and
				# none after.  May be left adjacent to another
				# unary operator, or a cast
				} elsif ($op eq '!' || $op eq '~' ||
				         ($is_unary && ($op eq '*' || $op eq '-' || $op eq '&'))) {
					if ($ctx !~ /[WEB]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
1223
						ERROR("need space before that '$op' $at\n" . $hereptr);
1224
					}
1225
					if ($ctx =~ /.xW/) {
1226
						ERROR("no space after that '$op' $at\n" . $hereptr);
1227
1228
1229
1230
					}

				# unary ++ and unary -- are allowed no space on one side.
				} elsif ($op eq '++' or $op eq '--') {
1231
					if ($ctx !~ /[WOB]x[^W]/ && $ctx !~ /[^W]x[WOBE]/) {
1232
						ERROR("need space one side of that '$op' $at\n" . $hereptr);
1233
					}
1234
					if ($ctx =~ /Wx./ && $cc =~ /^;/) {
1235
						ERROR("no space before that '$op' $at\n" . $hereptr);
1236
					}
1237
1238

				# << and >> may either have or not have spaces both sides
1239
1240
1241
1242
				} elsif ($op eq '<<' or $op eq '>>' or
					 $op eq '&' or $op eq '^' or $op eq '|' or
					 $op eq '+' or $op eq '-' or
					 $op eq '*' or $op eq '/')
1243
				{
1244
					if ($ctx !~ /VxV|WxW|VxE|WxE|VxO/) {
1245
1246
						ERROR("need consistent spacing around '$op' $at\n" .
							$hereptr);
1247
1248
1249
					}

				# All the others need spaces both sides.
1250
				} elsif ($ctx !~ /[EW]x[WE]/) {
1251
1252
1253
1254
1255
					# Ignore email addresses <foo@bar>
					if (!($op eq '<' && $cb =~ /$;\S+\@\S+>/) &&
					    !($op eq '>' && $cb =~ /<\S+\@\S+$;/)) {
						ERROR("need spaces around that '$op' $at\n" . $hereptr);
					}
1256
				}
1257
				$off += length($elements[$n + 1]);
1258
1259
1260
			}
		}

1261
1262
# check for multiple assignments
		if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
1263
			CHK("multiple assignments should be avoided\n" . $herecurr);
1264
1265
		}

1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
## # check for multiple declarations, allowing for a function declaration
## # continuation.
## 		if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
##
## 			# Remove any bracketed sections to ensure we do not
## 			# falsly report the parameters of functions.
## 			my $ln = $line;
## 			while ($ln =~ s/\([^\(\)]*\)//g) {
## 			}
## 			if ($ln =~ /,/) {
## 				WARN("declaring multiple variables together should be avoided\n" . $herecurr);
## 			}
## 		}
1280

1281
#need space before brace following if, while, etc
1282
1283
		if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
		    $line =~ /do{/) {
1284
1285
1286
1287
1288
1289
1290
			ERROR("need a space before the open brace '{'\n" . $herecurr);
		}

# closing brace should have a space following it when it has anything
# on the line
		if ($line =~ /}(?!(?:,|;|\)))\S/) {
			ERROR("need a space after that close brace '}'\n" . $herecurr);
1291
1292
		}

1293
1294
1295
1296
1297
1298
1299
1300
1301
# check spacing on square brackets
		if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
			ERROR("no space after that open square bracket '['\n" . $herecurr);
		}
		if ($line =~ /\s\]/) {
			ERROR("no space before that close square bracket ']'\n" . $herecurr);
		}

# check spacing on paretheses
1302
1303
		if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
		    $line !~ /for\s*\(\s+;/) {
1304
1305
			ERROR("no space after that open parenthesis '('\n" . $herecurr);
		}
1306
1307
		if ($line =~ /\s\)/ && $line !~ /^.\s*\)/ &&
		    $line !~ /for\s*\(.*;\s+\)/) {
1308
1309
1310
			ERROR("no space before that close parenthesis ')'\n" . $herecurr);
		}

1311
#goto labels aren't indented, allow a single space however
1312
		if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
1313
		   !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
1314
			WARN("labels should not be indented\n" . $herecurr);
1315
1316
1317
		}

# Need a space before open parenthesis after if, while etc
1318
		if ($line=~/\b(if|while|for|switch)\(/) {
1319
			ERROR("need a space before the open parenthesis '('\n" . $herecurr);
1320
1321
1322
		}

# Check for illegal assignment in if conditional.
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
		if ($line =~ /\bif\s*\(/) {
			my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);

			if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/) {
				ERROR("do not use assignment in if condition ($c)\n" . $herecurr);
			}

			# Find out what is on the end of the line after the
			# conditional.
			substr($s, 0, length($c)) = '';
			$s =~ s/\n.*//g;

			if (length($c) && $s !~ /^\s*({|;|\/\*.*\*\/)?\s*\\*\s*$/) {
				ERROR("trailing statements should be on next line\n" . $herecurr);
			}
		}

# if and else should not have general statements after it
		if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/ &&
		    $1 !~ /^\s*(?:\sif|{|\\|$)/) {
			ERROR("trailing statements should be on next line\n" . $herecurr);
1344
1345
1346
1347
1348
1349
		}

		# Check for }<nl>else {, these must be at the same
		# indent level to be relevant to each other.
		if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
						$previndent == $indent) {
1350
			ERROR("else should follow close brace '}'\n" . $hereprev);
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
		}

#studly caps, commented out until figure out how to distinguish between use of existing and adding new
#		if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
#		    print "No studly caps, use _\n";
#		    print "$herecurr";
#		    $clean = 0;
#		}

#no spaces allowed after \ in define
		if ($line=~/\#define.*\\\s$/) {
1362
			WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr);