checkpatch.pl 62.3 KB
Newer Older
1
2
#!/usr/bin/perl -w
# (c) 2001, Dave Jones. <davej@codemonkey.org.uk> (the file handling bit)
3
# (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4
5
6
7
8
9
# (c) 2007, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite, etc)
# Licensed under the terms of the GNU GPL License version 2

use strict;

my $P = $0;
10
$P =~ s@.*/@@g;
11

Andy Whitcroft's avatar
Andy Whitcroft committed
12
my $V = '0.21';
13
14
15
16
17
18
19

use Getopt::Long qw(:config no_auto_abbrev);

my $quiet = 0;
my $tree = 1;
my $chk_signoff = 1;
my $chk_patch = 1;
20
my $tst_only;
21
my $emacs = 0;
22
my $terse = 0;
23
24
my $file = 0;
my $check = 0;
25
26
my $summary = 1;
my $mailback = 0;
27
my $summary_file = 0;
28
my $root;
29
my %debug;
30
GetOptions(
31
	'q|quiet+'	=> \$quiet,
32
33
34
	'tree!'		=> \$tree,
	'signoff!'	=> \$chk_signoff,
	'patch!'	=> \$chk_patch,
35
	'emacs!'	=> \$emacs,
36
	'terse!'	=> \$terse,
37
38
39
40
	'file!'		=> \$file,
	'subjective!'	=> \$check,
	'strict!'	=> \$check,
	'root=s'	=> \$root,
41
42
	'summary!'	=> \$summary,
	'mailback!'	=> \$mailback,
43
44
	'summary-file!'	=> \$summary_file,

45
	'debug=s'	=> \%debug,
46
	'test-only=s'	=> \$tst_only,
47
48
49
50
51
) or exit;

my $exit = 0;

if ($#ARGV < 0) {
52
	print "usage: $P [options] patchfile\n";
53
	print "version: $V\n";
54
55
56
57
58
59
60
61
62
	print "options: -q               => quiet\n";
	print "         --no-tree        => run without a kernel tree\n";
	print "         --terse          => one line per report\n";
	print "         --emacs          => emacs compile window format\n";
	print "         --file           => check a source file\n";
	print "         --strict         => enable more subjective tests\n";
	print "         --root           => path to the kernel tree root\n";
	print "         --no-summary     => suppress the per-file summary\n";
	print "         --summary-file   => include the filename in summary\n";
63
64
65
	exit(1);
}

66
67
my $dbg_values = 0;
my $dbg_possible = 0;
68
my $dbg_type = 0;
69
my $dbg_attr = 0;
70
71
72
73
for my $key (keys %debug) {
	eval "\${dbg_$key} = '$debug{$key}';"
}

74
75
76
77
78
if ($terse) {
	$emacs = 1;
	$quiet++;
}

79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
if ($tree) {
	if (defined $root) {
		if (!top_of_kernel_tree($root)) {
			die "$P: $root: --root does not point at a valid tree\n";
		}
	} else {
		if (top_of_kernel_tree('.')) {
			$root = '.';
		} elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
						top_of_kernel_tree($1)) {
			$root = $1;
		}
	}

	if (!defined $root) {
		print "Must be run from the top-level dir. of a kernel tree\n";
		exit(2);
	}
97
98
}

99
100
101
102
103
104
105
106
107
108
109
my $emitted_corrupt = 0;

our $Ident       = qr{[A-Za-z_][A-Za-z\d_]*};
our $Storage	= qr{extern|static|asmlinkage};
our $Sparse	= qr{
			__user|
			__kernel|
			__force|
			__iomem|
			__must_check|
			__init_refok|
110
			__kprobes
111
112
113
114
115
116
117
		}x;
our $Attribute	= qr{
			const|
			__read_mostly|
			__kprobes|
			__(?:mem|cpu|dev|)(?:initdata|init)
		  }x;
118
our $Modifier;
119
120
121
122
123
124
125
126
127
our $Inline	= qr{inline|__always_inline|noinline};
our $Member	= qr{->$Ident|\.$Ident|\[[^]]*\]};
our $Lval	= qr{$Ident(?:$Member)*};

our $Constant	= qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*};
our $Assignment	= qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
our $Operators	= qr{
			<=|>=|==|!=|
			=>|->|<<|>>|<|>|!|~|
128
			&&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
129
130
		  }x;

131
132
133
134
our $NonptrType;
our $Type;
our $Declare;

135
136
137
138
139
140
141
142
143
144
145
our $UTF8	= qr {
	[\x09\x0A\x0D\x20-\x7E]              # ASCII
	| [\xC2-\xDF][\x80-\xBF]             # non-overlong 2-byte
	|  \xE0[\xA0-\xBF][\x80-\xBF]        # excluding overlongs
	| [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2}  # straight 3-byte
	|  \xED[\x80-\x9F][\x80-\xBF]        # excluding surrogates
	|  \xF0[\x90-\xBF][\x80-\xBF]{2}     # planes 1-3
	| [\xF1-\xF3][\x80-\xBF]{3}          # planes 4-15
	|  \xF4[\x80-\x8F][\x80-\xBF]{2}     # plane 16
}x;

146
147
our @typeList = (
	qr{void},
148
149
150
151
152
153
154
	qr{(?:unsigned\s+)?char},
	qr{(?:unsigned\s+)?short},
	qr{(?:unsigned\s+)?int},
	qr{(?:unsigned\s+)?long},
	qr{(?:unsigned\s+)?long\s+int},
	qr{(?:unsigned\s+)?long\s+long},
	qr{(?:unsigned\s+)?long\s+long\s+int},
155
156
157
158
159
160
161
162
163
164
165
166
	qr{unsigned},
	qr{float},
	qr{double},
	qr{bool},
	qr{(?:__)?(?:u|s|be|le)(?:8|16|32|64)},
	qr{struct\s+$Ident},
	qr{union\s+$Ident},
	qr{enum\s+$Ident},
	qr{${Ident}_t},
	qr{${Ident}_handler},
	qr{${Ident}_handler_fn},
);
167
168
169
our @modifierList = (
	qr{fastcall},
);
170
171

sub build_types {
172
173
	my $mods = "(?x:  \n" . join("|\n  ", @modifierList) . "\n)";
	my $all = "(?x:  \n" . join("|\n  ", @typeList) . "\n)";
174
	$Modifier	= qr{(?:$Attribute|$Sparse|$mods)};
175
	$NonptrType	= qr{
176
			(?:$Modifier\s+|const\s+)*
177
			(?:
178
179
				(?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)|
				(?:${all}\b)
180
			)
181
			(?:\s+$Modifier|\s+const)*
182
183
		  }x;
	$Type	= qr{
184
			$NonptrType
185
			(?:\s*\*+\s*const|\s*\*+|(?:\s*\[\s*\])+)?
186
			(?:\s+$Inline|\s+$Modifier)*
187
188
189
190
		  }x;
	$Declare	= qr{(?:$Storage\s+)?$Type};
}
build_types();
191
192
193

$chk_signoff = 0 if ($file);

194
195
my @dep_includes = ();
my @dep_functions = ();
196
197
198
199
my $removal = "Documentation/feature-removal-schedule.txt";
if ($tree && -f "$root/$removal") {
	open(REMOVE, "<$root/$removal") ||
				die "$P: $removal: open failed - $!\n";
200
	while (<REMOVE>) {
201
202
203
		if (/^Check:\s+(.*\S)/) {
			for my $entry (split(/[, ]+/, $1)) {
				if ($entry =~ m@include/(.*)@) {
204
205
					push(@dep_includes, $1);

206
207
208
				} elsif ($entry !~ m@/@) {
					push(@dep_functions, $entry);
				}
209
			}
210
211
212
213
		}
	}
}

214
my @rawlines = ();
215
216
my @lines = ();
my $vname;
217
218
219
220
221
222
223
for my $filename (@ARGV) {
	if ($file) {
		open(FILE, "diff -u /dev/null $filename|") ||
			die "$P: $filename: diff failed - $!\n";
	} else {
		open(FILE, "<$filename") ||
			die "$P: $filename: open failed - $!\n";
224
	}
225
226
227
228
229
	if ($filename eq '-') {
		$vname = 'Your patch';
	} else {
		$vname = $filename;
	}
230
231
232
233
234
	while (<FILE>) {
		chomp;
		push(@rawlines, $_);
	}
	close(FILE);
235
	if (!process($filename)) {
236
237
238
		$exit = 1;
	}
	@rawlines = ();
239
	@lines = ();
240
241
242
243
244
}

exit($exit);

sub top_of_kernel_tree {
245
246
247
248
249
250
251
252
253
254
255
256
	my ($root) = @_;

	my @tree_check = (
		"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
		"README", "Documentation", "arch", "include", "drivers",
		"fs", "init", "ipc", "kernel", "lib", "scripts",
	);

	foreach my $check (@tree_check) {
		if (! -e $root . '/' . $check) {
			return 0;
		}
257
	}
258
	return 1;
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
}

sub expand_tabs {
	my ($str) = @_;

	my $res = '';
	my $n = 0;
	for my $c (split(//, $str)) {
		if ($c eq "\t") {
			$res .= ' ';
			$n++;
			for (; ($n % 8) != 0; $n++) {
				$res .= ' ';
			}
			next;
		}
		$res .= $c;
		$n++;
	}

	return $res;
}
281
sub copy_spacing {
282
	(my $res = shift) =~ tr/\t/ /c;
283
284
	return $res;
}
285

286
287
288
289
290
291
292
293
294
295
296
297
298
sub line_stats {
	my ($line) = @_;

	# Drop the diff line leader and expand tabs
	$line =~ s/^.//;
	$line = expand_tabs($line);

	# Pick the indent from the front of the line.
	my ($white) = ($line =~ /^(\s*)/);

	return (length($line), length($white));
}

299
300
301
302
303
304
305
306
307
308
309
my $sanitise_quote = '';

sub sanitise_line_reset {
	my ($in_comment) = @_;

	if ($in_comment) {
		$sanitise_quote = '*/';
	} else {
		$sanitise_quote = '';
	}
}
310
311
312
313
314
315
sub sanitise_line {
	my ($line) = @_;

	my $res = '';
	my $l = '';

316
	my $qlen = 0;
317
318
	my $off = 0;
	my $c;
319

320
321
322
323
324
325
326
327
328
329
330
331
332
333
	# Always copy over the diff marker.
	$res = substr($line, 0, 1);

	for ($off = 1; $off < length($line); $off++) {
		$c = substr($line, $off, 1);

		# Comments we are wacking completly including the begin
		# and end, all to $;.
		if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
			$sanitise_quote = '*/';

			substr($res, $off, 2, "$;$;");
			$off++;
			next;
334
		}
335
		if (substr($line, $off, 2) eq '*/') {
336
337
338
339
			$sanitise_quote = '';
			substr($res, $off, 2, "$;$;");
			$off++;
			next;
340
		}
341
342
343
344
345
346
347

		# A \ in a string means ignore the next character.
		if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
		    $c eq "\\") {
			substr($res, $off, 2, 'XX');
			$off++;
			next;
348
		}
349
350
351
352
		# Regular quotes.
		if ($c eq "'" || $c eq '"') {
			if ($sanitise_quote eq '') {
				$sanitise_quote = $c;
353

354
355
356
357
358
359
				substr($res, $off, 1, $c);
				next;
			} elsif ($sanitise_quote eq $c) {
				$sanitise_quote = '';
			}
		}
360

361
362
363
364
365
366
367
368
		#print "SQ:$sanitise_quote\n";
		if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
			substr($res, $off, 1, $;);
		} elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
			substr($res, $off, 1, 'X');
		} else {
			substr($res, $off, 1, $c);
		}
369
370
371
	}

	# The pathname on a #include may be surrounded by '<' and '>'.
372
	if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
373
374
375
376
		my $clean = 'X' x length($1);
		$res =~ s@\<.*\>@<$clean>@;

	# The whole of a #error is a string.
377
	} elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
378
		my $clean = 'X' x length($1);
379
		$res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
380
381
	}

382
383
384
	return $res;
}

385
386
387
388
389
390
sub ctx_statement_block {
	my ($linenr, $remain, $off) = @_;
	my $line = $linenr - 1;
	my $blk = '';
	my $soff = $off;
	my $coff = $off - 1;
391
	my $coff_set = 0;
392

393
394
	my $loff = 0;

395
396
	my $type = '';
	my $level = 0;
397
	my $p;
398
399
	my $c;
	my $len = 0;
400
401

	my $remainder;
402
	while (1) {
403
		#warn "CSB: blk<$blk> remain<$remain>\n";
404
405
406
407
		# If we are about to drop off the end, pull in more
		# context.
		if ($off >= $len) {
			for (; $remain > 0; $line++) {
408
				next if ($lines[$line] =~ /^-/);
409
				$remain--;
410
				$loff = $len;
411
				$blk .= $lines[$line] . "\n";
412
413
414
415
416
417
				$len = length($blk);
				$line++;
				last;
			}
			# Bail if there is no further context.
			#warn "CSB: blk<$blk> off<$off> len<$len>\n";
418
			if ($off >= $len) {
419
420
421
				last;
			}
		}
422
		$p = $c;
423
		$c = substr($blk, $off, 1);
424
		$remainder = substr($blk, $off);
425

426
		#warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
427
428
429
430
431
432
		# Statement ends at the ';' or a close '}' at the
		# outermost level.
		if ($level == 0 && $c eq ';') {
			last;
		}

433
		# An else is really a conditional as long as its not else if
434
435
436
437
438
439
440
441
		if ($level == 0 && $coff_set == 0 &&
				(!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
				$remainder =~ /^(else)(?:\s|{)/ &&
				$remainder !~ /^else\s+if\b/) {
			$coff = $off + length($1) - 1;
			$coff_set = 1;
			#warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
			#warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
442
443
		}

444
445
446
447
448
449
450
451
452
453
		if (($type eq '' || $type eq '(') && $c eq '(') {
			$level++;
			$type = '(';
		}
		if ($type eq '(' && $c eq ')') {
			$level--;
			$type = ($level != 0)? '(' : '';

			if ($level == 0 && $coff < $soff) {
				$coff = $off;
454
455
				$coff_set = 1;
				#warn "CSB: mark coff<$coff>\n";
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
			}
		}
		if (($type eq '' || $type eq '{') && $c eq '{') {
			$level++;
			$type = '{';
		}
		if ($type eq '{' && $c eq '}') {
			$level--;
			$type = ($level != 0)? '{' : '';

			if ($level == 0) {
				last;
			}
		}
		$off++;
	}
472
	# We are truly at the end, so shuffle to the next line.
473
	if ($off == $len) {
474
		$loff = $len + 1;
475
476
477
		$line++;
		$remain--;
	}
478
479
480
481
482
483
484

	my $statement = substr($blk, $soff, $off - $soff + 1);
	my $condition = substr($blk, $soff, $coff - $soff + 1);

	#warn "STATEMENT<$statement>\n";
	#warn "CONDITION<$condition>\n";

485
	#print "coff<$coff> soff<$off> loff<$loff>\n";
486
487
488
489
490

	return ($statement, $condition,
			$line, $remain + 1, $off - $loff + 1, $level);
}

491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
sub statement_lines {
	my ($stmt) = @_;

	# Strip the diff line prefixes and rip blank lines at start and end.
	$stmt =~ s/(^|\n)./$1/g;
	$stmt =~ s/^\s*//;
	$stmt =~ s/\s*$//;

	my @stmt_lines = ($stmt =~ /\n/g);

	return $#stmt_lines + 2;
}

sub statement_rawlines {
	my ($stmt) = @_;

	my @stmt_lines = ($stmt =~ /\n/g);

	return $#stmt_lines + 2;
}

sub statement_block_size {
	my ($stmt) = @_;

	$stmt =~ s/(^|\n)./$1/g;
	$stmt =~ s/^\s*{//;
	$stmt =~ s/}\s*$//;
	$stmt =~ s/^\s*//;
	$stmt =~ s/\s*$//;

	my @stmt_lines = ($stmt =~ /\n/g);
	my @stmt_statements = ($stmt =~ /;/g);

	my $stmt_lines = $#stmt_lines + 2;
	my $stmt_statements = $#stmt_statements + 1;

	if ($stmt_lines > $stmt_statements) {
		return $stmt_lines;
	} else {
		return $stmt_statements;
	}
}

534
535
536
537
538
539
sub ctx_statement_full {
	my ($linenr, $remain, $off) = @_;
	my ($statement, $condition, $level);

	my (@chunks);

540
	# Grab the first conditional/block pair.
541
542
	($statement, $condition, $linenr, $remain, $off, $level) =
				ctx_statement_block($linenr, $remain, $off);
543
	#print "F: c<$condition> s<$statement> remain<$remain>\n";
544
545
546
547
548
549
550
	push(@chunks, [ $condition, $statement ]);
	if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
		return ($level, $linenr, @chunks);
	}

	# Pull in the following conditional/block pairs and see if they
	# could continue the statement.
551
552
553
	for (;;) {
		($statement, $condition, $linenr, $remain, $off, $level) =
				ctx_statement_block($linenr, $remain, $off);
554
		#print "C: c<$condition> s<$statement> remain<$remain>\n";
555
		last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
556
557
		#print "C: push\n";
		push(@chunks, [ $condition, $statement ]);
558
559
560
	}

	return ($level, $linenr, @chunks);
561
562
}

563
sub ctx_block_get {
564
	my ($linenr, $remain, $outer, $open, $close, $off) = @_;
565
566
567
568
569
570
571
	my $line;
	my $start = $linenr - 1;
	my $blk = '';
	my @o;
	my @c;
	my @res = ();

572
	my $level = 0;
573
574
575
576
577
	for ($line = $start; $remain > 0; $line++) {
		next if ($rawlines[$line] =~ /^-/);
		$remain--;

		$blk .= $rawlines[$line];
578
579
580
581
582
583
		foreach my $c (split(//, $rawlines[$line])) {
			##print "C<$c>L<$level><$open$close>O<$off>\n";
			if ($off > 0) {
				$off--;
				next;
			}
584

585
586
587
588
589
590
591
			if ($c eq $close && $level > 0) {
				$level--;
				last if ($level == 0);
			} elsif ($c eq $open) {
				$level++;
			}
		}
592

593
		if (!$outer || $level <= 1) {
594
			push(@res, $rawlines[$line]);
595
596
		}

597
		last if ($level == 0);
598
599
	}

600
	return ($level, @res);
601
602
603
604
}
sub ctx_block_outer {
	my ($linenr, $remain) = @_;

605
606
	my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
	return @r;
607
608
609
610
}
sub ctx_block {
	my ($linenr, $remain) = @_;

611
612
	my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
	return @r;
613
614
}
sub ctx_statement {
615
616
617
618
619
620
	my ($linenr, $remain, $off) = @_;

	my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
	return @r;
}
sub ctx_block_level {
621
622
	my ($linenr, $remain) = @_;

623
	return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
624
}
625
626
627
628
629
sub ctx_statement_level {
	my ($linenr, $remain, $off) = @_;

	return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
}
630
631
632
633
634

sub ctx_locate_comment {
	my ($first_line, $end_line) = @_;

	# Catch a comment on the end of the line itself.
635
	my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
636
637
638
639
640
641
642
	return $current_comment if (defined $current_comment);

	# Look through the context and try and figure out if there is a
	# comment.
	my $in_comment = 0;
	$current_comment = '';
	for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
643
644
		my $line = $rawlines[$linenr - 1];
		#warn "           $line\n";
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
		if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
			$in_comment = 1;
		}
		if ($line =~ m@/\*@) {
			$in_comment = 1;
		}
		if (!$in_comment && $current_comment ne '') {
			$current_comment = '';
		}
		$current_comment .= $line . "\n" if ($in_comment);
		if ($line =~ m@\*/@) {
			$in_comment = 0;
		}
	}

	chomp($current_comment);
	return($current_comment);
}
sub ctx_has_comment {
	my ($first_line, $end_line) = @_;
	my $cmt = ctx_locate_comment($first_line, $end_line);

667
	##print "LINE: $rawlines[$end_line - 1 ]\n";
668
669
670
671
672
	##print "CMMT: $cmt\n";

	return ($cmt ne '');
}

673
674
675
sub cat_vet {
	my ($vet) = @_;
	my ($res, $coded);
676

677
678
679
680
681
682
	$res = '';
	while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
		$res .= $1;
		if ($2 ne '') {
			$coded = sprintf("^%c", unpack('C', $2) + 64);
			$res .= $coded;
683
684
		}
	}
685
	$res =~ s/$/\$/;
686

687
	return $res;
688
689
}

690
my $av_preprocessor = 0;
691
my $av_pending;
692
my @av_paren_type;
693
my $av_pend_colon;
694
695
696

sub annotate_reset {
	$av_preprocessor = 0;
697
698
	$av_pending = '_';
	@av_paren_type = ('E');
699
	$av_pend_colon = 'O';
700
701
}

702
703
sub annotate_values {
	my ($stream, $type) = @_;
704

705
	my $res;
706
	my $var = '_' x length($stream);
707
708
	my $cur = $stream;

709
	print "$stream\n" if ($dbg_values > 1);
710
711

	while (length($cur)) {
712
		@av_paren_type = ('E') if ($#av_paren_type < 0);
713
		print " <" . join('', @av_paren_type) .
714
				"> <$type> <$av_pending>" if ($dbg_values > 1);
715
		if ($cur =~ /^(\s+)/o) {
716
717
			print "WS($1)\n" if ($dbg_values > 1);
			if ($1 =~ /\n/ && $av_preprocessor) {
718
				$type = pop(@av_paren_type);
719
				$av_preprocessor = 0;
720
721
			}

722
		} elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\()/) {
723
			print "DECLARE($1)\n" if ($dbg_values > 1);
724
725
			$type = 'T';

726
727
728
729
		} elsif ($cur =~ /^($Modifier)\s*/) {
			print "MODIFIER($1)\n" if ($dbg_values > 1);
			$type = 'T';

730
		} elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
731
			print "DEFINE($1,$2)\n" if ($dbg_values > 1);
732
			$av_preprocessor = 1;
733
734
735
736
737
738
			push(@av_paren_type, $type);
			if ($2 ne '') {
				$av_pending = 'N';
			}
			$type = 'E';

739
		} elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
740
741
742
			print "UNDEF($1)\n" if ($dbg_values > 1);
			$av_preprocessor = 1;
			push(@av_paren_type, $type);
743

744
		} elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
745
			print "PRE_START($1)\n" if ($dbg_values > 1);
746
			$av_preprocessor = 1;
747
748
749

			push(@av_paren_type, $type);
			push(@av_paren_type, $type);
750
			$type = 'E';
751

752
		} elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
753
754
755
756
757
			print "PRE_RESTART($1)\n" if ($dbg_values > 1);
			$av_preprocessor = 1;

			push(@av_paren_type, $av_paren_type[$#av_paren_type]);

758
			$type = 'E';
759

760
		} elsif ($cur =~ /^(\#\s*(?:endif))/o) {
761
762
763
764
765
766
767
768
			print "PRE_END($1)\n" if ($dbg_values > 1);

			$av_preprocessor = 1;

			# Assume all arms of the conditional end as this
			# one does, and continue as if the #endif was not here.
			pop(@av_paren_type);
			push(@av_paren_type, $type);
769
			$type = 'E';
770
771

		} elsif ($cur =~ /^(\\\n)/o) {
772
			print "PRECONT($1)\n" if ($dbg_values > 1);
773

774
775
776
777
778
		} elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
			print "ATTR($1)\n" if ($dbg_values > 1);
			$av_pending = $type;
			$type = 'N';

779
		} elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
780
			print "SIZEOF($1)\n" if ($dbg_values > 1);
781
			if (defined $2) {
782
				$av_pending = 'V';
783
784
785
			}
			$type = 'N';

786
		} elsif ($cur =~ /^(if|while|for)\b/o) {
787
			print "COND($1)\n" if ($dbg_values > 1);
788
			$av_pending = 'E';
789
790
			$type = 'N';

791
792
793
794
795
		} elsif ($cur =~/^(case)/o) {
			print "CASE($1)\n" if ($dbg_values > 1);
			$av_pend_colon = 'C';
			$type = 'N';

796
		} elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
797
			print "KEYWORD($1)\n" if ($dbg_values > 1);
798
799
800
			$type = 'N';

		} elsif ($cur =~ /^(\()/o) {
801
			print "PAREN('$1')\n" if ($dbg_values > 1);
802
803
			push(@av_paren_type, $av_pending);
			$av_pending = '_';
804
805
806
			$type = 'N';

		} elsif ($cur =~ /^(\))/o) {
807
808
809
			my $new_type = pop(@av_paren_type);
			if ($new_type ne '_') {
				$type = $new_type;
810
811
				print "PAREN('$1') -> $type\n"
							if ($dbg_values > 1);
812
			} else {
813
				print "PAREN('$1')\n" if ($dbg_values > 1);
814
815
			}

816
		} elsif ($cur =~ /^($Ident)\s*\(/o) {
817
			print "FUNC($1)\n" if ($dbg_values > 1);
818
			$type = 'V';
819
			$av_pending = 'V';
820

821
822
823
824
825
826
827
828
829
		} elsif ($cur =~ /^($Ident\s*):/) {
			if ($type eq 'E') {
				$av_pend_colon = 'L';
			} elsif ($type eq 'T') {
				$av_pend_colon = 'B';
			}
			print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
			$type = 'V';

830
		} elsif ($cur =~ /^($Ident|$Constant)/o) {
831
			print "IDENT($1)\n" if ($dbg_values > 1);
832
833
834
			$type = 'V';

		} elsif ($cur =~ /^($Assignment)/o) {
835
			print "ASSIGN($1)\n" if ($dbg_values > 1);
836
837
			$type = 'N';

838
		} elsif ($cur =~/^(;|{|})/) {
839
			print "END($1)\n" if ($dbg_values > 1);
840
			$type = 'E';
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
			$av_pend_colon = 'O';

		} elsif ($cur =~ /^(\?)/o) {
			print "QUESTION($1)\n" if ($dbg_values > 1);
			$type = 'N';

		} elsif ($cur =~ /^(:)/o) {
			print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1);

			substr($var, length($res), 1, $av_pend_colon);
			if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
				$type = 'E';
			} else {
				$type = 'N';
			}
			$av_pend_colon = 'O';
857

858
		} elsif ($cur =~ /^(;|\[)/o) {
859
			print "CLOSE($1)\n" if ($dbg_values > 1);
860
861
			$type = 'N';

862
		} elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
863
864
865
866
867
868
869
870
871
872
873
874
			my $variant;

			print "OPV($1)\n" if ($dbg_values > 1);
			if ($type eq 'V') {
				$variant = 'B';
			} else {
				$variant = 'U';
			}

			substr($var, length($res), 1, $variant);
			$type = 'N';

875
		} elsif ($cur =~ /^($Operators)/o) {
876
			print "OP($1)\n" if ($dbg_values > 1);
877
878
879
880
881
			if ($1 ne '++' && $1 ne '--') {
				$type = 'N';
			}

		} elsif ($cur =~ /(^.)/o) {
882
			print "C($1)\n" if ($dbg_values > 1);
883
884
885
886
887
		}
		if (defined $1) {
			$cur = substr($cur, length($1));
			$res .= $type x length($1);
		}
888
	}
889

890
	return ($res, $var);
891
892
}

893
sub possible {
894
	my ($possible, $line) = @_;
895

896
	print "CHECK<$possible> ($line)\n" if ($dbg_possible > 1);
897
	if ($possible !~ /^(?:$Modifier|$Storage|$Type|DEFINE_\S+)$/ &&
898
899
	    $possible ne 'goto' && $possible ne 'return' &&
	    $possible ne 'case' && $possible ne 'else' &&
900
	    $possible ne 'asm' && $possible ne '__asm__' &&
901
902
903
904
905
906
907
908
	    $possible !~ /^(typedef|struct|enum)\b/) {
		# Check for modifiers.
		$possible =~ s/\s*$Storage\s*//g;
		$possible =~ s/\s*$Sparse\s*//g;
		if ($possible =~ /^\s*$/) {

		} elsif ($possible =~ /\s/) {
			$possible =~ s/\s*$Type\s*//g;
909
910
911
912
			for my $modifier (split(' ', $possible)) {
				warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);
				push(@modifierList, $modifier);
			}
913
914
915
916
917

		} else {
			warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
			push(@typeList, $possible);
		}
918
919
920
921
		build_types();
	}
}

922
923
my $prefix = '';

924
sub report {
925
926
927
	if (defined $tst_only && $_[0] !~ /\Q$tst_only\E/) {
		return 0;
	}
928
929
930
931
	my $line = $prefix . $_[0];

	$line = (split('\n', $line))[0] . "\n" if ($terse);

932
	push(our @report, $line);
933
934

	return 1;
935
936
}
sub report_dump {
937
	our @report;
938
}
939
sub ERROR {
940
941
942
943
	if (report("ERROR: $_[0]\n")) {
		our $clean = 0;
		our $cnt_error++;
	}
944
945
}
sub WARN {
946
947
948
949
	if (report("WARNING: $_[0]\n")) {
		our $clean = 0;
		our $cnt_warn++;
	}
950
951
}
sub CHK {
952
	if ($check && report("CHECK: $_[0]\n")) {
953
954
955
		our $clean = 0;
		our $cnt_chk++;
	}
956
957
}

958
959
960
961
962
sub process {
	my $filename = shift;

	my $linenr=0;
	my $prevline="";
963
	my $prevrawline="";
964
	my $stashline="";
965
	my $stashrawline="";
966

967
	my $length;
968
969
970
971
	my $indent;
	my $previndent=0;
	my $stashindent=0;

972
	our $clean = 1;
973
974
975
	my $signoff = 0;
	my $is_patch = 0;

976
	our @report = ();
977
978
979
980
981
	our $cnt_lines = 0;
	our $cnt_error = 0;
	our $cnt_warn = 0;
	our $cnt_chk = 0;

982
983
984
985
986
987
	# Trace the real file/line as we go.
	my $realfile = '';
	my $realline = 0;
	my $realcnt = 0;
	my $here = '';
	my $in_comment = 0;
988
	my $comment_edge = 0;
989
990
	my $first_line = 0;

991
992
993
	my $prev_values = 'E';

	# suppression flags
994
	my %suppress_ifbraces;
995

996
	# Pre-scan the patch sanitizing the lines.
997
	# Pre-scan the patch looking for any __setup documentation.
998
	#
999
1000
	my @setup_docs = ();
	my $setup_docs = 0;
1001
1002

	sanitise_line_reset();
1003
1004
	my $line;
	foreach my $rawline (@rawlines) {
1005
1006
		$linenr++;
		$line = $rawline;
1007

1008
		if ($rawline=~/^\+\+\+\s+(\S+)/) {
1009
1010
1011
1012
			$setup_docs = 0;
			if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
				$setup_docs = 1;
			}
1013
1014
1015
1016
1017
1018
1019
1020
1021
			#next;
		}
		if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
			$realline=$1-1;
			if (defined $2) {
				$realcnt=$3+1;
			} else {
				$realcnt=1+1;
			}
1022
			$in_comment = 0;
1023
1024
1025
1026
1027
1028

			# Guestimate if this is a continuing comment.  Run
			# the context looking for a comment "edge".  If this
			# edge is a close comment then we must be in a comment
			# at context start.
			my $edge;
1029
			for (my $ln = $linenr + 1; $ln < ($linenr + $realcnt); $ln++) {
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
				next if ($line =~ /^-/);
				($edge) = ($rawlines[$ln - 1] =~ m@(/\*|\*/)@);
				last if (defined $edge);
			}
			if (defined $edge && $edge eq '*/') {
				$in_comment = 1;
			}

			# Guestimate if this is a continuing comment.  If this
			# is the start of a diff block and this line starts
			# ' *' then it is very likely a comment.
			if (!defined $edge &&
			    $rawlines[$linenr] =~ m@^.\s* \*(?:\s|$)@)
			{
				$in_comment = 1;
			}

			##print "COMMENT:$in_comment edge<$edge> $rawline\n";
			sanitise_line_reset($in_comment);

1050
		} elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
1051
			# Standardise the strings and chars within the input to
1052
			# simplify matching -- only bother with positive lines.
1053
			$line = sanitise_line($rawline);
1054
		}
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
		push(@lines, $line);

		if ($realcnt > 1) {
			$realcnt-- if ($line =~ /^(?:\+| |$)/);
		} else {
			$realcnt = 0;
		}

		#print "==>$rawline\n";
		#print "-->$line\n";
1065
1066
1067
1068
1069
1070

		if ($setup_docs && $line =~ /^\+/) {
			push(@setup_docs, $line);
		}
	}

1071
1072
	$prefix = '';

1073
1074
	$realcnt = 0;
	$linenr = 0;
1075
1076
1077
	foreach my $line (@lines) {
		$linenr++;

1078
		my $rawline = $rawlines[$linenr - 1];
1079

1080
#extract the line range in the file after the patch is applied
1081
		if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1082
			$is_patch = 1;
1083
			$first_line = $linenr + 1;
1084
1085
1086
1087
1088
1089
			$realline=$1-1;
			if (defined $2) {
				$realcnt=$3+1;
			} else {
				$realcnt=1+1;
			}
1090
			annotate_reset();
1091
1092
			$prev_values = 'E';

1093
			%suppress_ifbraces = ();
1094
1095
			next;

1096
1097
1098
# track the line number as we move through the hunk, note that
# new versions of GNU diff omit the leading space on completely
# blank context lines so we need to count that too.
1099
		} elsif ($line =~ /^( |\+|$)/) {
1100
			$realline++;
1101
			$realcnt-- if ($realcnt != 0);
1102

1103
			# Measure the line length and indent.
1104
			($length, $indent) = line_stats($rawline);
1105
1106
1107
1108

			# Track the previous line.
			($prevline, $stashline) = ($stashline, $line);
			($previndent, $stashindent) = ($stashindent, $indent);
1109
1110
			($prevrawline, $stashrawline) = ($stashrawline, $rawline);

1111
			#warn "line<$line>\n";
1112

1113
1114
		} elsif ($realcnt == 1) {
			$realcnt--;
1115
1116
1117
		}

#make up the handle for any error we report on this line
1118
1119
1120
		$prefix = "$filename:$realline: " if ($emacs && $file);
		$prefix = "$filename:$linenr: " if ($emacs && !$file);

1121
1122
		$here = "#$linenr: " if (!$file);
		$here = "#$realline: " if ($file);
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134

		# extract the filename as it passes
		if ($line=~/^\+\+\+\s+(\S+)/) {
			$realfile = $1;
			$realfile =~ s@^[^/]*/@@;

			if ($realfile =~ m@include/asm/@) {
				ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
			}
			next;
		}

1135
		$here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
1136

1137
1138
1139
		my $hereline = "$here\n$rawline\n";
		my $herecurr = "$here\n$rawline\n";
		my $hereprev = "$here\n$prevrawline\n$rawline\n";
1140

1141
1142
		$cnt_lines++ if ($realcnt != 0);

1143
#check the patch for a signoff:
1144
		if ($line =~ /^\s*signed-off-by:/i) {
1145
1146
			# This is a signoff, if ugly, so do not double report.
			$signoff++;
1147
			if (!($line =~ /^\s*Signed-off-by:/)) {
1148
1149
				WARN("Signed-off-by: is the preferred form\n" .
					$herecurr);
1150
1151
			}
			if ($line =~ /^\s*signed-off-by:\S/i) {
1152
				WARN("space required after Signed-off-by:\n" .
1153
					$herecurr);
1154
1155
1156
			}
		}

1157
# Check for wrappage within a valid hunk of the file
1158
		if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {