checkpatch.pl 37.7 KB
Newer Older
1
2
#!/usr/bin/perl -w
# (c) 2001, Dave Jones. <davej@codemonkey.org.uk> (the file handling bit)
3
# (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4
5
6
7
8
9
# (c) 2007, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite, etc)
# Licensed under the terms of the GNU GPL License version 2

use strict;

my $P = $0;
10
$P =~ s@.*/@@g;
11

12
my $V = '0.11';
13
14
15
16
17
18
19

use Getopt::Long qw(:config no_auto_abbrev);

my $quiet = 0;
my $tree = 1;
my $chk_signoff = 1;
my $chk_patch = 1;
20
my $tst_type = 0;
21
22
23
24
my $emacs = 0;
my $file = 0;
my $check = 0;
my $root;
25
GetOptions(
26
	'q|quiet+'	=> \$quiet,
27
28
29
	'tree!'		=> \$tree,
	'signoff!'	=> \$chk_signoff,
	'patch!'	=> \$chk_patch,
30
	'test-type!'	=> \$tst_type,
31
32
33
34
35
	'emacs!'	=> \$emacs,
	'file!'		=> \$file,
	'subjective!'	=> \$check,
	'strict!'	=> \$check,
	'root=s'	=> \$root,
36
37
38
39
40
) or exit;

my $exit = 0;

if ($#ARGV < 0) {
41
	print "usage: $P [options] patchfile\n";
42
43
44
	print "version: $V\n";
	print "options: -q           => quiet\n";
	print "         --no-tree    => run without a kernel tree\n";
45
46
47
48
	print "         --emacs      => emacs compile window format\n";
	print "         --file       => check a source file\n";
	print "         --strict     => enable more subjective tests\n";
	print "         --root       => path to the kernel tree root\n";
49
50
51
	exit(1);
}

52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
if ($tree) {
	if (defined $root) {
		if (!top_of_kernel_tree($root)) {
			die "$P: $root: --root does not point at a valid tree\n";
		}
	} else {
		if (top_of_kernel_tree('.')) {
			$root = '.';
		} elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
						top_of_kernel_tree($1)) {
			$root = $1;
		}
	}

	if (!defined $root) {
		print "Must be run from the top-level dir. of a kernel tree\n";
		exit(2);
	}
70
71
}

72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
my $emitted_corrupt = 0;

our $Ident       = qr{[A-Za-z_][A-Za-z\d_]*};
our $Storage	= qr{extern|static|asmlinkage};
our $Sparse	= qr{
			__user|
			__kernel|
			__force|
			__iomem|
			__must_check|
			__init_refok|
			__kprobes|
			fastcall
		}x;
our $Attribute	= qr{
			const|
			__read_mostly|
			__kprobes|
			__(?:mem|cpu|dev|)(?:initdata|init)
		  }x;
our $Inline	= qr{inline|__always_inline|noinline};
our $NonptrType	= qr{
			\b
			(?:const\s+)?
			(?:unsigned\s+)?
			(?:
				void|
				char|
				short|
				int|
				long|
				unsigned|
				float|
				double|
				bool|
				long\s+int|
				long\s+long|
				long\s+long\s+int|
				(?:__)?(?:u|s|be|le)(?:8|16|32|64)|
				struct\s+$Ident|
				union\s+$Ident|
				enum\s+$Ident|
				${Ident}_t|
				${Ident}_handler|
				${Ident}_handler_fn
			)
			(?:\s+$Sparse)*
			\b
		  }x;

our $Type	= qr{
			\b$NonptrType\b
			(?:\s*\*+\s*const|\s*\*+|(?:\s*\[\s*\])+)?
			(?:\s+$Sparse|\s+$Attribute)*
		  }x;
our $Declare	= qr{(?:$Storage\s+)?$Type};
our $Member	= qr{->$Ident|\.$Ident|\[[^]]*\]};
our $Lval	= qr{$Ident(?:$Member)*};

our $Constant	= qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*};
our $Assignment	= qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
our $Operators	= qr{
			<=|>=|==|!=|
			=>|->|<<|>>|<|>|!|~|
			&&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/
		  }x;

our $Bare = '';

$chk_signoff = 0 if ($file);

143
144
my @dep_includes = ();
my @dep_functions = ();
145
146
147
148
my $removal = "Documentation/feature-removal-schedule.txt";
if ($tree && -f "$root/$removal") {
	open(REMOVE, "<$root/$removal") ||
				die "$P: $removal: open failed - $!\n";
149
	while (<REMOVE>) {
150
151
152
		if (/^Check:\s+(.*\S)/) {
			for my $entry (split(/[, ]+/, $1)) {
				if ($entry =~ m@include/(.*)@) {
153
154
					push(@dep_includes, $1);

155
156
157
				} elsif ($entry !~ m@/@) {
					push(@dep_functions, $entry);
				}
158
			}
159
160
161
162
		}
	}
}

163
my @rawlines = ();
164
165
166
167
168
169
170
for my $filename (@ARGV) {
	if ($file) {
		open(FILE, "diff -u /dev/null $filename|") ||
			die "$P: $filename: diff failed - $!\n";
	} else {
		open(FILE, "<$filename") ||
			die "$P: $filename: open failed - $!\n";
171
	}
172
173
174
175
176
177
178
179
180
	while (<FILE>) {
		chomp;
		push(@rawlines, $_);
	}
	close(FILE);
	if (!process($filename, @rawlines)) {
		$exit = 1;
	}
	@rawlines = ();
181
182
183
184
185
}

exit($exit);

sub top_of_kernel_tree {
186
187
188
189
190
191
192
193
194
195
196
197
	my ($root) = @_;

	my @tree_check = (
		"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
		"README", "Documentation", "arch", "include", "drivers",
		"fs", "init", "ipc", "kernel", "lib", "scripts",
	);

	foreach my $check (@tree_check) {
		if (! -e $root . '/' . $check) {
			return 0;
		}
198
	}
199
	return 1;
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
}

sub expand_tabs {
	my ($str) = @_;

	my $res = '';
	my $n = 0;
	for my $c (split(//, $str)) {
		if ($c eq "\t") {
			$res .= ' ';
			$n++;
			for (; ($n % 8) != 0; $n++) {
				$res .= ' ';
			}
			next;
		}
		$res .= $c;
		$n++;
	}

	return $res;
}
222
223
224
225
226
227
228
229
230
231
232
233
234
235
sub copy_spacing {
	my ($str) = @_;

	my $res = '';
	for my $c (split(//, $str)) {
		if ($c eq "\t") {
			$res .= $c;
		} else {
			$res .= ' ';
		}
	}

	return $res;
}
236

237
238
239
240
241
242
243
244
245
246
247
248
249
sub line_stats {
	my ($line) = @_;

	# Drop the diff line leader and expand tabs
	$line =~ s/^.//;
	$line = expand_tabs($line);

	# Pick the indent from the front of the line.
	my ($white) = ($line =~ /^(\s*)/);

	return (length($line), length($white));
}

250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
sub sanitise_line {
	my ($line) = @_;

	my $res = '';
	my $l = '';

	my $quote = '';

	foreach my $c (split(//, $line)) {
		if ($l ne "\\" && ($c eq "'" || $c eq '"')) {
			if ($quote eq '') {
				$quote = $c;
				$res .= $c;
				$l = $c;
				next;
			} elsif ($quote eq $c) {
				$quote = '';
			}
		}
		if ($quote && $c ne "\t") {
			$res .= "X";
		} else {
			$res .= $c;
		}

		$l = $c;
	}

	return $res;
}

281
sub ctx_block_get {
282
	my ($linenr, $remain, $outer, $open, $close, $off) = @_;
283
284
285
286
287
288
289
	my $line;
	my $start = $linenr - 1;
	my $blk = '';
	my @o;
	my @c;
	my @res = ();

290
	my $level = 0;
291
292
293
294
295
	for ($line = $start; $remain > 0; $line++) {
		next if ($rawlines[$line] =~ /^-/);
		$remain--;

		$blk .= $rawlines[$line];
296
297
298
299
300
301
		foreach my $c (split(//, $rawlines[$line])) {
			##print "C<$c>L<$level><$open$close>O<$off>\n";
			if ($off > 0) {
				$off--;
				next;
			}
302

303
304
305
306
307
308
309
			if ($c eq $close && $level > 0) {
				$level--;
				last if ($level == 0);
			} elsif ($c eq $open) {
				$level++;
			}
		}
310

311
		if (!$outer || $level <= 1) {
312
			push(@res, $rawlines[$line]);
313
314
		}

315
		last if ($level == 0);
316
317
	}

318
	return ($level, @res);
319
320
321
322
}
sub ctx_block_outer {
	my ($linenr, $remain) = @_;

323
324
	my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
	return @r;
325
326
327
328
}
sub ctx_block {
	my ($linenr, $remain) = @_;

329
330
	my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
	return @r;
331
332
}
sub ctx_statement {
333
334
335
336
337
338
	my ($linenr, $remain, $off) = @_;

	my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
	return @r;
}
sub ctx_block_level {
339
340
	my ($linenr, $remain) = @_;

341
	return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
342
}
343
344
345
346
347
sub ctx_statement_level {
	my ($linenr, $remain, $off) = @_;

	return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
}
348
349
350
351
352

sub ctx_locate_comment {
	my ($first_line, $end_line) = @_;

	# Catch a comment on the end of the line itself.
353
	my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*$@);
354
355
356
357
358
359
360
	return $current_comment if (defined $current_comment);

	# Look through the context and try and figure out if there is a
	# comment.
	my $in_comment = 0;
	$current_comment = '';
	for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
361
362
		my $line = $rawlines[$linenr - 1];
		#warn "           $line\n";
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
		if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
			$in_comment = 1;
		}
		if ($line =~ m@/\*@) {
			$in_comment = 1;
		}
		if (!$in_comment && $current_comment ne '') {
			$current_comment = '';
		}
		$current_comment .= $line . "\n" if ($in_comment);
		if ($line =~ m@\*/@) {
			$in_comment = 0;
		}
	}

	chomp($current_comment);
	return($current_comment);
}
sub ctx_has_comment {
	my ($first_line, $end_line) = @_;
	my $cmt = ctx_locate_comment($first_line, $end_line);

385
	##print "LINE: $rawlines[$end_line - 1 ]\n";
386
387
388
389
390
	##print "CMMT: $cmt\n";

	return ($cmt ne '');
}

391
392
393
sub cat_vet {
	my ($vet) = @_;
	my ($res, $coded);
394

395
396
397
398
399
400
	$res = '';
	while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
		$res .= $1;
		if ($2 ne '') {
			$coded = sprintf("^%c", unpack('C', $2) + 64);
			$res .= $coded;
401
402
		}
	}
403
	$res =~ s/$/\$/;
404

405
	return $res;
406
407
}

408
409
sub annotate_values {
	my ($stream, $type) = @_;
410

411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
	my $res;
	my $cur = $stream;

	my $debug = 0;

	print "$stream\n" if ($debug);

	##my $type = 'N';
	my $pos = 0;
	my $preprocessor = 0;
	my $paren = 0;
	my @paren_type;

	# Include any user defined types we may have found as we went.
	my $type_match = "(?:$Type$Bare)";

	while (length($cur)) {
		print " <$type> " if ($debug);
		if ($cur =~ /^(\s+)/o) {
			print "WS($1)\n" if ($debug);
			if ($1 =~ /\n/ && $preprocessor) {
				$preprocessor = 0;
				$type = 'N';
			}

		} elsif ($cur =~ /^($type_match)/) {
			print "DECLARE($1)\n" if ($debug);
			$type = 'T';

		} elsif ($cur =~ /^(#\s*define\s*$Ident)(\(?)/o) {
			print "DEFINE($1)\n" if ($debug);
			$preprocessor = 1;
			$paren_type[$paren] = 'N';

		} elsif ($cur =~ /^(#\s*(?:ifdef|ifndef|if|else|endif))/o) {
			print "PRE($1)\n" if ($debug);
			$preprocessor = 1;
			$type = 'N';

		} elsif ($cur =~ /^(\\\n)/o) {
			print "PRECONT($1)\n" if ($debug);

		} elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
			print "SIZEOF($1)\n" if ($debug);
			if (defined $2) {
				$paren_type[$paren] = 'V';
			}
			$type = 'N';

		} elsif ($cur =~ /^(if|while|typeof)\b/o) {
			print "COND($1)\n" if ($debug);
			$paren_type[$paren] = 'N';
			$type = 'N';

		} elsif ($cur =~/^(return|case|else)/o) {
			print "KEYWORD($1)\n" if ($debug);
			$type = 'N';

		} elsif ($cur =~ /^(\()/o) {
			print "PAREN('$1')\n" if ($debug);
			$paren++;
			$type = 'N';

		} elsif ($cur =~ /^(\))/o) {
			$paren-- if ($paren > 0);
			if (defined $paren_type[$paren]) {
				$type = $paren_type[$paren];
				undef $paren_type[$paren];
				print "PAREN('$1') -> $type\n" if ($debug);
			} else {
				print "PAREN('$1')\n" if ($debug);
			}

		} elsif ($cur =~ /^($Ident)\(/o) {
			print "FUNC($1)\n" if ($debug);
			$paren_type[$paren] = 'V';

		} elsif ($cur =~ /^($Ident|$Constant)/o) {
			print "IDENT($1)\n" if ($debug);
			$type = 'V';

		} elsif ($cur =~ /^($Assignment)/o) {
			print "ASSIGN($1)\n" if ($debug);
			$type = 'N';

		} elsif ($cur =~ /^(;|{|}|\?|:|\[)/o) {
			print "END($1)\n" if ($debug);
			$type = 'N';

		} elsif ($cur =~ /^($Operators)/o) {
			print "OP($1)\n" if ($debug);
			if ($1 ne '++' && $1 ne '--') {
				$type = 'N';
			}

		} elsif ($cur =~ /(^.)/o) {
			print "C($1)\n" if ($debug);
		}
		if (defined $1) {
			$cur = substr($cur, length($1));
			$res .= $type x length($1);
		}
513
	}
514

515
	return $res;
516
517
}

518
519
my $prefix = '';

520
521
my @report = ();
sub report {
522
	push(@report, $prefix . $_[0]);
523
524
525
526
}
sub report_dump {
	@report;
}
527
sub ERROR {
528
	report("ERROR: $_[0]\n");
529
	our $clean = 0;
530
	our $cnt_error++;
531
532
}
sub WARN {
533
	report("WARNING: $_[0]\n");
534
	our $clean = 0;
535
	our $cnt_warn++;
536
537
}
sub CHK {
538
539
540
541
542
	if ($check) {
		report("CHECK: $_[0]\n");
		our $clean = 0;
		our $cnt_chk++;
	}
543
544
}

545
546
547
548
549
550
551
552
sub process {
	my $filename = shift;
	my @lines = @_;

	my $linenr=0;
	my $prevline="";
	my $stashline="";

553
	my $length;
554
555
556
557
	my $indent;
	my $previndent=0;
	my $stashindent=0;

558
	our $clean = 1;
559
560
561
	my $signoff = 0;
	my $is_patch = 0;

562
563
564
565
566
	our $cnt_lines = 0;
	our $cnt_error = 0;
	our $cnt_warn = 0;
	our $cnt_chk = 0;

567
568
569
570
571
572
573
574
	# Trace the real file/line as we go.
	my $realfile = '';
	my $realline = 0;
	my $realcnt = 0;
	my $here = '';
	my $in_comment = 0;
	my $first_line = 0;

575
	my $prev_values = 'N';
576

577
578
579
	# Possible bare types.
	my @bare = ();

580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
	# Pre-scan the patch looking for any __setup documentation.
	my @setup_docs = ();
	my $setup_docs = 0;
	foreach my $line (@lines) {
		if ($line=~/^\+\+\+\s+(\S+)/) {
			$setup_docs = 0;
			if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
				$setup_docs = 1;
			}
			next;
		}

		if ($setup_docs && $line =~ /^\+/) {
			push(@setup_docs, $line);
		}
	}

597
598
	$prefix = '';

599
600
601
	foreach my $line (@lines) {
		$linenr++;

602
603
		my $rawline = $line;

604

605
606
607
#extract the filename as it passes
		if ($line=~/^\+\+\+\s+(\S+)/) {
			$realfile=$1;
608
			$realfile =~ s@^[^/]*/@@;
609
610
611
612
			$in_comment = 0;
			next;
		}
#extract the line range in the file after the patch is applied
613
		if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
614
			$is_patch = 1;
615
			$first_line = $linenr + 1;
616
617
618
619
620
621
622
			$in_comment = 0;
			$realline=$1-1;
			if (defined $2) {
				$realcnt=$3+1;
			} else {
				$realcnt=1+1;
			}
623
			$prev_values = 'N';
624
625
626
			next;
		}

627
628
629
630
# track the line number as we move through the hunk, note that
# new versions of GNU diff omit the leading space on completely
# blank context lines so we need to count that too.
		if ($line =~ /^( |\+|$)/) {
631
			$realline++;
632
			$realcnt-- if ($realcnt != 0);
633
634
635
636
637
638
639
640

			# track any sort of multi-line comment.  Obviously if
			# the added text or context do not include the whole
			# comment we will not see it. Such is life.
			#
			# Guestimate if this is a continuing comment.  If this
			# is the start of a diff block and this line starts
			# ' *' then it is very likely a comment.
641
			if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
642
643
644
645
646
647
648
649
650
				$in_comment = 1;
			}
			if ($line =~ m@/\*@) {
				$in_comment = 1;
			}
			if ($line =~ m@\*/@) {
				$in_comment = 0;
			}

651
652
			# Measure the line length and indent.
			($length, $indent) = line_stats($line);
653
654
655
656

			# Track the previous line.
			($prevline, $stashline) = ($stashline, $line);
			($previndent, $stashindent) = ($stashindent, $indent);
657

658
659
		} elsif ($realcnt == 1) {
			$realcnt--;
660
661
662
		}

#make up the handle for any error we report on this line
663
664
		$here = "#$linenr: " if (!$file);
		$here = "#$realline: " if ($file);
665
		$here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
666

667
		my $hereline = "$here\n$line\n";
668
669
		my $herecurr = "$here\n$line\n";
		my $hereprev = "$here\n$prevline\n$line\n";
670

671
672
673
674
		$prefix = "$filename:$realline: " if ($emacs && $file);
		$prefix = "$filename:$linenr: " if ($emacs && !$file);
		$cnt_lines++ if ($realcnt != 0);

675
#check the patch for a signoff:
676
		if ($line =~ /^\s*signed-off-by:/i) {
677
678
			# This is a signoff, if ugly, so do not double report.
			$signoff++;
679
			if (!($line =~ /^\s*Signed-off-by:/)) {
680
681
				WARN("Signed-off-by: is the preferred form\n" .
					$herecurr);
682
683
			}
			if ($line =~ /^\s*signed-off-by:\S/i) {
684
685
				WARN("need space after Signed-off-by:\n" .
					$herecurr);
686
687
688
			}
		}

689
690
# Check for wrappage within a valid hunk of the file
		if ($realcnt != 0 && $line !~ m{^(?:\+|-| |$)}) {
691
			ERROR("patch seems to be corrupt (line wrapped?)\n" .
692
				$herecurr) if (!$emitted_corrupt++);
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
		}

# UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
		if (($realfile =~ /^$/ || $line =~ /^\+/) &&
		     !($line =~ m/^(
				[\x09\x0A\x0D\x20-\x7E]              # ASCII
				| [\xC2-\xDF][\x80-\xBF]             # non-overlong 2-byte
				|  \xE0[\xA0-\xBF][\x80-\xBF]        # excluding overlongs
				| [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2}  # straight 3-byte
				|  \xED[\x80-\x9F][\x80-\xBF]        # excluding surrogates
				|  \xF0[\x90-\xBF][\x80-\xBF]{2}     # planes 1-3
				| [\xF1-\xF3][\x80-\xBF]{3}          # planes 4-15
				|  \xF4[\x80-\x8F][\x80-\xBF]{2}     # plane 16
				)*$/x )) {
			ERROR("Invalid UTF-8\n" . $herecurr);
708
709
710
711
		}

#ignore lines being removed
		if ($line=~/^-/) {next;}
712

713
714
# check we are in a valid source file if not then ignore this hunk
		next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
715
716

#trailing whitespace
717
718
719
720
721
		if ($line =~ /^\+.*\015/) {
			my $herevet = "$here\n" . cat_vet($line) . "\n";
			ERROR("DOS line endings\n" . $herevet);

		} elsif ($line =~ /^\+.*\S\s+$/ || $line =~ /^\+\s+$/) {
722
723
			my $herevet = "$here\n" . cat_vet($line) . "\n";
			ERROR("trailing whitespace\n" . $herevet);
724
725
		}
#80 column limit
726
		if ($line =~ /^\+/ && !($prevline=~/\/\*\*/) && $length > 80) {
727
			WARN("line over 80 characters\n" . $herecurr);
728
729
730
731
732
733
734
735
		}

# check we are in a valid source file *.[hc] if not then ignore this hunk
		next if ($realfile !~ /\.[hc]$/);

# at the beginning of a line any tabs must come first and anything
# more than 8 must use tabs.
		if ($line=~/^\+\s* \t\s*\S/ or $line=~/^\+\s*        \s*/) {
736
737
			my $herevet = "$here\n" . cat_vet($line) . "\n";
			ERROR("use tabs not spaces\n" . $herevet);
738
739
		}

740
# Remove comments from the line before processing.
741
742
743
744
745
746
747
748
		my $comment_edge = ($line =~ s@/\*.*\*/@@g) +
				   ($line =~ s@/\*.*@@) +
				   ($line =~ s@^(.).*\*/@$1@);

# The rest of our checks refer specifically to C style
# only apply those _outside_ comments.  Only skip
# lines in the middle of comments.
		next if (!$comment_edge && $in_comment);
749

750
751
752
# Standardise the strings and chars within the input to simplify matching.
		$line = sanitise_line($line);

753
754
755
756
757
# Check for potential 'bare' types
		if ($realcnt &&
		    $line !~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?$Type\b/ &&
		    $line !~ /$Ident:\s*$/ &&
		    $line !~ /^.\s*$Ident\s*\(/ &&
758
		     # definitions in global scope can only start with types
759
		    ($line =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?($Ident)\b/ ||
760
761
762
763
		     # declarations always start with types
		     $line =~ /^.\s*(?:$Storage\s+)?($Ident)\b\s*\**\s*$Ident\s*(?:;|=)/) ||
		     # any (foo ... *) is a pointer cast, and foo is a type
		     $line =~ /\(($Ident)(?:\s+$Sparse)*\s*\*+\s*\)/) {
764
765
766
767
768
769
770
771
772
			my $possible = $1;
			if ($possible !~ /^(?:$Storage|$Type|DEFINE_\S+)$/ &&
			    $possible ne 'goto' && $possible ne 'return' &&
			    $possible ne 'struct' && $possible ne 'enum' &&
			    $possible ne 'case' && $possible ne 'else' &&
			    $possible ne 'typedef') {
				#print "POSSIBLE<$possible>\n";
				push(@bare, $possible);
				my $bare = join("|", @bare);
773
				$Bare	= '|' . qr{
774
775
776
777
778
779
780
						\b(?:$bare)\b
						(?:\s*\*+\s*const|\s*\*+|(?:\s*\[\s*\])+)?
						(?:\s+$Sparse)*
					  }x;
			}
		}

781
782
783
#
# Checks which may be anchored in the context.
#
784

785
786
# Check for switch () and associated case and default
# statements should be at the same indent.
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
		if ($line=~/\bswitch\s*\(.*\)/) {
			my $err = '';
			my $sep = '';
			my @ctx = ctx_block_outer($linenr, $realcnt);
			shift(@ctx);
			for my $ctx (@ctx) {
				my ($clen, $cindent) = line_stats($ctx);
				if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
							$indent != $cindent) {
					$err .= "$sep$ctx\n";
					$sep = '';
				} else {
					$sep = "[...]\n";
				}
			}
			if ($err ne '') {
803
				ERROR("switch and case should be at the same indent\n$hereline$err");
804
805
806
807
808
809
			}
		}

# if/while/etc brace do not go on next line, unless defining a do while loop,
# or if that brace on the next line is for something else
		if ($line =~ /\b(?:(if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.#/) {
810
			my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
811
812
813
814
			my $ctx_ln = $linenr + $#ctx + 1;
			my $ctx_cnt = $realcnt - $#ctx - 1;
			my $ctx = join("\n", @ctx);

815
			# Skip over any removed lines in the context following statement.
816
817
818
819
820
821
822
			while ($ctx_cnt > 0 && $lines[$ctx_ln - 1] =~ /^-/) {
				$ctx_ln++;
				$ctx_cnt--;
			}
			##warn "line<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>";

			if ($ctx !~ /{\s*/ && $ctx_cnt > 0 && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
823
				ERROR("That open brace { should be on the previous line\n" .
824
					"$here\n$ctx\n$lines[$ctx_ln - 1]");
825
			}
826
827
828
829
830
831
832
			if ($level == 0 && $ctx =~ /\)\s*\;\s*$/ && defined $lines[$ctx_ln - 1]) {
				my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
				if ($nindent > $indent) {
					WARN("Trailing semicolon indicates no statements, indent implies otherwise\n" .
						"$here\n$ctx\n$lines[$ctx_ln - 1]");
				}
			}
833
834
		}

835
836
837
838
839
840
841
842
		# Track the 'values' across context and added lines.
		my $opline = $line; $opline =~ s/^./ /;
		my $curr_values = annotate_values($opline . "\n", $prev_values);
		$curr_values = $prev_values . $curr_values;
		#warn "--> $opline\n";
		#warn "--> $curr_values ($prev_values)\n";
		$prev_values = substr($curr_values, -1);

843
844
845
#ignore lines not being added
		if ($line=~/^[^\+]/) {next;}

846
847
# TEST: allow direct testing of the type matcher.
		if ($tst_type && $line =~ /^.$Declare$/) {
848
			ERROR("TEST: is type $Declare\n" . $herecurr);
849
850
851
			next;
		}

852
853
854
855
856
857
# check for initialisation to aggregates open brace on the next line
		if ($prevline =~ /$Declare\s*$Ident\s*=\s*$/ &&
		    $line =~ /^.\s*{/) {
			ERROR("That open brace { should be on the previous line\n" . $hereprev);
		}

858
859
860
861
862
863
864
865
#
# Checks which are anchored on the added line.
#

# check for malformed paths in #include statements (uses RAW line)
		if ($rawline =~ m{^.#\s*include\s+[<"](.*)[">]}) {
			my $path = $1;
			if ($path =~ m{//}) {
866
867
				ERROR("malformed #include filename\n" .
					$herecurr);
868
869
870
871
872
			}
			# Sanitise this special form of string.
			$path = 'X' x length($path);
			$line =~ s{\<.*\>}{<$path>};
		}
873

874
# no C99 // comments
875
		if ($line =~ m{//}) {
876
			ERROR("do not use C99 // comments\n" . $herecurr);
877
		}
878
		# Remove C99 comments.
879
		$line =~ s@//.*@@;
880
		$opline =~ s@//.*@@;
881
882

#EXPORT_SYMBOL should immediately follow its function closing }.
883
884
885
		if (($line =~ /EXPORT_SYMBOL.*\((.*)\)/) ||
		    ($line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
			my $name = $1;
886
887
			if (($prevline !~ /^}/) &&
			   ($prevline !~ /^\+}/) &&
888
			   ($prevline !~ /^ }/) &&
889
			   ($prevline !~ /\b\Q$name\E(?:\s+$Attribute)?\s*(?:;|=)/)) {
890
				WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
891
892
893
			}
		}

894
895
896
897
898
# check for external initialisers.
		if ($line =~ /^.$Type\s*$Ident\s*=\s*(0|NULL);/) {
			ERROR("do not initialise externals to 0 or NULL\n" .
				$herecurr);
		}
899
# check for static initialisers.
900
		if ($line =~ /\s*static\s.*=\s*(0|NULL);/) {
901
902
			ERROR("do not initialise statics to 0 or NULL\n" .
				$herecurr);
903
904
		}

905
906
907
# check for new typedefs, only function parameters and sparse annotations
# make sense.
		if ($line =~ /\btypedef\s/ &&
908
		    $line !~ /\btypedef\s+$Type\s+\(\s*\*?$Ident\s*\)\s*\(/ &&
909
		    $line !~ /\b__bitwise(?:__|)\b/) {
910
			WARN("do not add new typedefs\n" . $herecurr);
911
912
913
		}

# * goes on variable not on type
914
		if ($line =~ m{\($NonptrType(\*+)(?:\s+const)?\)}) {
915
916
			ERROR("\"(foo$1)\" should be \"(foo $1)\"\n" .
				$herecurr);
917
918

		} elsif ($line =~ m{\($NonptrType\s+(\*+)(?!\s+const)\s+\)}) {
919
920
			ERROR("\"(foo $1 )\" should be \"(foo $1)\"\n" .
				$herecurr);
921

922
		} elsif ($line =~ m{$NonptrType(\*+)(?:\s+(?:$Attribute|$Sparse))?\s+[A-Za-z\d_]+}) {
923
924
			ERROR("\"foo$1 bar\" should be \"foo $1bar\"\n" .
				$herecurr);
925

926
		} elsif ($line =~ m{$NonptrType\s+(\*+)(?!\s+(?:$Attribute|$Sparse))\s+[A-Za-z\d_]+}) {
927
928
			ERROR("\"foo $1 bar\" should be \"foo $1bar\"\n" .
				$herecurr);
929
930
931
932
933
934
935
936
937
		}

# # no BUG() or BUG_ON()
# 		if ($line =~ /\b(BUG|BUG_ON)\b/) {
# 			print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
# 			print "$herecurr";
# 			$clean = 0;
# 		}

938
939
940
941
942
# printk should use KERN_* levels.  Note that follow on printk's on the
# same line do not need a level, so we use the current block context
# to try and find and validate the current printk.  In summary the current
# printk includes all preceeding printk's which have no newline on the end.
# we assume the first bad printk is the one to report.
943
		if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
944
945
946
947
948
949
950
951
952
953
954
955
956
			my $ok = 0;
			for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
				#print "CHECK<$lines[$ln - 1]\n";
				# we have a preceeding printk if it ends
				# with "\n" ignore it, else it is to blame
				if ($lines[$ln - 1] =~ m{\bprintk\(}) {
					if ($rawlines[$ln - 1] !~ m{\\n"}) {
						$ok = 1;
					}
					last;
				}
			}
			if ($ok == 0) {
957
				WARN("printk() should include KERN_ facility level\n" . $herecurr);
958
			}
959
960
		}

961
962
# function brace can't be on same line, except for #defines of do while,
# or if closed on same line
963
		if (($line=~/$Type\s*[A-Za-z\d_]+\(.*\).* {/) and
964
		    !($line=~/\#define.*do\s{/) and !($line=~/}/)) {
965
			ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr);
966
		}
967

968
# check for spaces between functions and their parentheses.
969
970
971
972
973
		while ($line =~ /($Ident)\s+\(/g) {
			if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/ &&
		            $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) {
				WARN("no space between function name and open parenthesis '('\n" . $herecurr);
			}
974
		}
975
# Check operator spacing.
976
		if (!($line=~/\#\s*include/)) {
977
978
979
980
981
982
983
			my $ops = qr{
				<<=|>>=|<=|>=|==|!=|
				\+=|-=|\*=|\/=|%=|\^=|\|=|&=|
				=>|->|<<|>>|<|>|=|!|~|
				&&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/
			}x;
			my @elements = split(/($ops|;)/, $opline);
984
			my $off = 0;
985
986
987

			my $blank = copy_spacing($opline);

988
			for (my $n = 0; $n < $#elements; $n += 2) {
989
990
991
992
993
994
995
996
997
				$off += length($elements[$n]);

				my $a = '';
				$a = 'V' if ($elements[$n] ne '');
				$a = 'W' if ($elements[$n] =~ /\s$/);
				$a = 'B' if ($elements[$n] =~ /(\[|\()$/);
				$a = 'O' if ($elements[$n] eq '');
				$a = 'E' if ($elements[$n] eq '' && $n == 0);

998
				my $op = $elements[$n + 1];
999
1000

				my $c = '';
1001
				if (defined $elements[$n + 2]) {
1002
1003
1004
1005
					$c = 'V' if ($elements[$n + 2] ne '');
					$c = 'W' if ($elements[$n + 2] =~ /^\s/);
					$c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
					$c = 'O' if ($elements[$n + 2] eq '');
1006
					$c = 'E' if ($elements[$n + 2] =~ /\s*\\$/);
1007
1008
				} else {
					$c = 'E';
1009
1010
				}

1011
				# Pick up the preceeding and succeeding characters.
1012
				my $ca = substr($opline, 0, $off);
1013
				my $cc = '';
1014
				if (length($opline) >= ($off + length($elements[$n + 1]))) {
1015
					$cc = substr($opline, $off + length($elements[$n + 1]));
1016
				}
1017
				my $cb = "$ca$;$cc";
1018

1019
1020
1021
1022
				my $ctx = "${a}x${c}";

				my $at = "(ctx:$ctx)";

1023
				my $ptr = substr($blank, 0, $off) . "^";
1024
				my $hereptr = "$hereline$ptr\n";
1025

1026
1027
1028
				# Classify operators into binary, unary, or
				# definitions (* only) where they have more
				# than one mode.
1029
1030
1031
1032
1033
1034
1035
1036
1037
				my $op_type = substr($curr_values, $off + 1, 1);
				my $op_left = substr($curr_values, $off, 1);
				my $is_unary;
				if ($op_type eq 'T') {
					$is_unary = 2;
				} elsif ($op_left eq 'V') {
					$is_unary = 0;
				} else {
					$is_unary = 1;
1038
1039
				}
				#if ($op eq '-' || $op eq '&' || $op eq '*') {
1040
				#	print "UNARY: <$op_left$op_type $is_unary $a:$op:$c> <$ca:$op:$cc> <$unary_ctx>\n";
1041
				#}
1042

1043
1044
				# ; should have either the end of line or a space or \ after it
				if ($op eq ';') {
1045
1046
1047
					if ($ctx !~ /.x[WEB]/ && $cc !~ /^\\/ &&
					    $cc !~ /^;/) {
						ERROR("need space after that '$op' $at\n" . $hereptr);
1048
1049
1050
1051
					}

				# // is a comment
				} elsif ($op eq '//') {
1052
1053
1054

				# -> should have no spaces
				} elsif ($op eq '->') {
1055
					if ($ctx =~ /Wx.|.xW/) {
1056
						ERROR("no spaces around that '$op' $at\n" . $hereptr);
1057
1058
1059
1060
					}

				# , must have a space on the right.
				} elsif ($op eq ',') {
1061
					if ($ctx !~ /.xW|.xE/ && $cc !~ /^}/) {
1062
						ERROR("need space after that '$op' $at\n" . $hereptr);
1063
1064
					}

1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
				# '*' as part of a type definition -- reported already.
				} elsif ($op eq '*' && $is_unary == 2) {
					#warn "'*' is part of type\n";

				# unary operators should have a space before and
				# none after.  May be left adjacent to another
				# unary operator, or a cast
				} elsif ($op eq '!' || $op eq '~' ||
				         ($is_unary && ($op eq '*' || $op eq '-' || $op eq '&'))) {
					if ($ctx !~ /[WEB]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
1075
						ERROR("need space before that '$op' $at\n" . $hereptr);
1076
					}
1077
					if ($ctx =~ /.xW/) {
1078
						ERROR("no space after that '$op' $at\n" . $hereptr);
1079
1080
1081
1082
					}

				# unary ++ and unary -- are allowed no space on one side.
				} elsif ($op eq '++' or $op eq '--') {
1083
					if ($ctx !~ /[WOB]x[^W]/ && $ctx !~ /[^W]x[WOBE]/) {
1084
						ERROR("need space one side of that '$op' $at\n" . $hereptr);
1085
					}
1086
					if ($ctx =~ /Wx./ && $cc =~ /^;/) {
1087
						ERROR("no space before that '$op' $at\n" . $hereptr);
1088
					}
1089
1090

				# << and >> may either have or not have spaces both sides
1091
1092
1093
1094
				} elsif ($op eq '<<' or $op eq '>>' or
					 $op eq '&' or $op eq '^' or $op eq '|' or
					 $op eq '+' or $op eq '-' or
					 $op eq '*' or $op eq '/')
1095
				{
1096
					if ($ctx !~ /VxV|WxW|VxE|WxE|VxO/) {
1097
1098
						ERROR("need consistent spacing around '$op' $at\n" .
							$hereptr);
1099
1100
1101
					}

				# All the others need spaces both sides.
1102
				} elsif ($ctx !~ /[EW]x[WE]/) {
1103
1104
1105
1106
1107
					# Ignore email addresses <foo@bar>
					if (!($op eq '<' && $cb =~ /$;\S+\@\S+>/) &&
					    !($op eq '>' && $cb =~ /<\S+\@\S+$;/)) {
						ERROR("need spaces around that '$op' $at\n" . $hereptr);
					}
1108
				}
1109
				$off += length($elements[$n + 1]);
1110
1111
1112
			}
		}

1113
1114
# check for multiple assignments
		if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
1115
			CHK("multiple assignments should be avoided\n" . $herecurr);
1116
1117
		}

1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
## # check for multiple declarations, allowing for a function declaration
## # continuation.
## 		if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
##
## 			# Remove any bracketed sections to ensure we do not
## 			# falsly report the parameters of functions.
## 			my $ln = $line;
## 			while ($ln =~ s/\([^\(\)]*\)//g) {
## 			}
## 			if ($ln =~ /,/) {
## 				WARN("declaring multiple variables together should be avoided\n" . $herecurr);
## 			}
## 		}
1132

1133
#need space before brace following if, while, etc
1134
1135
		if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
		    $line =~ /do{/) {
1136
1137
1138
1139
1140
1141
1142
			ERROR("need a space before the open brace '{'\n" . $herecurr);
		}

# closing brace should have a space following it when it has anything
# on the line
		if ($line =~ /}(?!(?:,|;|\)))\S/) {
			ERROR("need a space after that close brace '}'\n" . $herecurr);
1143
1144
		}

1145
1146
1147
1148
1149
1150
1151
1152
1153
# check spacing on square brackets
		if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
			ERROR("no space after that open square bracket '['\n" . $herecurr);
		}
		if ($line =~ /\s\]/) {
			ERROR("no space before that close square bracket ']'\n" . $herecurr);
		}

# check spacing on paretheses
1154
1155
		if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
		    $line !~ /for\s*\(\s+;/) {
1156
1157
			ERROR("no space after that open parenthesis '('\n" . $herecurr);
		}
1158
1159
		if ($line =~ /\s\)/ && $line !~ /^.\s*\)/ &&
		    $line !~ /for\s*\(.*;\s+\)/) {
1160
1161
1162
			ERROR("no space before that close parenthesis ')'\n" . $herecurr);
		}

1163
#goto labels aren't indented, allow a single space however
1164
		if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
1165
		   !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
1166
			WARN("labels should not be indented\n" . $herecurr);
1167
1168
1169
		}

# Need a space before open parenthesis after if, while etc
1170
		if ($line=~/\b(if|while|for|switch)\(/) {
1171
			ERROR("need a space before the open parenthesis '('\n" . $herecurr);
1172
1173
1174
		}

# Check for illegal assignment in if conditional.
1175
		if ($line=~/\bif\s*\(.*[^<>!=]=[^=]/) {
1176
			#next if ($line=~/\".*\Q$op\E.*\"/ or $line=~/\'\Q$op\E\'/);
1177
			ERROR("do not use assignment in if condition\n" . $herecurr);
1178
1179
1180
1181
1182
1183
		}

		# Check for }<nl>else {, these must be at the same
		# indent level to be relevant to each other.
		if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
						$previndent == $indent) {
1184
			ERROR("else should follow close brace '}'\n" . $hereprev);
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
		}

#studly caps, commented out until figure out how to distinguish between use of existing and adding new
#		if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
#		    print "No studly caps, use _\n";
#		    print "$herecurr";
#		    $clean = 0;
#		}

#no spaces allowed after \ in define
		if ($line=~/\#define.*\\\s$/) {
1196
			WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr);
1197
1198
		}

1199
1200
#warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
		if ($tree && $rawline =~ m{^.\#\s*include\s*\<asm\/(.*)\.h\>}) {
1201
1202
			my $checkfile = "$root/include/linux/$1.h";
			if (-f $checkfile && $1 ne 'irq.h') {
1203
1204
				CHK("Use #include <linux/$1.h> instead of <asm/$1.h>\n" .
					$herecurr);
1205
1206
1207
			}
		}

1208
1209
# if and else should not have general statements after it
		if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/ &&
1210
1211
		    $1 !~ /^\s*(?:\sif|{|\\|$)/) {
			ERROR("trailing statements should be on next line\n" . $herecurr);
1212
1213
		}

1214
1215
1216
# multi-statement macros should be enclosed in a do while loop, grab the
# first statement and ensure its the whole macro if its not enclosed
# in a known goot container
1217
1218
1219
1220
		if ($prevline =~ /\#define.*\\/ &&
		   $prevline !~/(?:do\s+{|\(\{|\{)/ &&
		   $line !~ /(?:do\s+{|\(\{|\{)/ &&
		   $line !~ /^.\s*$Declare\s/) {
1221
1222
1223
			# Grab the first statement, if that is the entire macro
			# its ok.  This may start either on the #define line
			# or the one below.
1224
1225
			my $ln = $linenr;
			my $cnt = $realcnt;
1226
			my $off = 0;
1227

1228
1229
1230
1231
			# If the macro starts on the define line start
			# grabbing the statement after the identifier
			$prevline =~ m{^(.#\s*define\s*$Ident(?:\([^\)]*\))?\s*)(.*)\\\s*$};
			##print "1<$1> 2<$2>\n";
1232
			if (defined $2 && $2 ne '') {
1233
				$off = length($1);
1234
1235
1236
				$ln--;
				$cnt++;
			}
1237
			my @ctx = ctx_statement($ln, $cnt, $off);
1238
1239
1240
1241
1242
1243
1244
1245
1246
			my $ctx_ln = $ln + $#ctx + 1;
			my $ctx = join("\n", @ctx);

			# Pull in any empty extension lines.
			while ($ctx =~ /\\$/ &&
			       $lines[$ctx_ln - 1] =~ /^.\s*(?:\\)?$/) {
				$ctx .= $lines[$ctx_ln - 1];
				$ctx_ln++;
			}
1247
1248
1249

			if ($ctx =~ /\\$/) {
				if ($ctx =~ /;/) {
1250
					ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n");
1251
				} else {
1252
					ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n");
1253
				}
1254
			}
1255
1256
		}

1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
# check for redundant bracing round if etc
		if ($line =~ /\b(if|while|for|else)\b/) {
			# Locate the end of the opening statement.
			my @control = ctx_statement($linenr, $realcnt, 0);
			my $nr = $linenr + (scalar(@control) - 1);
			my $cnt = $realcnt - (scalar(@control) - 1);

			my $off = $realcnt - $cnt;
			#print "$off: line<$line>end<" . $lines[$nr - 1] . ">\n";

			# If this is is a braced statement group check it
			if ($lines[$nr - 1] =~ /{\s*$/) {
				my ($lvl, @block) = ctx_block_level($nr, $cnt);

				my $stmt = join(' ', @block);
1272
1273
1274
1275
				$stmt =~ s/(^[^{]*){//;
				my $before = $1;
				$stmt =~ s/}([^}]*$)//;
				my $after = $1;
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286

				#print "block<" . join(' ', @block) . "><" . scalar(@block) . ">\n";
				#print "stmt<$stmt>\n\n";

				# Count the ;'s if there is fewer than two
				# then there can only be one statement,
				# if there is a brace inside we cannot
				# trivially detect if its one statement.
				# Also nested if's often require braces to
				# disambiguate the else binding so shhh there.
				my @semi = ($stmt =~ /;/g);
1287
				push(@semi, "/**/") if ($stmt =~ m@/\*@);
1288
1289
				##print "semi<" . scalar(@semi) . ">\n";
				if ($lvl == 0 && scalar(@semi) < 2 &&
1290
1291
				    $stmt !~ /{/ && $stmt !~ /\bif\b/ &&
				    $before !~ /}/ && $after !~ /{/) {
1292
1293
				    	my $herectx = "$here\n" . join("\n", @control, @block[1 .. $#block]) . "\n";
				    	shift(@block);
1294
					WARN("braces {} are not necessary for single statement blocks\n" . $herectx);
1295
1296
1297
1298
				}
			}
		}

1299
# don't include deprecated include files (uses RAW line)
Andy Whitcroft's avatar