Skip to content
  • Joe Perches's avatar
    checkpatch: check networking specific block comment style · 05880600
    Joe Perches authored
    
    
    In an effort to get fewer checkpatch reviewer corrections, add a
    networking specific style test for the preferred networking comment style.
    
    	/* The preferred style for block comments in
    	 * drivers/net/... and net/... is like this
    	 */
    
    These tests are only used in net/ and drivers/net/
    
    Tested with:
    
    $ cat drivers/net/t.c
    
    /* foo */
    
    /*
     * foo
     */
    
    /* foo
     */
    
    /* foo
     * bar */
    $ ./scripts/checkpatch.pl -f drivers/net/t.c
    WARNING: networking block comments don't use an empty /* line, use /* Comment...
    #4: FILE: net/t.c:4:
    +
    +/*
    
    WARNING: networking block comments put the trailing */ on a separate line
    #12: FILE: net/t.c:12:
    + * bar */
    
    total: 0 errors, 2 warnings, 12 lines checked
    
    Signed-off-by: default avatarJoe Perches <joe@perches.com>
    Cc: "Allan, Bruce W" <bruce.w.allan@intel.com>
    Cc: Andy Whitcroft <apw@canonical.com>
    Cc: David Miller <davem@davemloft.net>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    05880600