Skip to content
  • Al Viro's avatar
    GFS2: fix d_splice_alias() misuses · cfb2f9d5
    Al Viro authored
    
    
    Callers of d_splice_alias(dentry, inode) don't need iput(), neither
    on success nor on failure.  Either the reference to inode is stored
    in a previously negative dentry, or it's dropped.  In either case
    inode reference the caller used to hold is consumed.
    
    __gfs2_lookup() does iput() in case when d_splice_alias() has failed.
    Double iput() if we ever hit that.  And gfs2_create_inode() ends up
    not only with double iput(), but with link count dropped to zero - on
    an inode it has just found in directory.
    
    Cc: stable@vger.kernel.org # v3.14+
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
    cfb2f9d5