• Jeff Layton's avatar
    locks: allow __break_lease to sleep even when break_time is 0 · 4991a628
    Jeff Layton authored
    
    
    A fl->fl_break_time of 0 has a special meaning to the lease break code
    that basically means "never break the lease". knfsd uses this to ensure
    that leases don't disappear out from under it.
    
    Unfortunately, the code in __break_lease can end up passing this value
    to wait_event_interruptible as a timeout, which prevents it from going
    to sleep at all. This causes __break_lease to spin in a tight loop and
    causes soft lockups.
    
    Fix this by ensuring that we pass a minimum value of 1 as a timeout
    instead.
    
    Cc: <stable@vger.kernel.org>
    Cc: J. Bruce Fields <bfields@fieldses.org>
    Reported-by: default avatarTerry Barnaby <terry1@beam.ltd.uk>
    Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    4991a628
locks.c 68.4 KB