Skip to content
  • Chanwoo Choi's avatar
    rtc: s3c: remove warning message when checking coding style with checkpatch script · d67288da
    Chanwoo Choi authored
    
    
    Remove warning message when checking codeing style with checkpatch script
    and reduce un-necessary i2c read operation on s3c_rtc_enable.
    
        WARNING: line over 80 characters
        #406: FILE: drivers/rtc/rtc-s3c.c:406:
        +		if ((readw(info->base + S3C2410_RTCCON) & S3C2410_RTCCON_RTCEN) == 0) {
    
        WARNING: line over 80 characters
        #414: FILE: drivers/rtc/rtc-s3c.c:414:
        +		if ((readw(info->base + S3C2410_RTCCON) & S3C2410_RTCCON_CNTSEL)) {
    
        WARNING: line over 80 characters
        #422: FILE: drivers/rtc/rtc-s3c.c:422:
        +		if ((readw(info->base + S3C2410_RTCCON) & S3C2410_RTCCON_CLKRST)) {
    
        WARNING: Missing a blank line after declarations
        #451: FILE: drivers/rtc/rtc-s3c.c:451:
        +	struct s3c_rtc_drv_data *data;
        +	if (pdev->dev.of_node) {
    
        WARNING: Missing a blank line after declarations
        #453: FILE: drivers/rtc/rtc-s3c.c:453:
        +		const struct of_device_id *match;
        +		match = of_match_node(s3c_rtc_dt_match, pdev->dev.of_node);
    
        WARNING: DT compatible string "samsung,s3c2416-rtc" appears un-documented -- check ./Documentation/devicetree/bindings/
        #650: FILE: drivers/rtc/rtc-s3c.c:650:
        +		.compatible = "samsung,s3c2416-rtc",
    
        WARNING: DT compatible string "samsung,s3c2443-rtc" appears un-documented -- check ./Documentation/devicetree/bindings/
        #653: FILE: drivers/rtc/rtc-s3c.c:653:
        +		.compatible = "samsung,s3c2443-rtc",
    
    Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
    Acked-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
    Cc: Alessandro Zummo <a.zummo@towertech.it>
    Cc: Kukjin Kim <kgene.kim@samsung.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    d67288da