Commit 0979ae66 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: Add --strict messages for blank lines around braces

Blank lines around braces are not unnecessary.  Emit a message on the use
of these blank lines only when using --strict.

int foo(int bar)

	something or other....


is generally written in the kernel as:

int foo(int bar)
	something or other...
Signed-off-by: default avatarJoe Perches <>
Cc: Andy Whitcroft <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 481eb486
......@@ -3189,6 +3189,16 @@ sub process {
# check for unnecessary blank lines around braces
if (($line =~ /^..*}\s*$/ && $prevline =~ /^.\s*$/)) {
"Blank lines aren't necessary before a close brace '}'\n" . $hereprev);
if (($line =~ /^.\s*$/ && $prevline =~ /^..*{\s*$/)) {
"Blank lines aren't necessary after an open brace '{'\n" . $hereprev);
# no volatiles please
my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment