Commit 454cc105 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Linus Torvalds
Browse files

[PATCH] proc: Remove tasklist_lock from proc_pid_readdir



We don't need the tasklist_lock to safely iterate through processes
anymore.

This depends on my previous to task patches that make get_task_struct rcu
safe, and that make next_task() rcu safe.  I haven't gotten
first_tid/next_tid yet only because next_thread is missing an
rcu_dereference.
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 0bc58a91
......@@ -2043,7 +2043,7 @@ static struct dentry *proc_task_lookup(struct inode *dir, struct dentry * dentry
static struct task_struct *first_tgid(int tgid, int nr)
{
struct task_struct *pos = NULL;
read_lock(&tasklist_lock);
rcu_read_lock();
if (tgid && nr) {
pos = find_task_by_pid(tgid);
if (pos && !thread_group_leader(pos))
......@@ -2069,7 +2069,7 @@ static struct task_struct *first_tgid(int tgid, int nr)
}
pos = NULL;
done:
read_unlock(&tasklist_lock);
rcu_read_unlock();
return pos;
}
......@@ -2082,7 +2082,7 @@ static struct task_struct *first_tgid(int tgid, int nr)
static struct task_struct *next_tgid(struct task_struct *start)
{
struct task_struct *pos;
read_lock(&tasklist_lock);
rcu_read_lock();
pos = start;
if (pid_alive(start))
pos = next_task(start);
......@@ -2092,7 +2092,7 @@ static struct task_struct *next_tgid(struct task_struct *start)
}
pos = NULL;
done:
read_unlock(&tasklist_lock);
rcu_read_unlock();
put_task_struct(start);
return pos;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment