Commit 824c6b7f authored by Mandeep Singh Baines's avatar Mandeep Singh Baines Committed by Ingo Molnar
Browse files

watchdog: Fix rounding bug in get_sample_period()

In get_sample_period(), softlockup_thresh is integer divided by
5 before the multiplication by NSEC_PER_SEC. This results in
softlockup_thresh being rounded down to the nearest integer
multiple of 5.

For example, a softlockup_thresh of 4 rounds down to 0.
Signed-off-by: default avatarMandeep Singh Baines <>
Cc: Marcin Slusarz <>
Cc: Don Zickus <>
Cc: Peter Zijlstra <>
Cc: Frederic Weisbecker <>

Signed-off-by: default avatarIngo Molnar <>
parent 3ac1bbcf
......@@ -110,7 +110,7 @@ static unsigned long get_sample_period(void)
* increment before the hardlockup detector generates
* a warning
return softlockup_thresh / 5 * NSEC_PER_SEC;
return softlockup_thresh * (NSEC_PER_SEC / 5);
/* Commands for resetting the watchdog */
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment