Commit c68e5878 authored by Arnaud Lacombe's avatar Arnaud Lacombe Committed by Michal Marek
Browse files

script/ warn about deprecated use of EXTRA_{A,C,CPP,LD}FLAGS

Usage of these flags has been deprecated for nearly 4 years by:

    commit f77bf014

    Author: Sam Ravnborg <sam@neptun.(none)>
    Date:   Mon Oct 15 22:25:06 2007 +0200

        kbuild: introduce ccflags-y, asflags-y and ldflags-y

Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command
line use. By default, gmake(1) do not override command line setting, so this is
likely to result in build failure or unexpected behavior.

Warn about their introduction in Makefile or Kbuild files.

Cc: Sam Ravnborg <>
Cc: Andy Whitcroft <>
Signed-off-by: default avatarArnaud Lacombe <>
Signed-off-by: default avatarMichal Marek <>
parent 9c65426a
......@@ -1661,6 +1661,20 @@ sub process {
#print "is_end<$is_end> length<$length>\n";
if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
my $flag = $1;
my $replacement = {
'EXTRA_AFLAGS' => 'asflags-y',
'EXTRA_CFLAGS' => 'ccflags-y',
'EXTRA_CPPFLAGS' => 'cppflags-y',
'EXTRA_LDFLAGS' => 'ldflags-y',
"Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
# check we are in a valid source file if not then ignore this hunk
next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment