Commit d7ca663c authored by Dan Carpenter's avatar Dan Carpenter Committed by Nicholas Bellinger
Browse files

target/iscsi: precedence bug in iscsit_set_dataout_sequence_values()



Clang warns about this bug:
drivers/target/iscsi/iscsi_target_erl0.c:52:45: warning: operator '?:'
	has lower precedence than '+'; '+' will be evaluated first
	[-Wparentheses]

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 232ebe34
...@@ -48,9 +48,9 @@ void iscsit_set_dataout_sequence_values( ...@@ -48,9 +48,9 @@ void iscsit_set_dataout_sequence_values(
if (cmd->unsolicited_data) { if (cmd->unsolicited_data) {
cmd->seq_start_offset = cmd->write_data_done; cmd->seq_start_offset = cmd->write_data_done;
cmd->seq_end_offset = (cmd->write_data_done + cmd->seq_end_offset = (cmd->write_data_done +
(cmd->se_cmd.data_length > ((cmd->se_cmd.data_length >
conn->sess->sess_ops->FirstBurstLength) ? conn->sess->sess_ops->FirstBurstLength) ?
conn->sess->sess_ops->FirstBurstLength : cmd->se_cmd.data_length); conn->sess->sess_ops->FirstBurstLength : cmd->se_cmd.data_length));
return; return;
} }
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment