Commit e1013f14 authored by Roland Dreier's avatar Roland Dreier Committed by Nicholas Bellinger
Browse files

qla2xxx: Remove racy, now-redundant check of sess_tearing_down

Now that target_submit_cmd() / target_get_sess_cmd() check
sess_tearing_down before adding commands to the list, we no longer
need the check in qlt_do_work().  In fact this check is racy anyway
(and that race is what inspired the change to add the check of
sess_tearing_down to the target core).

Cc: Chad Dupuis <>
Cc: Arun Easi <>
Signed-off-by: default avatarRoland Dreier <>
Signed-off-by: default avatarNicholas Bellinger <>
parent bc187ea6
......@@ -2643,19 +2643,9 @@ static void qlt_do_work(struct work_struct *work)
spin_lock_irqsave(&ha->hardware_lock, flags);
sess = ha->tgt.tgt_ops->find_sess_by_s_id(vha,
if (sess) {
if (unlikely(sess->se_sess->sess_tearing_down)) {
sess = NULL;
spin_unlock_irqrestore(&ha->hardware_lock, flags);
goto out_term;
} else {
* Do the extra kref_get() before dropping
* qla_hw_data->hardware_lock.
/* Do kref_get() before dropping qla_hw_data->hardware_lock. */
if (sess)
spin_unlock_irqrestore(&ha->hardware_lock, flags);
if (unlikely(!sess)) {
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment