1. 30 Apr, 2013 4 commits
  2. 17 Apr, 2013 1 commit
  3. 28 Feb, 2013 1 commit
  4. 22 Feb, 2013 5 commits
  5. 05 Feb, 2013 1 commit
  6. 21 Dec, 2012 1 commit
  7. 18 Dec, 2012 12 commits
  8. 09 Nov, 2012 1 commit
  9. 05 Oct, 2012 4 commits
  10. 21 Aug, 2012 1 commit
  11. 31 Jul, 2012 5 commits
  12. 01 Jun, 2012 2 commits
  13. 16 Apr, 2012 1 commit
  14. 23 Mar, 2012 1 commit
    • Josh Triplett's avatar
      checkpatch: check for quoted strings broken across lines · ca56dc09
      Josh Triplett authored
      
      
      checkpatch already makes an exception to the 80-column rule for quoted
      strings, and Documentation/CodingStyle recommends not splitting quoted
      strings across lines, because it breaks the ability to grep for the
      string.  Rather than just permitting this, actively warn about quoted
      strings split across lines.
      
      Test case:
      
      void context(void)
      {
      	struct { unsigned magic; const char *strdata; } foo[] = {
      		{ 42, "these strings"
      		      "do not produce warnings" },
      		{ 256, "though perhaps"
      		       "they should" },
      	};
      	pr_err("this string"
      	       " should produce a warning\n");
      	pr_err("this multi-line string\n"
      	       "should not produce a warning\n");
      	asm ("this asm\n\t"
      	     "should not produce a warning");
      }
      
      Results of checkpatch on that test case:
      
      WARNING: quoted string split across lines
      +	       " should produce a warning\n");
      
      total: 0 errors, 1 warnings, 15 lines checked
      Signed-off-by: default avatarJosh Triplett <josh@joshtriplett.org>
      Acked-by: default avatarJoe Perches <joe@perches.com>
      Cc: Andy Whitcroft <apw@canonical.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      ca56dc09