1. 11 Feb, 2010 1 commit
  2. 17 Nov, 2009 1 commit
  3. 02 Oct, 2009 1 commit
  4. 22 Jul, 2009 1 commit
  5. 15 Jul, 2009 1 commit
  6. 17 Jun, 2009 2 commits
  7. 12 Jun, 2009 1 commit
  8. 05 Feb, 2009 2 commits
  9. 15 Jan, 2009 1 commit
  10. 07 Jan, 2009 1 commit
  11. 04 Jan, 2009 1 commit
    • Julia Lawall's avatar
      ALSA: sound/usb: Use negated usb_endpoint_xfer_control, etc · 913ae5a2
      Julia Lawall authored
      This patch extends 42a6e66f by using
      usb_endpoint_xfer_control, usb_endpoint_xfer_isoc, usb_endpoint_xfer_bulk,
      and usb_endpoint_xfer_int in the negated case as well.
      
      This patch also rewrites some calls to usb_endpoint_dir_in as negated calls
      to !usb_endpoint_dir_out, and vice versa, to better correspond to the
      intent of the original code.
      
      The semantic patch that makes this change is as follows:
      (http://www.emn.fr/x-info/coccinelle/
      
      )
      
      // <smpl>
      @@ struct usb_endpoint_descriptor *epd; @@
      
      - (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_CONTROL\|0\))
      + !usb_endpoint_xfer_control(epd)
      
      @@ struct usb_endpoint_descriptor *epd; @@
      
      - (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_ISOC\|1\))
      + !usb_endpoint_xfer_isoc(epd)
      
      @@ struct usb_endpoint_descriptor *epd; @@
      
      - (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_BULK\|2\))
      + !usb_endpoint_xfer_bulk(epd)
      
      @@ struct usb_endpoint_descriptor *epd; @@
      
      - (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_INT\|3\))
      + !usb_endpoint_xfer_int(epd)
      // </smpl>
      Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      913ae5a2
  12. 01 Jan, 2009 1 commit
    • Julia Lawall's avatar
      ALSA: sound/usb: use USB API functions rather than constants · 42a6e66f
      Julia Lawall authored
      This set of patches introduces calls to the following set of functions:
      
      usb_endpoint_dir_in(epd)
      usb_endpoint_dir_out(epd)
      usb_endpoint_is_bulk_in(epd)
      usb_endpoint_is_bulk_out(epd)
      usb_endpoint_is_int_in(epd)
      usb_endpoint_is_int_out(epd)
      usb_endpoint_num(epd)
      usb_endpoint_type(epd)
      usb_endpoint_xfer_bulk(epd)
      usb_endpoint_xfer_control(epd)
      usb_endpoint_xfer_int(epd)
      usb_endpoint_xfer_isoc(epd)
      
      In some cases, introducing one of these functions is not possible, and it
      just replaces an explicit integer value by one of the following constants:
      
      USB_ENDPOINT_XFER_BULK
      USB_ENDPOINT_XFER_CONTROL
      USB_ENDPOINT_XFER_INT
      USB_ENDPOINT_XFER_ISOC
      
      An extract of the semantic patch that makes these changes is as follows:
      (http://www.emn.fr/x-info/coccinelle/
      
      )
      
      // <smpl>
      @r1@ struct usb_endpoint_descriptor *epd; @@
      
      - ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
      - \(USB_ENDPOINT_XFER_CONTROL\|0\))
      + usb_endpoint_xfer_control(epd)
      
      @r5@ struct usb_endpoint_descriptor *epd; @@
      
      - ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
      -  \(USB_DIR_IN\|0x80\))
      + usb_endpoint_dir_in(epd)
      
      @inc@
      @@
      
      #include <linux/usb.h>
      
      @depends on !inc && (r1||r5)@
      @@
      
      + #include <linux/usb.h>
        #include <linux/usb/...>
      // </smpl>
      Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      42a6e66f
  13. 15 Aug, 2008 1 commit
  14. 13 Aug, 2008 1 commit
  15. 06 Aug, 2008 1 commit
    • Phillip Michael Jordan's avatar
      ALSA: snd_usb_audio: fix SB Extigy IR Remote regression · b9c196e1
      Phillip Michael Jordan authored
      
      
      The support for the SB Extigy's remote seems to be broken in all
      recent ALSA versions, including 1.0.17. The driver detects the event
      correctly, then submits a URB to query the RC code. On the Extigy, the
      URB is submitted with a length of 2 bytes. My hardware, however, only
      replies with 1 byte, containing the correct RC button code. The
      current implementation discards this as being too short. (line 1784 of
      usbmixer.c)
      
      This patch specifies a "minimum packet length" in the remote control
      configuration. I've left the values for the Audigy 2/Live! the same as
      the packet length, as I'm assuming the existing code works with them.
      (I don't have the hardware to confirm) This fixes the Extigy RC
      support, e.g. for use with Lirc.
      Signed-off-by: default avatarPhillip Michael Jordan <phil@philjordan.eu>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
      b9c196e1
  16. 31 Jan, 2008 2 commits
  17. 16 Oct, 2007 2 commits
  18. 16 May, 2007 1 commit
  19. 09 Jan, 2007 1 commit
  20. 01 Dec, 2006 1 commit
  21. 05 Oct, 2006 1 commit
    • David Howells's avatar
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells authored
      
      
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: default avatarDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  22. 23 Sep, 2006 1 commit
  23. 22 Jun, 2006 2 commits
  24. 31 Mar, 2006 1 commit
  25. 22 Mar, 2006 2 commits
  26. 03 Jan, 2006 1 commit
  27. 04 Nov, 2005 1 commit
  28. 12 Sep, 2005 1 commit
    • Takashi Iwai's avatar
      [ALSA] Replace with kzalloc() - others · 561b220a
      Takashi Iwai authored
      
      
      Documentation,SA11xx UDA1341 driver,Generic drivers,MPU401 UART,OPL3
      OPL4,Digigram VX core,I2C cs8427,I2C lib core,I2C tea6330t,L3 drivers
      AK4114 receiver,AK4117 receiver,PDAudioCF driver,PPC PMAC driver
      SPARC AMD7930 driver,SPARC cs4231 driver,Synth,Common EMU synth
      USB generic driver,USB USX2Y
      Replace kcalloc(1,..) with kzalloc().
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      561b220a
  29. 27 Jul, 2005 1 commit
  30. 22 Jun, 2005 1 commit
    • Jesper Juhl's avatar
      [ALSA] Remove redundant NULL checks before kfree · 4d572776
      Jesper Juhl authored
      
      
      Timer Midlevel,ALSA sequencer,ALSA<-OSS sequencer,Digigram VX core
      I2C tea6330t,GUS Library,VIA82xx driver,VIA82xx-modem driver
      CA0106 driver,CS46xx driver,EMU10K1/EMU10K2 driver,YMFPCI driver
      Digigram VX Pocket driver,Common EMU synth,USB generic driver,USB USX2Y
      Checking a pointer for NULL before calling kfree() on it is redundant,
      kfree() deals with NULL pointers just fine.
      This patch removes such checks from sound/
      
      This patch also makes another, but closely related, change.
      It avoids casting pointers about to be kfree()'ed.
      Signed-off-by: default avatarJesper Juhl <juhl-lkml@dif.dk>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      4d572776
  31. 29 May, 2005 4 commits