nouveau_connector.c 35.1 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
/*
 * Copyright (C) 2008 Maarten Maathuis.
 * All Rights Reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining
 * a copy of this software and associated documentation files (the
 * "Software"), to deal in the Software without restriction, including
 * without limitation the rights to use, copy, modify, merge, publish,
 * distribute, sublicense, and/or sell copies of the Software, and to
 * permit persons to whom the Software is furnished to do so, subject to
 * the following conditions:
 *
 * The above copyright notice and this permission notice (including the
 * next paragraph) shall be included in all copies or substantial
 * portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
 * IN NO EVENT SHALL THE COPYRIGHT OWNER(S) AND/OR ITS SUPPLIERS BE
 * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 *
 */

27
28
#include <acpi/button.h>

29
30
#include <linux/pm_runtime.h>

31
32
33
#include <drm/drmP.h>
#include <drm/drm_edid.h>
#include <drm/drm_crtc_helper.h>
34

35
#include "nouveau_reg.h"
36
#include "nouveau_drm.h"
37
#include "dispnv04/hw.h"
38
#include "nouveau_acpi.h"
39

40
41
#include "nouveau_display.h"
#include "nouveau_connector.h"
42
43
#include "nouveau_encoder.h"
#include "nouveau_crtc.h"
44

45
46
#include <nvif/event.h>

47
48
49
50
51
52
53
54
55
56
57
MODULE_PARM_DESC(tv_disable, "Disable TV-out detection");
static int nouveau_tv_disable = 0;
module_param_named(tv_disable, nouveau_tv_disable, int, 0400);

MODULE_PARM_DESC(ignorelid, "Ignore ACPI lid status");
static int nouveau_ignorelid = 0;
module_param_named(ignorelid, nouveau_ignorelid, int, 0400);

MODULE_PARM_DESC(duallink, "Allow dual-link TMDS (default: enabled)");
static int nouveau_duallink = 1;
module_param_named(duallink, nouveau_duallink, int, 0400);
58

59
struct nouveau_encoder *
60
find_encoder(struct drm_connector *connector, int type)
61
62
63
{
	struct drm_device *dev = connector->dev;
	struct nouveau_encoder *nv_encoder;
Rob Clark's avatar
Rob Clark committed
64
	struct drm_encoder *enc;
65
66
67
68
69
70
71
	int i, id;

	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
		id = connector->encoder_ids[i];
		if (!id)
			break;

Rob Clark's avatar
Rob Clark committed
72
73
		enc = drm_encoder_find(dev, id);
		if (!enc)
74
			continue;
Rob Clark's avatar
Rob Clark committed
75
		nv_encoder = nouveau_encoder(enc);
76

77
78
		if (type == DCB_OUTPUT_ANY ||
		    (nv_encoder->dcb && nv_encoder->dcb->type == type))
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
			return nv_encoder;
	}

	return NULL;
}

struct nouveau_connector *
nouveau_encoder_connector_get(struct nouveau_encoder *encoder)
{
	struct drm_device *dev = to_drm_encoder(encoder)->dev;
	struct drm_connector *drm_connector;

	list_for_each_entry(drm_connector, &dev->mode_config.connector_list, head) {
		if (drm_connector->encoder == to_drm_encoder(encoder))
			return nouveau_connector(drm_connector);
	}

	return NULL;
}

static void
100
nouveau_connector_destroy(struct drm_connector *connector)
101
{
102
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
103
	nvif_notify_fini(&nv_connector->hpd);
104
	kfree(nv_connector->edid);
105
	drm_connector_unregister(connector);
106
	drm_connector_cleanup(connector);
107
108
	if (nv_connector->aux.transfer)
		drm_dp_aux_unregister(&nv_connector->aux);
109
	kfree(connector);
110
111
}

112
113
static struct nouveau_encoder *
nouveau_connector_ddc_detect(struct drm_connector *connector)
114
115
{
	struct drm_device *dev = connector->dev;
116
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
117
	struct nouveau_drm *drm = nouveau_drm(dev);
118
	struct nouveau_gpio *gpio = nvkm_gpio(&drm->device);
119
	struct nouveau_encoder *nv_encoder;
Rob Clark's avatar
Rob Clark committed
120
	struct drm_encoder *encoder;
121
122
123
124
125
126
127
128
129
130
131
132
133
	int i, panel = -ENODEV;

	/* eDP panels need powering on by us (if the VBIOS doesn't default it
	 * to on) before doing any AUX channel transactions.  LVDS panel power
	 * is handled by the SOR itself, and not required for LVDS DDC.
	 */
	if (nv_connector->type == DCB_CONNECTOR_eDP) {
		panel = gpio->get(gpio, 0, DCB_GPIO_PANEL_POWER, 0xff);
		if (panel == 0) {
			gpio->set(gpio, 0, DCB_GPIO_PANEL_POWER, 0xff, 1);
			msleep(300);
		}
	}
134

135
136
137
	for (i = 0; nv_encoder = NULL, i < DRM_CONNECTOR_MAX_ENCODER; i++) {
		int id = connector->encoder_ids[i];
		if (id == 0)
138
139
			break;

Rob Clark's avatar
Rob Clark committed
140
141
		encoder = drm_encoder_find(dev, id);
		if (!encoder)
142
			continue;
Rob Clark's avatar
Rob Clark committed
143
		nv_encoder = nouveau_encoder(encoder);
144

145
146
147
148
149
150
151
152
		if (nv_encoder->dcb->type == DCB_OUTPUT_DP) {
			int ret = nouveau_dp_detect(nv_encoder);
			if (ret == 0)
				break;
		} else
		if (nv_encoder->i2c) {
			if (nv_probe_i2c(nv_encoder->i2c, 0x50))
				break;
153
154
155
		}
	}

156
157
158
	/* eDP panel not detected, restore panel power GPIO to previous
	 * state to avoid confusing the SOR for other output types.
	 */
159
	if (!nv_encoder && panel == 0)
160
161
		gpio->set(gpio, 0, DCB_GPIO_PANEL_POWER, 0xff, panel);

162
	return nv_encoder;
163
164
}

165
166
167
168
169
170
171
172
173
174
static struct nouveau_encoder *
nouveau_connector_of_detect(struct drm_connector *connector)
{
#ifdef __powerpc__
	struct drm_device *dev = connector->dev;
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
	struct nouveau_encoder *nv_encoder;
	struct device_node *cn, *dn = pci_device_to_OF_node(dev->pdev);

	if (!dn ||
175
176
	    !((nv_encoder = find_encoder(connector, DCB_OUTPUT_TMDS)) ||
	      (nv_encoder = find_encoder(connector, DCB_OUTPUT_ANALOG))))
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
		return NULL;

	for_each_child_of_node(dn, cn) {
		const char *name = of_get_property(cn, "name", NULL);
		const void *edid = of_get_property(cn, "EDID", NULL);
		int idx = name ? name[strlen(name) - 1] - 'A' : 0;

		if (nv_encoder->dcb->i2c_index == idx && edid) {
			nv_connector->edid =
				kmemdup(edid, EDID_LENGTH, GFP_KERNEL);
			of_node_put(cn);
			return nv_encoder;
		}
	}
#endif
	return NULL;
}

195
196
197
198
199
static void
nouveau_connector_set_encoder(struct drm_connector *connector,
			      struct nouveau_encoder *nv_encoder)
{
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
200
	struct nouveau_drm *drm = nouveau_drm(connector->dev);
201
202
203
204
205
206
	struct drm_device *dev = connector->dev;

	if (nv_connector->detected_encoder == nv_encoder)
		return;
	nv_connector->detected_encoder = nv_encoder;

207
	if (drm->device.info.family >= NV_DEVICE_INFO_V0_TESLA) {
208
209
210
		connector->interlace_allowed = true;
		connector->doublescan_allowed = true;
	} else
211
212
	if (nv_encoder->dcb->type == DCB_OUTPUT_LVDS ||
	    nv_encoder->dcb->type == DCB_OUTPUT_TMDS) {
213
214
215
216
		connector->doublescan_allowed = false;
		connector->interlace_allowed = false;
	} else {
		connector->doublescan_allowed = true;
217
218
		if (drm->device.info.family == NV_DEVICE_INFO_V0_KELVIN ||
		    (drm->device.info.family == NV_DEVICE_INFO_V0_CELSIUS &&
219
220
		     (dev->pdev->device & 0x0ff0) != 0x0100 &&
		     (dev->pdev->device & 0x0ff0) != 0x0150))
221
222
223
224
225
226
			/* HW is broken */
			connector->interlace_allowed = false;
		else
			connector->interlace_allowed = true;
	}

227
	if (nv_connector->type == DCB_CONNECTOR_DVI_I) {
228
		drm_object_property_set_value(&connector->base,
229
			dev->mode_config.dvi_i_subconnector_property,
230
			nv_encoder->dcb->type == DCB_OUTPUT_TMDS ?
231
232
233
234
235
236
			DRM_MODE_SUBCONNECTOR_DVID :
			DRM_MODE_SUBCONNECTOR_DVIA);
	}
}

static enum drm_connector_status
237
nouveau_connector_detect(struct drm_connector *connector, bool force)
238
239
{
	struct drm_device *dev = connector->dev;
240
	struct nouveau_drm *drm = nouveau_drm(dev);
241
242
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
	struct nouveau_encoder *nv_encoder = NULL;
243
	struct nouveau_encoder *nv_partner;
244
	struct nouveau_i2c_port *i2c;
245
	int type;
246
247
	int ret;
	enum drm_connector_status conn_status = connector_status_disconnected;
248

249
250
251
252
253
254
	/* Cleanup the previous EDID block. */
	if (nv_connector->edid) {
		drm_mode_connector_update_edid_property(connector, NULL);
		kfree(nv_connector->edid);
		nv_connector->edid = NULL;
	}
255

256
	ret = pm_runtime_get_sync(connector->dev->dev);
257
	if (ret < 0 && ret != -EACCES)
258
259
		return conn_status;

260
261
	nv_encoder = nouveau_connector_ddc_detect(connector);
	if (nv_encoder && (i2c = nv_encoder->i2c) != NULL) {
262
263
264
265
		nv_connector->edid = drm_get_edid(connector, &i2c->adapter);
		drm_mode_connector_update_edid_property(connector,
							nv_connector->edid);
		if (!nv_connector->edid) {
266
			NV_ERROR(drm, "DDC responded, but no EDID for %s\n",
267
				 connector->name);
268
			goto detect_analog;
269
270
271
272
273
274
275
		}

		/* Override encoder type for DVI-I based on whether EDID
		 * says the display is digital or analog, both use the
		 * same i2c channel so the value returned from ddc_detect
		 * isn't necessarily correct.
		 */
276
		nv_partner = NULL;
277
278
279
280
281
282
283
284
285
		if (nv_encoder->dcb->type == DCB_OUTPUT_TMDS)
			nv_partner = find_encoder(connector, DCB_OUTPUT_ANALOG);
		if (nv_encoder->dcb->type == DCB_OUTPUT_ANALOG)
			nv_partner = find_encoder(connector, DCB_OUTPUT_TMDS);

		if (nv_partner && ((nv_encoder->dcb->type == DCB_OUTPUT_ANALOG &&
				    nv_partner->dcb->type == DCB_OUTPUT_TMDS) ||
				   (nv_encoder->dcb->type == DCB_OUTPUT_TMDS &&
				    nv_partner->dcb->type == DCB_OUTPUT_ANALOG))) {
286
			if (nv_connector->edid->input & DRM_EDID_INPUT_DIGITAL)
287
				type = DCB_OUTPUT_TMDS;
288
			else
289
				type = DCB_OUTPUT_ANALOG;
290

291
			nv_encoder = find_encoder(connector, type);
292
293
294
		}

		nouveau_connector_set_encoder(connector, nv_encoder);
295
296
		conn_status = connector_status_connected;
		goto out;
297
298
	}

299
300
301
	nv_encoder = nouveau_connector_of_detect(connector);
	if (nv_encoder) {
		nouveau_connector_set_encoder(connector, nv_encoder);
302
303
		conn_status = connector_status_connected;
		goto out;
304
305
	}

306
detect_analog:
307
	nv_encoder = find_encoder(connector, DCB_OUTPUT_ANALOG);
308
	if (!nv_encoder && !nouveau_tv_disable)
309
		nv_encoder = find_encoder(connector, DCB_OUTPUT_TV);
310
	if (nv_encoder && force) {
311
312
313
314
315
316
317
		struct drm_encoder *encoder = to_drm_encoder(nv_encoder);
		struct drm_encoder_helper_funcs *helper =
						encoder->helper_private;

		if (helper->detect(encoder, connector) ==
						connector_status_connected) {
			nouveau_connector_set_encoder(connector, nv_encoder);
318
319
			conn_status = connector_status_connected;
			goto out;
320
321
322
323
		}

	}

324
325
326
327
328
329
 out:

	pm_runtime_mark_last_busy(connector->dev->dev);
	pm_runtime_put_autosuspend(connector->dev->dev);

	return conn_status;
330
331
}

332
static enum drm_connector_status
333
nouveau_connector_detect_lvds(struct drm_connector *connector, bool force)
334
335
{
	struct drm_device *dev = connector->dev;
336
	struct nouveau_drm *drm = nouveau_drm(dev);
337
338
339
340
341
342
343
344
345
346
347
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
	struct nouveau_encoder *nv_encoder = NULL;
	enum drm_connector_status status = connector_status_disconnected;

	/* Cleanup the previous EDID block. */
	if (nv_connector->edid) {
		drm_mode_connector_update_edid_property(connector, NULL);
		kfree(nv_connector->edid);
		nv_connector->edid = NULL;
	}

348
	nv_encoder = find_encoder(connector, DCB_OUTPUT_LVDS);
349
350
351
	if (!nv_encoder)
		return connector_status_disconnected;

352
	/* Try retrieving EDID via DDC */
353
	if (!drm->vbios.fp_no_ddc) {
354
		status = nouveau_connector_detect(connector, force);
355
356
357
358
		if (status == connector_status_connected)
			goto out;
	}

359
360
361
362
363
364
365
366
367
368
	/* On some laptops (Sony, i'm looking at you) there appears to
	 * be no direct way of accessing the panel's EDID.  The only
	 * option available to us appears to be to ask ACPI for help..
	 *
	 * It's important this check's before trying straps, one of the
	 * said manufacturer's laptops are configured in such a way
	 * the nouveau decides an entry in the VBIOS FP mode table is
	 * valid - it's not (rh#613284)
	 */
	if (nv_encoder->dcb->lvdsconf.use_acpi_for_edid) {
369
		if ((nv_connector->edid = nouveau_acpi_edid(dev, connector))) {
370
371
372
373
374
			status = connector_status_connected;
			goto out;
		}
	}

375
376
377
378
	/* If no EDID found above, and the VBIOS indicates a hardcoded
	 * modeline is avalilable for the panel, set it as the panel's
	 * native mode and exit.
	 */
379
	if (nouveau_bios_fp_mode(dev, NULL) && (drm->vbios.fp_no_ddc ||
380
381
382
383
384
385
386
387
	    nv_encoder->dcb->lvdsconf.use_straps_for_mode)) {
		status = connector_status_connected;
		goto out;
	}

	/* Still nothing, some VBIOS images have a hardcoded EDID block
	 * stored for the panel stored in them.
	 */
388
	if (!drm->vbios.fp_no_ddc) {
389
390
391
		struct edid *edid =
			(struct edid *)nouveau_bios_embedded_edid(dev);
		if (edid) {
392
393
394
395
			nv_connector->edid =
					kmemdup(edid, EDID_LENGTH, GFP_KERNEL);
			if (nv_connector->edid)
				status = connector_status_connected;
396
397
398
399
400
401
402
403
404
405
406
407
		}
	}

out:
#if defined(CONFIG_ACPI_BUTTON) || \
	(defined(CONFIG_ACPI_BUTTON_MODULE) && defined(MODULE))
	if (status == connector_status_connected &&
	    !nouveau_ignorelid && !acpi_lid_open())
		status = connector_status_unknown;
#endif

	drm_mode_connector_update_edid_property(connector, nv_connector->edid);
408
	nouveau_connector_set_encoder(connector, nv_encoder);
409
410
411
	return status;
}

412
413
414
static void
nouveau_connector_force(struct drm_connector *connector)
{
415
	struct nouveau_drm *drm = nouveau_drm(connector->dev);
416
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
417
418
419
	struct nouveau_encoder *nv_encoder;
	int type;

420
	if (nv_connector->type == DCB_CONNECTOR_DVI_I) {
421
		if (connector->force == DRM_FORCE_ON_DIGITAL)
422
			type = DCB_OUTPUT_TMDS;
423
		else
424
			type = DCB_OUTPUT_ANALOG;
425
	} else
426
		type = DCB_OUTPUT_ANY;
427

428
	nv_encoder = find_encoder(connector, type);
429
	if (!nv_encoder) {
430
		NV_ERROR(drm, "can't find encoder to force %s on!\n",
431
			 connector->name);
432
433
434
435
436
437
438
439
440
441
442
		connector->status = connector_status_disconnected;
		return;
	}

	nouveau_connector_set_encoder(connector, nv_encoder);
}

static int
nouveau_connector_set_property(struct drm_connector *connector,
			       struct drm_property *property, uint64_t value)
{
443
	struct nouveau_display *disp = nouveau_display(connector->dev);
444
445
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
	struct nouveau_encoder *nv_encoder = nv_connector->detected_encoder;
446
	struct drm_encoder *encoder = to_drm_encoder(nv_encoder);
447
	struct drm_device *dev = connector->dev;
448
	struct nouveau_crtc *nv_crtc;
449
450
	int ret;

451
452
453
454
	nv_crtc = NULL;
	if (connector->encoder && connector->encoder->crtc)
		nv_crtc = nouveau_crtc(connector->encoder->crtc);

455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
	/* Scaling mode */
	if (property == dev->mode_config.scaling_mode_property) {
		bool modeset = false;

		switch (value) {
		case DRM_MODE_SCALE_NONE:
		case DRM_MODE_SCALE_FULLSCREEN:
		case DRM_MODE_SCALE_CENTER:
		case DRM_MODE_SCALE_ASPECT:
			break;
		default:
			return -EINVAL;
		}

		/* LVDS always needs gpu scaling */
470
		if (connector->connector_type == DRM_MODE_CONNECTOR_LVDS &&
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
		    value == DRM_MODE_SCALE_NONE)
			return -EINVAL;

		/* Changing between GPU and panel scaling requires a full
		 * modeset
		 */
		if ((nv_connector->scaling_mode == DRM_MODE_SCALE_NONE) ||
		    (value == DRM_MODE_SCALE_NONE))
			modeset = true;
		nv_connector->scaling_mode = value;

		if (!nv_crtc)
			return 0;

		if (modeset || !nv_crtc->set_scale) {
			ret = drm_crtc_helper_set_mode(&nv_crtc->base,
							&nv_crtc->base.mode,
							nv_crtc->base.x,
							nv_crtc->base.y, NULL);
			if (!ret)
				return -EINVAL;
		} else {
493
			ret = nv_crtc->set_scale(nv_crtc, true);
494
495
496
497
498
499
500
			if (ret)
				return ret;
		}

		return 0;
	}

501
502
503
504
505
506
507
	/* Underscan */
	if (property == disp->underscan_property) {
		if (nv_connector->underscan != value) {
			nv_connector->underscan = value;
			if (!nv_crtc || !nv_crtc->set_scale)
				return 0;

508
			return nv_crtc->set_scale(nv_crtc, true);
509
510
511
512
513
514
515
516
517
518
519
		}

		return 0;
	}

	if (property == disp->underscan_hborder_property) {
		if (nv_connector->underscan_hborder != value) {
			nv_connector->underscan_hborder = value;
			if (!nv_crtc || !nv_crtc->set_scale)
				return 0;

520
			return nv_crtc->set_scale(nv_crtc, true);
521
522
523
524
525
526
527
528
529
530
531
		}

		return 0;
	}

	if (property == disp->underscan_vborder_property) {
		if (nv_connector->underscan_vborder != value) {
			nv_connector->underscan_vborder = value;
			if (!nv_crtc || !nv_crtc->set_scale)
				return 0;

532
			return nv_crtc->set_scale(nv_crtc, true);
533
534
535
536
537
		}

		return 0;
	}

538
	/* Dithering */
539
540
541
542
543
544
545
	if (property == disp->dithering_mode) {
		nv_connector->dithering_mode = value;
		if (!nv_crtc || !nv_crtc->set_dither)
			return 0;

		return nv_crtc->set_dither(nv_crtc, true);
	}
546

547
548
	if (property == disp->dithering_depth) {
		nv_connector->dithering_depth = value;
549
550
551
		if (!nv_crtc || !nv_crtc->set_dither)
			return 0;

552
		return nv_crtc->set_dither(nv_crtc, true);
553
554
	}

555
556
557
558
559
560
561
562
563
564
565
566
567
	if (nv_crtc && nv_crtc->set_color_vibrance) {
		/* Hue */
		if (property == disp->vibrant_hue_property) {
			nv_crtc->vibrant_hue = value - 90;
			return nv_crtc->set_color_vibrance(nv_crtc, true);
		}
		/* Saturation */
		if (property == disp->color_vibrance_property) {
			nv_crtc->color_vibrance = value - 100;
			return nv_crtc->set_color_vibrance(nv_crtc, true);
		}
	}

568
	if (nv_encoder && nv_encoder->dcb->type == DCB_OUTPUT_TV)
569
570
		return get_slave_funcs(encoder)->set_property(
			encoder, connector, property, value);
571
572
573
574
575

	return -EINVAL;
}

static struct drm_display_mode *
576
nouveau_connector_native_mode(struct drm_connector *connector)
577
{
578
	struct drm_connector_helper_funcs *helper = connector->helper_private;
579
	struct nouveau_drm *drm = nouveau_drm(connector->dev);
580
581
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
	struct drm_device *dev = connector->dev;
582
583
584
	struct drm_display_mode *mode, *largest = NULL;
	int high_w = 0, high_h = 0, high_v = 0;

585
	list_for_each_entry(mode, &nv_connector->base.probed_modes, head) {
586
		mode->vrefresh = drm_mode_vrefresh(mode);
587
588
		if (helper->mode_valid(connector, mode) != MODE_OK ||
		    (mode->flags & DRM_MODE_FLAG_INTERLACE))
589
590
591
			continue;

		/* Use preferred mode if there is one.. */
592
		if (mode->type & DRM_MODE_TYPE_PREFERRED) {
593
			NV_DEBUG(drm, "native mode from preferred\n");
594
595
596
			return drm_mode_duplicate(dev, mode);
		}

597
598
599
		/* Otherwise, take the resolution with the largest width, then
		 * height, then vertical refresh
		 */
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
		if (mode->hdisplay < high_w)
			continue;

		if (mode->hdisplay == high_w && mode->vdisplay < high_h)
			continue;

		if (mode->hdisplay == high_w && mode->vdisplay == high_h &&
		    mode->vrefresh < high_v)
			continue;

		high_w = mode->hdisplay;
		high_h = mode->vdisplay;
		high_v = mode->vrefresh;
		largest = mode;
	}

616
	NV_DEBUG(drm, "native mode from largest: %dx%d@%d\n",
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
		      high_w, high_h, high_v);
	return largest ? drm_mode_duplicate(dev, largest) : NULL;
}

struct moderec {
	int hdisplay;
	int vdisplay;
};

static struct moderec scaler_modes[] = {
	{ 1920, 1200 },
	{ 1920, 1080 },
	{ 1680, 1050 },
	{ 1600, 1200 },
	{ 1400, 1050 },
	{ 1280, 1024 },
	{ 1280, 960 },
	{ 1152, 864 },
	{ 1024, 768 },
	{ 800, 600 },
	{ 720, 400 },
	{ 640, 480 },
	{ 640, 400 },
	{ 640, 350 },
	{}
};

static int
nouveau_connector_scaler_modes_add(struct drm_connector *connector)
{
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
	struct drm_display_mode *native = nv_connector->native_mode, *m;
	struct drm_device *dev = connector->dev;
	struct moderec *mode = &scaler_modes[0];
	int modes = 0;

	if (!native)
		return 0;

	while (mode->hdisplay) {
		if (mode->hdisplay <= native->hdisplay &&
		    mode->vdisplay <= native->vdisplay) {
			m = drm_cvt_mode(dev, mode->hdisplay, mode->vdisplay,
					 drm_mode_vrefresh(native), false,
					 false, false);
			if (!m)
				continue;

			m->type |= DRM_MODE_TYPE_DRIVER;

			drm_mode_probed_add(connector, m);
			modes++;
		}

		mode++;
	}

	return modes;
}

677
678
679
static void
nouveau_connector_detect_depth(struct drm_connector *connector)
{
680
	struct nouveau_drm *drm = nouveau_drm(connector->dev);
681
682
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
	struct nouveau_encoder *nv_encoder = nv_connector->detected_encoder;
683
	struct nvbios *bios = &drm->vbios;
684
685
686
687
688
689
690
	struct drm_display_mode *mode = nv_connector->native_mode;
	bool duallink;

	/* if the edid is feeling nice enough to provide this info, use it */
	if (nv_connector->edid && connector->display_info.bpc)
		return;

691
692
693
694
695
696
697
	/* EDID 1.4 is *supposed* to be supported on eDP, but, Apple... */
	if (nv_connector->type == DCB_CONNECTOR_eDP) {
		connector->display_info.bpc = 6;
		return;
	}

	/* we're out of options unless we're LVDS, default to 8bpc */
698
	if (nv_encoder->dcb->type != DCB_OUTPUT_LVDS) {
699
		connector->display_info.bpc = 8;
700
		return;
701
702
703
	}

	connector->display_info.bpc = 6;
704
705
706
707
708
709
710
711
712
713
714
715

	/* LVDS: panel straps */
	if (bios->fp_no_ddc) {
		if (bios->fp.if_is_24bit)
			connector->display_info.bpc = 8;
		return;
	}

	/* LVDS: DDC panel, need to first determine the number of links to
	 * know which if_is_24bit flag to check...
	 */
	if (nv_connector->edid &&
716
	    nv_connector->type == DCB_CONNECTOR_LVDS_SPWG)
717
718
719
720
721
722
723
724
725
		duallink = ((u8 *)nv_connector->edid)[121] == 2;
	else
		duallink = mode->clock >= bios->fp.duallink_transition_clk;

	if ((!duallink && (bios->fp.strapless_is_24bit & 1)) ||
	    ( duallink && (bios->fp.strapless_is_24bit & 2)))
		connector->display_info.bpc = 8;
}

726
727
728
729
static int
nouveau_connector_get_modes(struct drm_connector *connector)
{
	struct drm_device *dev = connector->dev;
730
	struct nouveau_drm *drm = nouveau_drm(dev);
731
732
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
	struct nouveau_encoder *nv_encoder = nv_connector->detected_encoder;
733
	struct drm_encoder *encoder = to_drm_encoder(nv_encoder);
734
735
	int ret = 0;

736
	/* destroy the native mode, the attached monitor could have changed.
737
	 */
738
	if (nv_connector->native_mode) {
739
740
741
742
743
744
		drm_mode_destroy(dev, nv_connector->native_mode);
		nv_connector->native_mode = NULL;
	}

	if (nv_connector->edid)
		ret = drm_add_edid_modes(connector, nv_connector->edid);
745
	else
746
	if (nv_encoder->dcb->type == DCB_OUTPUT_LVDS &&
747
	    (nv_encoder->dcb->lvdsconf.use_straps_for_mode ||
748
	     drm->vbios.fp_no_ddc) && nouveau_bios_fp_mode(dev, NULL)) {
749
750
751
752
		struct drm_display_mode mode;

		nouveau_bios_fp_mode(dev, &mode);
		nv_connector->native_mode = drm_mode_duplicate(dev, &mode);
753
	}
754

755
756
757
758
759
760
	/* Determine display colour depth for everything except LVDS now,
	 * DP requires this before mode_valid() is called.
	 */
	if (connector->connector_type != DRM_MODE_CONNECTOR_LVDS)
		nouveau_connector_detect_depth(connector);

761
762
763
764
765
766
	/* Find the native mode if this is a digital panel, if we didn't
	 * find any modes through DDC previously add the native mode to
	 * the list of modes.
	 */
	if (!nv_connector->native_mode)
		nv_connector->native_mode =
767
			nouveau_connector_native_mode(connector);
768
769
770
771
772
773
774
775
	if (ret == 0 && nv_connector->native_mode) {
		struct drm_display_mode *mode;

		mode = drm_mode_duplicate(dev, nv_connector->native_mode);
		drm_mode_probed_add(connector, mode);
		ret = 1;
	}

776
777
778
	/* Determine LVDS colour depth, must happen after determining
	 * "native" mode as some VBIOS tables require us to use the
	 * pixel clock as part of the lookup...
779
	 */
780
781
	if (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)
		nouveau_connector_detect_depth(connector);
782

783
	if (nv_encoder->dcb->type == DCB_OUTPUT_TV)
784
		ret = get_slave_funcs(encoder)->get_modes(encoder, connector);
785

786
787
788
	if (nv_connector->type == DCB_CONNECTOR_LVDS ||
	    nv_connector->type == DCB_CONNECTOR_LVDS_SPWG ||
	    nv_connector->type == DCB_CONNECTOR_eDP)
789
790
791
792
793
		ret += nouveau_connector_scaler_modes_add(connector);

	return ret;
}

794
795
796
797
static unsigned
get_tmds_link_bandwidth(struct drm_connector *connector)
{
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
798
	struct nouveau_drm *drm = nouveau_drm(connector->dev);
799
	struct dcb_output *dcb = nv_connector->detected_encoder->dcb;
800
801

	if (dcb->location != DCB_LOC_ON_CHIP ||
802
	    drm->device.info.chipset >= 0x46)
803
		return 165000;
804
	else if (drm->device.info.chipset >= 0x40)
805
		return 155000;
806
	else if (drm->device.info.chipset >= 0x18)
807
808
809
810
811
		return 135000;
	else
		return 112000;
}

812
813
814
815
816
817
static int
nouveau_connector_mode_valid(struct drm_connector *connector,
			     struct drm_display_mode *mode)
{
	struct nouveau_connector *nv_connector = nouveau_connector(connector);
	struct nouveau_encoder *nv_encoder = nv_connector->detected_encoder;
818
	struct drm_encoder *encoder = to_drm_encoder(nv_encoder);
819
820
821
822
	unsigned min_clock = 25000, max_clock = min_clock;
	unsigned clock = mode->clock;

	switch (nv_encoder->dcb->type) {
823
	case DCB_OUTPUT_LVDS:
824
825
826
		if (nv_connector->native_mode &&
		    (mode->hdisplay > nv_connector->native_mode->hdisplay ||
		     mode->vdisplay > nv_connector->native_mode->vdisplay))
827
828
829
830
831
			return MODE_PANEL;

		min_clock = 0;
		max_clock = 400000;
		break;
832
	case DCB_OUTPUT_TMDS:
833
834
835
		max_clock = get_tmds_link_bandwidth(connector);
		if (nouveau_duallink && nv_encoder->dcb->duallink_possible)
			max_clock *= 2;
836
		break;
837
	case DCB_OUTPUT_ANALOG:
838
839
840
841
		max_clock = nv_encoder->dcb->crtconf.maxfreq;
		if (!max_clock)
			max_clock = 350000;
		break;
842
	case DCB_OUTPUT_TV:
843
		return get_slave_funcs(encoder)->mode_valid(encoder, mode);
844
	case DCB_OUTPUT_DP:
845
846
		max_clock  = nv_encoder->dp.link_nr;
		max_clock *= nv_encoder->dp.link_bw;
847
		clock = clock * (connector->display_info.bpc * 3) / 10;
848
		break;
849
850
851
	default:
		BUG_ON(1);
		return MODE_BAD;
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
	}

	if (clock < min_clock)
		return MODE_CLOCK_LOW;

	if (clock > max_clock)
		return MODE_CLOCK_HIGH;

	return MODE_OK;
}

static struct drm_encoder *
nouveau_connector_best_encoder(struct drm_connector *connector)
{
	struct nouveau_connector *nv_connector = nouveau_connector(connector);

	if (nv_connector->detected_encoder)
		return to_drm_encoder(nv_connector->detected_encoder);

	return NULL;
}

static const struct drm_connector_helper_funcs
nouveau_connector_helper_funcs = {
	.get_modes = nouveau_connector_get_modes,
	.mode_valid = nouveau_connector_mode_valid,
	.best_encoder = nouveau_connector_best_encoder,
};

static const struct drm_connector_funcs
nouveau_connector_funcs = {
	.dpms = drm_helper_connector_dpms,
	.save = NULL,
	.restore = NULL,
	.detect = nouveau_connector_detect,
	.destroy = nouveau_connector_destroy,
	.fill_modes = drm_helper_probe_single_connector_modes,
	.set_property = nouveau_connector_set_property,
	.force = nouveau_connector_force
};

893
894
895
896
897
898
899
900
901
902
903
static const struct drm_connector_funcs
nouveau_connector_funcs_lvds = {
	.dpms = drm_helper_connector_dpms,
	.save = NULL,
	.restore = NULL,
	.detect = nouveau_connector_detect_lvds,
	.destroy = nouveau_connector_destroy,
	.fill_modes = drm_helper_probe_single_connector_modes,
	.set_property = nouveau_connector_set_property,
	.force = nouveau_connector_force
};
904

905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
static void
nouveau_connector_dp_dpms(struct drm_connector *connector, int mode)
{
	struct nouveau_encoder *nv_encoder = NULL;

	if (connector->encoder)
		nv_encoder = nouveau_encoder(connector->encoder);
	if (nv_encoder && nv_encoder->dcb &&
	    nv_encoder->dcb->type == DCB_OUTPUT_DP) {
		if (mode == DRM_MODE_DPMS_ON) {
			u8 data = DP_SET_POWER_D0;
			nv_wraux(nv_encoder->i2c, DP_SET_POWER, &data, 1);
			usleep_range(1000, 2000);
		} else {
			u8 data = DP_SET_POWER_D3;
			nv_wraux(nv_encoder->i2c, DP_SET_POWER, &data, 1);
		}
	}

	drm_helper_connector_dpms(connector, mode);
}

static const struct drm_connector_funcs
nouveau_connector_funcs_dp = {
	.dpms = nouveau_connector_dp_dpms,
	.save = NULL,
	.restore = NULL,
	.detect = nouveau_connector_detect,
	.destroy = nouveau_connector_destroy,
	.fill_modes = drm_helper_probe_single_connector_modes,
	.set_property = nouveau_connector_set_property,
	.force = nouveau_connector_force
};

939
static int
940
nouveau_connector_hotplug(struct nvif_notify *notify)
941
942
{
	struct nouveau_connector *nv_connector =
943
		container_of(notify, typeof(*nv_connector), hpd);
944
	struct drm_connector *connector = &nv_connector->base;
945
	struct nouveau_drm *drm = nouveau_drm(connector->dev);
946
	const struct nvif_notify_conn_rep_v0 *rep = notify->data;
947
	const char *name = connector->name;
948

949
	if (rep->mask & NVIF_NOTIFY_CONN_V0_IRQ) {
950
	} else {
951
		bool plugged = (rep->mask != NVIF_NOTIFY_CONN_V0_UNPLUG);
952

953
		NV_DEBUG(drm, "%splugged %s\n", plugged ? "" : "un", name);
954

955
956
957
958
959
960
961
		if (plugged)
			drm_helper_connector_dpms(connector, DRM_MODE_DPMS_ON);
		else
			drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF);
		drm_helper_hpd_irq_event(connector->dev);
	}

962
	return NVIF_NOTIFY_KEEP;
963
964
}

965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
static ssize_t
nouveau_connector_aux_xfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
{
	struct nouveau_connector *nv_connector =
		container_of(aux, typeof(*nv_connector), aux);
	struct nouveau_encoder *nv_encoder;
	struct nouveau_i2c_port *port;
	int ret;

	nv_encoder = find_encoder(&nv_connector->base, DCB_OUTPUT_DP);
	if (!nv_encoder || !(port = nv_encoder->i2c))
		return -ENODEV;
	if (WARN_ON(msg->size > 16))
		return -E2BIG;
	if (msg->size == 0)
		return msg->size;

	ret = nouveau_i2c(port)->acquire(port, 0);
	if (ret)
		return ret;

	ret = port->func->aux(port, false, msg->request, msg->address,
			      msg->buffer, msg->size);
	nouveau_i2c(port)->release(port);
	if (ret >= 0) {
		msg->reply = ret;
		return msg->size;
	}

	return ret;
}

997
998
999
1000
1001
1002
1003
1004
static int
drm_conntype_from_dcb(enum dcb_connector_type dcb)
{
	switch (dcb) {
	case DCB_CONNECTOR_VGA      : return DRM_MODE_CONNECTOR_VGA;
	case DCB_CONNECTOR_TV_0     :
	case DCB_CONNECTOR_TV_1     :
	case DCB_CONNECTOR_TV_3     : return DRM_MODE_CONNECTOR_TV;
1005
1006
	case DCB_CONNECTOR_DMS59_0  :
	case DCB_CONNECTOR_DMS59_1  :
1007
1008
1009
1010
	case DCB_CONNECTOR_DVI_I    : return DRM_MODE_CONNECTOR_DVII;
	case DCB_CONNECTOR_DVI_D    : return DRM_MODE_CONNECTOR_DVID;
	case DCB_CONNECTOR_LVDS     :
	case DCB_CONNECTOR_LVDS_SPWG: return DRM_MODE_CONNECTOR_LVDS;
1011
1012
	case DCB_CONNECTOR_DMS59_DP0:
	case DCB_CONNECTOR_DMS59_DP1:
1013
1014
1015
	case DCB_CONNECTOR_DP       : return DRM_MODE_CONNECTOR_DisplayPort;
	case DCB_CONNECTOR_eDP      : return DRM_MODE_CONNECTOR_eDP;
	case DCB_CONNECTOR_HDMI_0   :
1016
1017
	case DCB_CONNECTOR_HDMI_1   :
	case DCB_CONNECTOR_HDMI_C   : return DRM_MODE_CONNECTOR_HDMIA;
1018
1019
1020
1021
1022
1023
1024
	default:
		break;
	}

	return DRM_MODE_CONNECTOR_Unknown;
}

1025
1026
struct drm_connector *
nouveau_connector_create(struct drm_device *dev, int index)
1027
{
1028
	const struct drm_connector_funcs *funcs = &nouveau_connector_funcs;
1029
1030
	struct nouveau_drm *drm = nouveau_drm(dev);
	struct nouveau_display *disp = nouveau_display(dev);
1031
1032
	struct nouveau_connector *nv_connector = NULL;
	struct drm_connector *connector;
1033
	int type, ret = 0;
1034
	bool dummy;
1035

1036
1037
1038
1039
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
		nv_connector = nouveau_connector(connector);
		if (nv_connector->index == index)
			return connector;
1040
1041
	}

1042
1043
	nv_connector = kzalloc(sizeof(*nv_connector), GFP_KERNEL);
	if (!nv_connector)
1044
		return ERR_PTR(-ENOMEM);
1045

1046
	connector = &nv_connector->base;
1047
1048
1049
	nv_connector->index = index;

	/* attempt to parse vbios connector type and hotplug gpio */
1050
	nv_connector->dcb = olddcb_conn(dev, index);
1051
1052
	if (nv_connector->dcb) {
		u32 entry = ROM16(nv_connector->dcb[0]);
1053
		if (olddcb_conntab(dev)[3] >= 4)
1054
1055
1056
1057
1058
			entry |= (u32)ROM16(nv_connector->dcb[2]) << 16;

		nv_connector->type = nv_connector->dcb[0];
		if (drm_conntype_from_dcb(nv_connector->type) ==
					  DRM_MODE_CONNECTOR_Unknown) {
1059
			NV_WARN(drm, "unknown connector type %02x\n",
1060
1061
1062
				nv_connector->type);
			nv_connector->type = DCB_CONNECTOR_NONE;
		}
1063

1064
1065
1066
1067
1068
		/* Gigabyte NX85T */
		if (nv_match_device(dev, 0x0421, 0x1458, 0x344c)) {
			if (nv_connector->type == DCB_CONNECTOR_HDMI_1)
				nv_connector->type = DCB_CONNECTOR_DVI_I;
		}
1069

1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
		/* Gigabyte GV-NX86T512H */
		if (nv_match_device(dev, 0x0402, 0x1458, 0x3455)) {
			if (nv_connector->type == DCB_CONNECTOR_HDMI_1)
				nv_connector->type = DCB_CONNECTOR_DVI_I;
		}
	} else {
		nv_connector->type = DCB_CONNECTOR_NONE;
	}

	/* no vbios data, or an unknown dcb connector type - attempt to
	 * figure out something suitable ourselves
	 */
	if (nv_connector->type == DCB_CONNECTOR_NONE) {
1083
1084
		struct nouveau_drm *drm = nouveau_drm(dev);
		struct dcb_table *dcbt = &drm->vbios.dcb;
1085
1086
1087
1088
1089
1090
1091
		u32 encoders = 0;
		int i;

		for (i = 0; i < dcbt->entries; i++) {
			if (dcbt->entry[i].connector == nv_connector->index)
				encoders |= (1 << dcbt->entry[i].type);
		}
1092

1093
1094
		if (encoders & (1 << DCB_OUTPUT_DP)) {
			if (encoders & (1 << DCB_OUTPUT_TMDS))
1095
1096
1097
1098
				nv_connector->type = DCB_CONNECTOR_DP;
			else
				nv_connector->type = DCB_CONNECTOR_eDP;
		} else
1099
1100
		if (encoders & (1 << DCB_OUTPUT_TMDS)) {
			if (encoders & (1 << DCB_OUTPUT_ANALOG))
1101
1102
1103
1104
				nv_connector->type = DCB_CONNECTOR_DVI_I;
			else
				nv_connector->type = DCB_CONNECTOR_DVI_D;
		} else
1105
		if (encoders & (1 << DCB_OUTPUT_ANALOG)) {
1106
1107
			nv_connector->type = DCB_CONNECTOR_VGA;
		} else
1108
		if (encoders & (1 << DCB_OUTPUT_LVDS)) {
1109
1110
			nv_connector->type = DCB_CONNECTOR_LVDS;
		} else
1111
		if (encoders & (1 << DCB_OUTPUT_TV)) {
1112
1113
1114
			nv_connector->type = DCB_CONNECTOR_TV_0;
		}
	}
1115

1116
1117
	switch ((type = drm_conntype_from_dcb(nv_connector->type))) {
	case DRM_MODE_CONNECTOR_LVDS:
1118
		ret = nouveau_bios_parse_lvds_table(dev, 0, &dummy, &dummy);
1119
		if (ret) {
1120
			NV_ERROR(drm, "Error parsing LVDS table, disabling\n");
1121
1122
			kfree(nv_connector);
			return ERR_PTR(ret);
1123
		}
1124
1125

		funcs = &nouveau_connector_funcs_lvds;
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
		break;
	case DRM_MODE_CONNECTOR_DisplayPort:
	case DRM_MODE_CONNECTOR_eDP:
		nv_connector->aux.dev = dev->dev;
		nv_connector->aux.transfer = nouveau_connector_aux_xfer;
		ret = drm_dp_aux_register(&nv_connector->aux);
		if (ret) {
			NV_ERROR(drm, "failed to register aux channel\n");
			kfree(nv_connector);
			return ERR_PTR(ret);
		}

1138
		funcs = &nouveau_connector_funcs_dp;
1139
1140
1141
1142
		break;
	default:
		funcs = &nouveau_connector_funcs;
		break;
1143
1144
	}

1145
1146
1147
1148
1149
1150
1151
	/* defaults, will get overridden in detect() */
	connector->interlace_allowed = false;
	connector->doublescan_allowed = false;

	drm_connector_init(dev, connector, funcs, type);
	drm_connector_helper_add(connector, &nouveau_connector_helper_funcs);

1152
	/* Init DVI-I specific properties */
1153
	if (nv_connector->type == DCB_CONNECTOR_DVI_I)
1154
		drm_object_attach_property(&connector->base, dev->mode_config.dvi_i_subconnector_property, 0);
1155

1156
	/* Add overscan compensation options to digital outputs */
1157
	if (disp->underscan_property &&
1158
1159
1160
1161
	    (type == DRM_MODE_CONNECTOR_DVID ||
	     type == DRM_MODE_CONNECTOR_DVII ||
	     type == DRM_MODE_CONNECTOR_HDMIA ||
	     type == DRM_MODE_CONNECTOR_DisplayPort)) {
1162
		drm_object_attach_property(&connector->base,
1163
1164
					      disp->underscan_property,
					      UNDERSCAN_OFF);
1165
		drm_object_attach_property(&connector->base,
1166
1167
					      disp->underscan_hborder_property,
					      0);
1168
		drm_object_attach_property(&connector->base,
1169
1170
1171
1172
					      disp->underscan_vborder_property,
					      0);
	}

1173
1174
	/* Add hue and saturation options */
	if (disp->vibrant_hue_property)
1175
		drm_object_attach_property(&connector->base,
1176
1177
1178
					      disp->vibrant_hue_property,
					      90);
	if (disp->color_vibrance_property)
1179
		drm_object_attach_property(&connector->base,
1180
1181
1182
					      disp->color_vibrance_property,
					      150);

1183
	switch (nv_connector->type) {
1184
	case DCB_CONNECTOR_VGA:
1185
		if (drm->device.info.family >= NV_DEVICE_INFO_V0_TESLA) {
1186
			drm_object_attach_property(&connector->base,
1187
1188
1189
					dev->mode_config.scaling_mode_property,
					nv_connector->scaling_mode);
		}
1190
1191
1192
1193
1194
1195
1196
1197
1198
		/* fall-through */
	case DCB_CONNECTOR_TV_0:
	case DCB_CONNECTOR_TV_1:
	case DCB_CONNECTOR_TV_3:
		nv_connector->scaling_mode = DRM_MODE_SCALE_NONE;
		break;
	default:
		nv_connector->scaling_mode = DRM_MODE_SCALE_FULLSCREEN;

1199
		drm_object_attach_property(&connector->base,
1200
1201
				dev->mode_config.scaling_mode_property,
				nv_connector->scaling_mode);
1202
1203
		if (disp->dithering_mode) {
			nv_connector->dithering_mode = DITHERING_MODE_AUTO;
1204
			drm_object_attach_property(&connector->base,
1205
1206
1207
1208
1209
						disp->dithering_mode,
						nv_connector->dithering_mode);
		}
		if (disp->dithering_depth) {
			nv_connector->dithering_depth = DITHERING_DEPTH_AUTO;
1210
			drm_object_attach_property(&connector->base,
1211
1212
1213
						disp->dithering_depth,
						nv_connector->dithering_depth);
		}