Skip to content
  • Arnd Bergmann's avatar
    rtc: cmos: avoid unused function warning · 00f7f90c
    Arnd Bergmann authored
    A bug fix for the ACPI side of this driver caused a harmless
    build warning:
    
    drivers/rtc/rtc-cmos.c:1115:13: error: 'cmos_check_acpi_rtc_status' defined but not used [-Werror=unused-function]
     static void cmos_check_acpi_rtc_status(struct device *dev,
    
    We can avoid the warning and simplify the driver at the same time
    by removing the #ifdef for CONFIG_PM and rely on the SIMPLE_DEV_PM_OPS()
    to set everything up correctly. cmos_resume() has to get marked
    as __maybe_unused so we don't introduce another warning, and
    the two variants of cmos_poweroff() can get merged into one using
    an IS_ENABLED() check.
    
    Fixes: 983bf125
    
     ("rtc: cmos: Clear ACPI-driven alarms upon resume")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
    00f7f90c