Skip to content
  • Mathieu Chouquet-Stringer's avatar
    thinkpad-acpi: fix module autoloading for older models · b36a50f9
    Mathieu Chouquet-Stringer authored
    
    
    Looking at the source, there seems to be a missing * to match my DMI
    string.  I mean for newer IBM and Lenovo's laptops you match either one
    of the following:
    MODULE_ALIAS("dmi:bvnIBM:*:svnIBM:*:pvrThinkPad*:rvnIBM:*");
    MODULE_ALIAS("dmi:bvnLENOVO:*:svnLENOVO:*:pvrThinkPad*:rvnLENOVO:*");
    
    While for older Thinkpads, you do this (for instance):
    IBM_BIOS_MODULE_ALIAS("1[0,3,6,8,A-G,I,K,M-P,S,T]");
    
    with IBM_BIOS_MODULE_ALIAS being MODULE_ALIAS("dmi:bvnIBM:bvr" __type "ET??WW")
    
    Note there's no * terminating the string.  As result, udev doesn't load
    anything because modprobe cannot find anything matching this (my
    machine actually):
    
    udevtest: run: '/sbin/modprobe dmi:bvnIBM:bvr1IET71WW(2.10):bd06/16/2006:svnIBM:pn236621U:pvrNotAv
    
    Signed-off-by: default avatarMathieu Chouquet-Stringer <mchouque@free.fr>
    Acked-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
    Signed-off-by: default avatarLen Brown <len.brown@intel.com>
    b36a50f9