• Neil Brown's avatar
    [PATCH] ext3: avoid triggering ext3_error on bad NFS file handle · 2ccb48eb
    Neil Brown authored
    The inode number out of an NFS file handle gets passed eventually to
    ext3_get_inode_block() without any checking.  If ext3_get_inode_block()
    allows it to trigger an error, then bad filehandles can have unpleasant
    effect - ext3_error() will usually cause a forced read-only remount, or a
    panic if `errors=panic' was used.
    So remove the call to ext3_error there and put a matching check in
    ext3/namei.c where inode numbers are read off storage.
    [akpm@osdl.org: fix off-by-one error]
    Signed-off-by: default avatarNeil Brown <neilb@suse.de>
    Signed-off-by: default avatarJan Kara <jack@suse.cz>
    Cc: Marcel Holtmann <marcel@holtmann.org>
    Cc: <stable@kernel.org>
    Cc: "Stephen C. Tweedie" <sct@redhat.com>
    Cc: Eric Sandeen <esandeen@redhat.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>