Skip to content
  • David Herrmann's avatar
    x86/simplefb: Mark framebuffer mem-resources as IORESOURCE_BUSY to avoid bootup warning · 29d274b8
    David Herrmann authored
    
    
    IORESOURCE_BUSY is used to mark temporary driver mem-resources
    instead of global regions. This suppresses warnings if regions
    overlap with a region marked as BUSY.
    
    This was always the case for VESA/VGA/EFI framebuffer regions so
    do the same for simplefb regions. The reason we do this is to
    allow device handover to real GPU drivers like
    i915/radeon/nouveau which get the same regions via PCI BARs.
    
    Maybe at some point we will be able to unregister platform
    devices properly during the handover. In this case the simplefb
    region would get removed before the new region is created.
    However, this is currently not the case and would require rather
    huge changes in remove_conflicting_framebuffers(). Add the BUSY
    marker now and try to eventually rewrite the handover for a next release.
    
    Also see kernel/resource.c for more information:
    
      /*
       * if a resource is "BUSY", it's not a hardware resource
       * but a driver mapping of such a resource; we don't want
       * to warn for those; some drivers legitimately map only
       * partial hardware resources. (example: vesafb)
       */
    
    This suppresses warnings like:
    
      ------------[ cut here ]------------
      WARNING: CPU: 2 PID: 199 at arch/x86/mm/ioremap.c:171 __ioremap_caller+0x2e3/0x390()
      Info: mapping multiple BARs. Your kernel is fine.
      Call Trace:
        dump_stack+0x54/0x8d
        warn_slowpath_common+0x7d/0xa0
        warn_slowpath_fmt+0x4c/0x50
        iomem_map_sanity_check+0xac/0xe0
        __ioremap_caller+0x2e3/0x390
        ioremap_wc+0x32/0x40
        i915_driver_load+0x670/0xf50 [i915]
        ...
    
    Reported-by: default avatarTom Gundersen <teg@jklm.no>
    Tested-by: default avatarTom Gundersen <teg@jklm.no>
    Tested-by: default avatarPavel Roskin <proski@gnu.org>
    Signed-off-by: default avatarDavid Herrmann <dh.herrmann@gmail.com>
    Link: http://lkml.kernel.org/r/1380724864-1757-1-git-send-email-dh.herrmann@gmail.com
    
    
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    29d274b8