Skip to content
  • Guenter Roeck's avatar
    TTY: isdn: Replace strncpy with memcpy · 414372f6
    Guenter Roeck authored
    
    
    gcc 8.1.0 complains:
    
    drivers/isdn/i4l/isdn_tty.c: In function 'isdn_tty_suspend.isra.1':
    drivers/isdn/i4l/isdn_tty.c:790:3: warning:
    	'strncpy' output truncated before terminating nul copying
    	as many bytes from a string as its length
    drivers/isdn/i4l/isdn_tty.c:778:6: note: length computed here
    
    drivers/isdn/i4l/isdn_tty.c: In function 'isdn_tty_resume':
    drivers/isdn/i4l/isdn_tty.c:880:3: warning:
    	'strncpy' output truncated before terminating nul copying
    	as many bytes from a string as its length
    drivers/isdn/i4l/isdn_tty.c:817:6: note: length computed here
    
    Using strncpy() is indeed less than perfect since the length of data to
    be copied has already been determined with strlen(). Replace strncpy()
    with memcpy() to address the warning and optimize the code a little.
    
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    414372f6