Skip to content
  • Harvey Hunt's avatar
    MIPS: tools: Fix relocs tool compiler warnings · 828a5428
    Harvey Hunt authored
    
    
    When using clang as HOSTCC, the following warnings appear:
    
    In file included from arch/mips/boot/tools/relocs_64.c:27:0:
    arch/mips/boot/tools/relocs.c: In function ‘read_relocs’:
    arch/mips/boot/tools/relocs.c:397:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
        ELF_R_SYM(rel->r_info) = elf32_to_cpu(ELF_R_SYM(rel->r_info));
        ^~~~~~~~~
    arch/mips/boot/tools/relocs.c:397:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
    arch/mips/boot/tools/relocs.c: In function ‘walk_relocs’:
    arch/mips/boot/tools/relocs.c:491:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
        Elf_Sym *sym = &sh_symtab[ELF_R_SYM(rel->r_info)];
        ^~~~~~~
    arch/mips/boot/tools/relocs.c: In function ‘do_reloc’:
    arch/mips/boot/tools/relocs.c:502:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
      unsigned r_type = ELF_R_TYPE(rel->r_info);
      ^~~~~~~~
    arch/mips/boot/tools/relocs.c: In function ‘do_reloc_info’:
    arch/mips/boot/tools/relocs.c:641:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
       rel_type(ELF_R_TYPE(rel->r_info)),
       ^~~~~~~~
    
    Fix them by making Elf64_Mips_Rela a union
    
    Signed-off-by: default avatarHarvey Hunt <harvey.hunt@imgtec.com>
    Acked-by: default avatarMatt Redfearn <matt.redfearn@imgtec.com>
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Patchwork: https://patchwork.linux-mips.org/patch/13683/
    
    
    Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    828a5428