Skip to content
  • Ryusuke Konishi's avatar
    nilfs2: fix preempt count underflow in nilfs_btnode_prepare_change_key · b1f1b8ce
    Ryusuke Konishi authored
    
    
    This will fix the following preempt count underflow reported from
    users with the title "[NILFS users] segctord problem" (Message-ID:
    <949415.6494.qm@web58808.mail.re1.yahoo.com> and Message-ID:
    <debc30fc0908270825v747c1734xa59126623cfd5b05@mail.gmail.com>):
    
     WARNING: at kernel/sched.c:4890 sub_preempt_count+0x95/0xa0()
     Hardware name: HP Compaq 6530b (KR980UT#ABC)
     Modules linked in: bridge stp llc bnep rfcomm l2cap xfs exportfs nilfs2 cowloop loop vboxnetadp vboxnetflt vboxdrv btusb bluetooth uvcvideo videodev v4l1_compat v4l2_compat_ioctl32 arc4 snd_hda_codec_analog ecb iwlagn iwlcore rfkill lib80211 mac80211 snd_hda_intel snd_hda_codec ehci_hcd uhci_hcd usbcore snd_hwdep snd_pcm tg3 cfg80211 psmouse snd_timer joydev libphy ohci1394 snd_page_alloc hp_accel lis3lv02d ieee1394 led_class i915 drm i2c_algo_bit video backlight output i2c_core dm_crypt dm_mod
     Pid: 4197, comm: segctord Not tainted 2.6.30-gentoo-r4-64 #7
     Call Trace:
      [<ffffffff8023fa05>] ? sub_preempt_count+0x95/0xa0
      [<ffffffff802470f8>] warn_slowpath_common+0x78/0xd0
      [<ffffffff8024715f>] warn_slowpath_null+0xf/0x20
      [<ffffffff8023fa05>] sub_preempt_count+0x95/0xa0
      [<ffffffffa04ce4db>] nilfs_btnode_prepare_change_key+0x11b/0x190 [nilfs2]
      [<ffffffffa04d01ad>] nilfs_btree_assign_p+0x19d/0x1e0 [nilfs2]
      [<ffffffffa04d10ad>] nilfs_btree_assign+0xbd/0x130 [nilfs2]
      [<ffffffffa04cead7>] nilfs_bmap_assign+0x47/0x70 [nilfs2]
      [<ffffffffa04d9bc6>] nilfs_segctor_do_construct+0x956/0x20f0 [nilfs2]
      [<ffffffff805ac8e2>] ? _spin_unlock_irqrestore+0x12/0x40
      [<ffffffff803c06e0>] ? __up_write+0xe0/0x150
      [<ffffffff80262959>] ? up_write+0x9/0x10
      [<ffffffffa04ce9f3>] ? nilfs_bmap_test_and_clear_dirty+0x43/0x60 [nilfs2]
      [<ffffffffa04cd627>] ? nilfs_mdt_fetch_dirty+0x27/0x60 [nilfs2]
      [<ffffffffa04db5fc>] nilfs_segctor_construct+0x8c/0xd0 [nilfs2]
      [<ffffffffa04dc3dc>] nilfs_segctor_thread+0x15c/0x3a0 [nilfs2]
      [<ffffffffa04dbe20>] ? nilfs_construction_timeout+0x0/0x10 [nilfs2]
      [<ffffffff80252633>] ? add_timer+0x13/0x20
      [<ffffffff802370da>] ? __wake_up_common+0x5a/0x90
      [<ffffffff8025e960>] ? autoremove_wake_function+0x0/0x40
      [<ffffffffa04dc280>] ? nilfs_segctor_thread+0x0/0x3a0 [nilfs2]
      [<ffffffffa04dc280>] ? nilfs_segctor_thread+0x0/0x3a0 [nilfs2]
      [<ffffffff8025e556>] kthread+0x56/0x90
      [<ffffffff8020cdea>] child_rip+0xa/0x20
      [<ffffffff8025e500>] ? kthread+0x0/0x90
      [<ffffffff8020cde0>] ? child_rip+0x0/0x20
    
    This problem was caused due to a missing radix_tree_preload() call in
    the retry path of nilfs_btnode_prepare_change_key() function.
    
    Reported-by: default avatarEric A <eric225125@yahoo.com>
    Reported-by: default avatarJerome Poulin <jeromepoulin@gmail.com>
    Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
    Tested-by: default avatarJerome Poulin <jeromepoulin@gmail.com>
    Cc: stable@kernel.org
    b1f1b8ce