Skip to content
  • Heiko Carstens's avatar
    ftrace: preemptoff selftest not working · a2250634
    Heiko Carstens authored
    
    
    Impact: fix preemptoff and preemptirqsoff tracer self-tests
    
    I was wondering why the preemptoff and preemptirqsoff tracer selftests
    don't work on s390. After all its just that they get called from
    non-preemptible context:
    
    kernel_init() will execute all initcalls, however the first line in
    kernel_init() is lock_kernel(), which causes the preempt_count to be
    increased. Any later calls to add_preempt_count() (especially those
    from the selftests) will therefore not result in a call to
    trace_preempt_off() since the check below in add_preempt_count()
    will be false:
    
            if (preempt_count() == val)
                    trace_preempt_off(CALLER_ADDR0, get_parent_ip(CALLER_ADDR1));
    
    Hence the trace buffer will be empty.
    
    Fix this by releasing the BKL during the self-tests.
    
    Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
    Acked-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    a2250634