Skip to content
  • Li Zefan's avatar
    tracing/stat: change dummpy_cmp() to return -1 · b3dd7ba7
    Li Zefan authored
    
    
    Currently the output of trace_stat/workqueues is totally reversed:
    
     # cat /debug/tracing/trace_stat/workqueues
        ...
        1       17       17      210       37   `-blk_unplug_work+0x0/0x57
        1     3779     3779      181       11   |-cfq_kick_queue+0x0/0x2f
        1     3796     3796                     kblockd/1:120
        ...
    
    The correct output should be:
    
        1     3796     3796                     kblockd/1:120
        1     3779     3779      181       11   |-cfq_kick_queue+0x0/0x2f
        1       17       17      210       37   `-blk_unplug_work+0x0/0x57
    
    It's caused by "tracing/stat: replace linked list by an rbtree for
    sorting"
    (53059c9b67a62a3dc8c80204d3da42b9267ea5a0).
    
    dummpy_cmp() should return -1, so rb_node will always be inserted as
    right-most node in the rbtree, thus we sort the output in ascending
    order.
    
    [ Impact: fix the output of trace_stat/workqueues ]
    
    Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
    Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
    b3dd7ba7