Skip to content
  • Steven Rostedt's avatar
    ftrace: Fix ftrace hash record update with notrace · c842e975
    Steven Rostedt authored
    
    
    When disabling the "notrace" records, that means we want to trace them.
    If the notrace_hash is zero, it means that we want to trace all
    records. But to disable a zero notrace_hash means nothing.
    
    The check for the notrace_hash count was incorrect with:
    
    	if (hash && !hash->count)
    		return
    
    With the correct comment above it that states that we do nothing
    if the notrace_hash has zero count. But !hash also means that
    the notrace hash has zero count. I think this was done to
    protect against dereferencing NULL. But if !hash is true, then
    we go through the following loop without doing a single thing.
    
    Fix it to:
    
    	if (!hash || !hash->count)
    		return;
    
    Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    c842e975