Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • I ipipe-x86
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • xenomai
  • ipipe-x86
  • Repository

Switch branch/tag
  • ipipe-x86
  • arch
  • powerpc
  • kernel
  • ftrace.c
Find file BlameHistoryPermalink
  • Michael Ellerman's avatar
    powerpc/ftrace: Fix typo in mask of opcode · dfc382a1
    Michael Ellerman authored Jun 17, 2014
    In commit 24a1bdc3
    
    , "Fix ABIv2 issues with __ftrace_make_call", Anton
    changed the logic that checks for the expected code sequence when
    patching a module.
    
    We missed the typo in the mask, 0xffff00000 should be 0xffff0000, which
    has the effect of making the test always true.
    
    That makes it impossible to ftrace against modules, eg:
    
      Unexpected call sequence: 48000008 e8410018
      WARNING: at ../kernel/trace/ftrace.c:1638
      ftrace failed to modify [<d000000007cf001c>] rng_dev_open+0x1c/0x70 [rng_core]
    Reported-by: default avatarDavid Binderman <dcb314@hotmail.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
    dfc382a1

Replace ftrace.c

Attach a file by drag & drop or click to upload


Cancel
GitLab will create a branch in your fork and start a merge request.

Imprint & Privacy Policy