• Steven Whitehouse's avatar
    GFS2: Fix off-by-one in gfs2_blk2rgrpd · f75bbfb4
    Steven Whitehouse authored
    Bob reported:
    I found an off-by-one problem with how I coded this section:
    It should be:
    + else if (blk >= cur->rd_data0 + cur->rd_data)
    In fact, cur->rd_data0 + cur->rd_data is the start of the next
    rgrp (the next ri_addr), so without the "=" check it can land on
    the wrong rgrp.
    In all normal cases, this won't be a problem: you're searching
    for a block _within_ the rgrp, which will pass the test properly.
    Where it gets into trouble is if you search the rgrps for the
    block exactly equal to ri_addr.  I don't think anything in the
    kernel does this, but I found a place in gfs2-utils gfs2_edit
    where it does.  So I definitely need to fix it in libgfs2.  I'd
    like to suggest we fix it in the kernel as well for the sake of
    keeping the functions similar.
    So this patch fixes the above mentioned off by one error as well
    as removing the unused parent pointer.
    Reported-by: default avatarBob Peterson <rpeterso@redhat.com>
    Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>