Commit 020aae3e authored by Roberto Sassu's avatar Roberto Sassu Committed by James Morris
Browse files

ima: do not update security.ima if appraisal status is not INTEGRITY_PASS

Commit b65a9cfc

 ("Untangling ima mess, part 2: deal with counters")
moved the call of ima_file_check() from may_open() to do_filp_open() at a
point where the file descriptor is already opened.

This breaks the assumption made by IMA that file descriptors being closed
belong to files whose access was granted by ima_file_check(). The
consequence is that security.ima and security.evm are updated with good
values, regardless of the current appraisal status.

For example, if a file does not have security.ima, IMA will create it after
opening the file for writing, even if access is denied. Access to the file
will be allowed afterwards.

Avoid this issue by checking the appraisal status before updating

Signed-off-by: default avatarRoberto Sassu <>
Signed-off-by: default avatarMimi Zohar <>
Signed-off-by: default avatarJames Morris <>
parent ed30b147
......@@ -320,6 +320,9 @@ void ima_update_xattr(struct integrity_iint_cache *iint, struct file *file)
if (iint->flags & IMA_DIGSIG)
if (iint->ima_file_status != INTEGRITY_PASS)
rc = ima_collect_measurement(iint, file, NULL, 0, ima_hash_algo);
if (rc < 0)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment