Commit 18d03e8c authored by Nikolay Borisov's avatar Nikolay Borisov Committed by Mike Snitzer
Browse files

dm thin: fix race condition when destroying thin pool workqueue

When a thin pool is being destroyed delayed work items are
cancelled using cancel_delayed_work(), which doesn't guarantee that on
return the delayed item isn't running.  This can cause the work item to
requeue itself on an already destroyed workqueue.  Fix this by using
cancel_delayed_work_sync() which guarantees that on return the work item
is not running anymore.

Fixes: 905e51b3 ("dm thin: commit outstanding data every second")
Fixes: 85ad643b

 ("dm thin: add timeout to stop out-of-data-space mode holding IO forever")
Signed-off-by: default avatarNikolay Borisov <>
Signed-off-by: default avatarMike Snitzer <>
parent 51216778
......@@ -3453,8 +3453,8 @@ static void pool_postsuspend(struct dm_target *ti)
struct pool_c *pt = ti->private;
struct pool *pool = pt->pool;
(void) commit(pool);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment