Commit 2961bf34 authored by Li Zefan's avatar Li Zefan Committed by Ingo Molnar
Browse files

trace_stat: Don't increment @pos in seq start()



It's wrong to increment @pos in stat_seq_start(). It causes some
stat entries lost when reading stat file, if the output of the file
is larger than PAGE_SIZE.
Reviewed-by: default avatarLiming Wang <liming.wang@windriver.com>
Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <4A418716.90209@cn.fujitsu.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent c8961ec6
...@@ -199,17 +199,13 @@ static void *stat_seq_start(struct seq_file *s, loff_t *pos) ...@@ -199,17 +199,13 @@ static void *stat_seq_start(struct seq_file *s, loff_t *pos)
mutex_lock(&session->stat_mutex); mutex_lock(&session->stat_mutex);
/* If we are in the beginning of the file, print the headers */ /* If we are in the beginning of the file, print the headers */
if (!*pos && session->ts->stat_headers) { if (!*pos && session->ts->stat_headers)
(*pos)++;
return SEQ_START_TOKEN; return SEQ_START_TOKEN;
}
node = rb_first(&session->stat_root); node = rb_first(&session->stat_root);
for (i = 0; node && i < *pos; i++) for (i = 0; node && i < *pos; i++)
node = rb_next(node); node = rb_next(node);
(*pos)++;
return node; return node;
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment