Commit 2a8307aa authored by Sean Wang's avatar Sean Wang Committed by David S. Miller
Browse files

net: ethernet: mediatek: add more resets for internal ethernet circuit block

struct mtk_eth has already contained struct regmap ethsys pointer
to the address range of the internal circuit reset, so we reuse it
to reset more internal blocks on ethernet hardware such as packet
processing engine (PPE) and frame engine (FE) instead of rstc which
deals with FE only.
Signed-off-by: default avatarSean Wang <>
Signed-off-by: default avatarDavid S. Miller <>
parent 9ea4d311
......@@ -1414,6 +1414,19 @@ static int mtk_stop(struct net_device *dev)
return 0;
static void ethsys_reset(struct mtk_eth *eth, u32 reset_bits)
regmap_update_bits(eth->ethsys, ETHSYS_RSTCTRL,
usleep_range(1000, 1100);
regmap_update_bits(eth->ethsys, ETHSYS_RSTCTRL,
static int mtk_hw_init(struct mtk_eth *eth)
int i, val;
......@@ -1428,12 +1441,8 @@ static int mtk_hw_init(struct mtk_eth *eth)
/* reset the frame engine */
usleep_range(10, 20);
usleep_range(10, 20);
ethsys_reset(eth, RSTCTRL_FE);
ethsys_reset(eth, RSTCTRL_PPE);
regmap_read(eth->ethsys, ETHSYS_SYSCFG0, &val);
for (i = 0; i < MTK_MAC_COUNT; i++) {
......@@ -1896,12 +1905,6 @@ static int mtk_probe(struct platform_device *pdev)
return PTR_ERR(eth->pctl);
eth->rstc = devm_reset_control_get(&pdev->dev, "eth");
if (IS_ERR(eth->rstc)) {
dev_err(&pdev->dev, "no eth reset found\n");
return PTR_ERR(eth->rstc);
for (i = 0; i < 3; i++) {
eth->irq[i] = platform_get_irq(pdev, i);
if (eth->irq[i] < 0) {
......@@ -266,6 +266,11 @@
#define SYSCFG0_GE_MASK 0x3
#define SYSCFG0_GE_MODE(x, y) (x << (12 + (y * 2)))
/*ethernet reset control register*/
#define ETHSYS_RSTCTRL 0x34
#define RSTCTRL_FE BIT(6)
#define RSTCTRL_PPE BIT(31)
struct mtk_rx_dma {
unsigned int rxd1;
unsigned int rxd2;
......@@ -423,7 +428,6 @@ struct mtk_rx_ring {
struct mtk_eth {
struct device *dev;
void __iomem *base;
struct reset_control *rstc;
spinlock_t page_lock;
spinlock_t irq_lock;
struct net_device dummy_dev;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment