Commit 2e85d676 authored by Chen Gang's avatar Chen Gang Committed by David S. Miller
Browse files

net/rds: zero last byte for strncpy

for NUL terminated string, need be always sure '\0' in the end.

additional info:
  strncpy will pads with zeroes to the end of the given buffer.
  should initialise every bit of memory that is going to be copied to userland

Signed-off-by: default avatarChen Gang <>
Signed-off-by: default avatarBen Hutchings <>
Signed-off-by: default avatarDavid S. Miller <>
parent d9169323
......@@ -87,6 +87,7 @@ void rds_stats_info_copy(struct rds_info_iterator *iter,
for (i = 0; i < nr; i++) {
BUG_ON(strlen(names[i]) >= sizeof(;
strncpy(, names[i], sizeof( - 1);[sizeof( - 1] = '\0';
ctr.value = values[i];
rds_info_copy(iter, &ctr, sizeof(ctr));
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment