Commit 2e97e980 authored by David S. Miller's avatar David S. Miller
Browse files

ipv4: Remove erroneous check in igmpv3_newpack() and igmp_send_report().



Output route resolution never returns a route with rt_src set to zero
(which is INADDR_ANY).

Even if the flow key for the output route lookup specifies INADDR_ANY
for the source address, the output route resolution chooses a real
source address to use in the final route.

This test has existed forever in igmp_send_report() and David Stevens
simply copied over the erroneous test when implementing support for
IGMPv3.
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Reviewed-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
parent 2d7192d6
......@@ -328,11 +328,6 @@ static struct sk_buff *igmpv3_newpack(struct net_device *dev, int size)
kfree_skb(skb);
return NULL;
}
if (rt->rt_src == 0) {
kfree_skb(skb);
ip_rt_put(rt);
return NULL;
}
skb_dst_set(skb, &rt->dst);
skb->dev = dev;
......@@ -670,11 +665,6 @@ static int igmp_send_report(struct in_device *in_dev, struct ip_mc_list *pmc,
if (IS_ERR(rt))
return -1;
if (rt->rt_src == 0) {
ip_rt_put(rt);
return -1;
}
skb = alloc_skb(IGMP_SIZE+LL_ALLOCATED_SPACE(dev), GFP_ATOMIC);
if (skb == NULL) {
ip_rt_put(rt);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment