Commit 3f96ff44 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Greg Kroah-Hartman
Browse files

kconfig: fix memory leak when EOF is encountered in quotation

[ Upstream commit fbac5977 ]

An unterminated string literal followed by new line is passed to the
parser (with "multi-line strings not supported" warning shown), then
handled properly there.

On the other hand, an unterminated string literal at end of file is
never passed to the parser, then results in memory leak.

[Test Code]

  ----------(Kconfig begin)----------
  source ""

  config A
          bool "a"
  -----------(Kconfig end)-----------

  --------( begin)--------
  config B
          bool "b\No new line at end of file
  ---------( end)---------

[Summary from Valgrind]

  Before the fix:

       definitely lost: 16 bytes in 1 blocks

  After the fix:

       definitely lost: 0 bytes in 0 blocks

Eliminate the memory leak path by handling this case. Of course, such
a Kconfig file is wrong already, so I will add an...
parent 407148e8
......@@ -191,6 +191,8 @@ n [A-Za-z0-9_-]
<<EOF>> {
yylval.string = text;
return T_WORD_QUOTE;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment