Commit 56d10194 authored by Guenter Roeck's avatar Guenter Roeck Committed by Greg Kroah-Hartman
Browse files

configfs: replace strncpy with memcpy

commit 1823342a


gcc 8.1.0 complains:

fs/configfs/symlink.c:67:3: warning:
	'strncpy' output truncated before terminating nul copying as many
	bytes from a string as its length
fs/configfs/symlink.c: In function 'configfs_get_link':
fs/configfs/symlink.c:63:13: note: length computed here

Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.

Signed-off-by: default avatarGuenter Roeck <>
Signed-off-by: default avatarChristoph Hellwig <>
Signed-off-by: default avatarNobuhiro Iwamatsu <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 6ceec07c
......@@ -64,7 +64,7 @@ static void fill_item_path(struct config_item * item, char * buffer, int length)
/* back up enough to print this bus id with '/' */
length -= cur;
strncpy(buffer + length,config_item_name(p),cur);
memcpy(buffer + length, config_item_name(p), cur);
*(buffer + --length) = '/';
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment