Commit 6698e347 authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds
Browse files

tty: Fix BKL taken under a spinlock bug introduced in the BKL split

The fasync path takes the BKL (it probably doesn't need to in fact)
while holding the file_list spinlock.  You can't do that with the kernel
lock: it causes lock inversions and deadlocks.

Leave the BKL over that bit for the moment.

Identified by AKPM.

Signed-off-by: default avatarAlan Cox <>
Acked-and-Tested-by: default avatarThomas Gleixner <>
Signed-off-by: default avatarLinus Torvalds <>
parent 09cea96c
......@@ -516,7 +516,6 @@ static void do_tty_hangup(struct work_struct *work)
/* inuse_filps is protected by the single kernel lock */
check_tty_count(tty, "do_tty_hangup");
/* This breaks for file handles being sent over AF_UNIX sockets ? */
......@@ -531,7 +530,6 @@ static void do_tty_hangup(struct work_struct *work)
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment