Commit 7c00782b authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: ni_labpc: fix labpc_calib_insn_write()

The comedi core expects the (*insn_write) operations to write insn->n
values and return the number of values actually wrote.

Make this function work like the core expects.

As Ian Abbott pointed out for the eeprom writes, we really only need
to write the last value to the caldac. The preceding data would be
overwritten anyway.
Signed-off-by: default avatarH Hartley Sweeten <>
Cc: Ian Abbott <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 198ac9dc
......@@ -1539,10 +1539,16 @@ static int labpc_calib_insn_write(struct comedi_device *dev,
struct comedi_insn *insn,
unsigned int *data)
int channel = CR_CHAN(insn->chanspec);
unsigned int chan = CR_CHAN(insn->chanspec);
write_caldac(dev, channel, data[0]);
return 1;
* Only write the last data value to the caldac. Preceding
* data would be overwritten anyway.
if (insn->n > 0)
write_caldac(dev, chan, data[insn->n - 1]);
return insn->n;
static int labpc_calib_insn_read(struct comedi_device *dev,
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment