Commit 85951842 authored by Li Zefan's avatar Li Zefan Committed by Ingo Molnar
Browse files

ftrace: Don't increment @pos in g_start()

It's wrong to increment @pos in g_start(). It causes some entries
lost when reading set_graph_function, if the output of the file
is larger than PAGE_SIZE.
Reviewed-by: default avatarLiming Wang <>
Signed-off-by: default avatarLi Zefan <>
Cc: Steven Rostedt <>
Cc: Frederic Weisbecker <>
LKML-Reference: <>
Signed-off-by: default avatarIngo Molnar <>
parent f129e965
......@@ -2500,32 +2500,31 @@ int ftrace_graph_count;
unsigned long ftrace_graph_funcs[FTRACE_GRAPH_MAX_FUNCS] __read_mostly;
static void *
g_next(struct seq_file *m, void *v, loff_t *pos)
__g_next(struct seq_file *m, loff_t *pos)
unsigned long *array = m->private;
int index = *pos;
if (index >= ftrace_graph_count)
if (*pos >= ftrace_graph_count)
return NULL;
return &array[*pos];
return &array[index];
static void *
g_next(struct seq_file *m, void *v, loff_t *pos)
return __g_next(m, pos);
static void *g_start(struct seq_file *m, loff_t *pos)
void *p = NULL;
/* Nothing, tell g_show to print all functions are enabled */
if (!ftrace_graph_count && !*pos)
return (void *)1;
p = g_next(m, p, pos);
return p;
return __g_next(m, pos);
static void g_stop(struct seq_file *m, void *p)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment