Commit 8a69edb8 authored by Pan Bian's avatar Pan Bian Committed by Greg Kroah-Hartman
Browse files

net: hisilicon: remove unexpected free_netdev

[ Upstream commit c7589401

 ]

The net device ndev is freed via free_netdev when failing to register
the device. The control flow then jumps to the error handling code
block. ndev is used and freed again. Resulting in a use-after-free bug.
Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 689dee4b
...@@ -914,10 +914,8 @@ static int hip04_mac_probe(struct platform_device *pdev) ...@@ -914,10 +914,8 @@ static int hip04_mac_probe(struct platform_device *pdev)
} }
ret = register_netdev(ndev); ret = register_netdev(ndev);
if (ret) { if (ret)
free_netdev(ndev);
goto alloc_fail; goto alloc_fail;
}
return 0; return 0;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment