Commit 8c5548e3 authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

leds: lp5523: check return value of lp5xx_read and jump to cleanup code

commit 6647f7a06eb030a2384ec71f0bb2e78854afabfe upstream.

Check return value of lp5xx_read and if non-zero, jump to code at end of
the function, causing lp5523_stop_all_engines to be executed before
returning the error value up the call chain. This fixes the original
commit (248b5701

) which was reverted due to the University of Minnesota

Cc: stable <>
Acked-by: default avatarJacek Anaszewski <>
Signed-off-by: default avatarPhillip Potter <>

Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 3ac4e35d
......@@ -318,7 +318,9 @@ static int lp5523_init_program_engine(struct lp55xx_chip *chip)
/* Let the programs run for couple of ms and check the engine status */
usleep_range(3000, 6000);
lp55xx_read(chip, LP5523_REG_STATUS, &status);
ret = lp55xx_read(chip, LP5523_REG_STATUS, &status);
if (ret)
goto out;
status &= LP5523_ENG_STATUS_MASK;
if (status != LP5523_ENG_STATUS_MASK) {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment