Commit 959ef6d5 authored by Himangi Saraogi's avatar Himangi Saraogi Committed by Matthew Garrett
Browse files

WMI: Remove unnecessary null test

This patch removes the null test on block. block is initialized at the
beginning of the function to &wblock->gblock. Since wblock is
dereferenced prior to the null test, wblock must be a valid pointer,
and &wblock->gblock cannot be null.

The following Coccinelle script is used for detecting the change:

expression e,f;
identifier g,y;
statement S1,S2;

*e = &f->g
*if (e != NULL || ...)
 S1 else S2
Signed-off-by: default avatarHimangi Saraogi <>
Signed-off-by: default avatarMatthew Garrett <>
parent bd3c7b9e
......@@ -256,10 +256,6 @@ static acpi_status wmi_method_enable(struct wmi_block *wblock, int enable)
block = &wblock->gblock;
handle = wblock->handle;
if (!block)
return AE_NOT_EXIST;
snprintf(method, 5, "WE%02X", block->notify_id);
status = acpi_execute_simple_method(handle, method, enable);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment