Commit 95c8714e authored by Pan Bian's avatar Pan Bian Committed by Greg Kroah-Hartman
Browse files

hfsplus: do not free node before using

[ Upstream commit c7d7d620 ]

hfs_bmap_free() frees node via hfs_bnode_put(node).  However it then
reads node->this when dumping error message on an error path, which may
result in a use-after-free bug.  This patch frees node only when it is
never used.


Signed-off-by: default avatarPan Bian <>
Reviewed-by: default avatarAndrew Morton <>
Cc: Ernesto A. Fernandez <>
Cc: Joe Perches <>
Cc: Viacheslav Dubeyko <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
Signed-off-by: default avatarSasha Levin <>
parent 5ee5fa61
......@@ -454,14 +454,15 @@ void hfs_bmap_free(struct hfs_bnode *node)
nidx -= len * 8;
i = node->next;
if (!i) {
/* panic */;
pr_crit("unable to free bnode %u. "
"bmap not found!\n",
node = hfs_bnode_find(tree, i);
if (IS_ERR(node))
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment