Commit a441dbb1 authored by Marcin Slusarz's avatar Marcin Slusarz Committed by Ben Skeggs
Browse files

drm/nouveau: use kmemdup for edid allocation/copying



Avoids potential null pointer dereference.
Signed-off-by: default avatarMarcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent 03e9a040
...@@ -399,9 +399,10 @@ nouveau_connector_detect_lvds(struct drm_connector *connector, bool force) ...@@ -399,9 +399,10 @@ nouveau_connector_detect_lvds(struct drm_connector *connector, bool force)
struct edid *edid = struct edid *edid =
(struct edid *)nouveau_bios_embedded_edid(dev); (struct edid *)nouveau_bios_embedded_edid(dev);
if (edid) { if (edid) {
nv_connector->edid = kmalloc(EDID_LENGTH, GFP_KERNEL); nv_connector->edid =
*(nv_connector->edid) = *edid; kmemdup(edid, EDID_LENGTH, GFP_KERNEL);
status = connector_status_connected; if (nv_connector->edid)
status = connector_status_connected;
} }
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment