Commit c269fc8c authored by Tom Zanussi's avatar Tom Zanussi Committed by Ingo Molnar
Browse files

tracing: fix leak in event_format_read()

Impact: fix memory leak

If event_format_read() exits early due to nonzero ppos, the
previous kmalloc doesn't get freed - might as well do the
check before the kmalloc and avoid the problem.
Signed-off-by: default avatarTom Zanussi <>
Cc: Steven Rostedt <>
Cc: =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <>
LKML-Reference: <1237270859.8033.141.camel@charm-linux>
Signed-off-by: default avatarIngo Molnar <>
parent e4106133
......@@ -378,15 +378,15 @@ event_format_read(struct file *filp, char __user *ubuf, size_t cnt,
char *buf;
int r;
if (*ppos)
return 0;
s = kmalloc(sizeof(*s), GFP_KERNEL);
if (!s)
return -ENOMEM;
if (*ppos)
return 0;
/* If any of the first writes fail, so will the show_format. */
trace_seq_printf(s, "name: %s\n", call->name);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment