Commit c2cbcf53 authored by Laurent Dufour's avatar Laurent Dufour Committed by Benjamin Herrenschmidt
Browse files

powerpc/module: Fix TOC symbol CRC

The commit 71ec7c55

 introduced the magic symbol ".TOC." for ELFv2 ABI.
This symbol is built manually and has no CRC value computed. A zero value
is put in the CRC section to avoid modpost complaining about a missing CRC.
Unfortunately, this breaks the kernel module loading when the kernel is
relocated (kdump case for instance) because of the relocation applied to
the kcrctab values.

This patch compute a CRC value for the TOC symbol which will match the one
compute by the kernel when it is relocated - aka '0 - relocate_start' done in
maybe_relocated called by check_version (module.c).
Signed-off-by: default avatarLaurent Dufour <>
Cc: Anton Blanchard <>
Signed-off-by: default avatarBenjamin Herrenschmidt <>
parent e2500be2
......@@ -315,8 +315,17 @@ static void dedotify_versions(struct modversion_info *vers,
struct modversion_info *end;
for (end = (void *)vers + size; vers < end; vers++)
if (vers->name[0] == '.')
if (vers->name[0] == '.') {
memmove(vers->name, vers->name+1, strlen(vers->name));
/* The TOC symbol has no CRC computed. To avoid CRC
* check failing, we must force it to the expected
* value (see CRC check in module.c).
if (!strcmp(vers->name, "TOC."))
vers->crc = -(unsigned long)reloc_start;
/* Undefined symbols which refer to .funcname, hack to funcname (or .TOC.) */
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment