Commit cf66b8a0 authored by Chris Wilson's avatar Chris Wilson Committed by Joonas Lahtinen
Browse files

drm/i915/execlists: Apply a full mb before execution for Braswell

Braswell is really picky about having our writes posted to memory before
we execute or else the GPU may see stale values. A wmb() is insufficient
as it only ensures the writes are visible to other cores, we need a full
mb() to ensure the writes are in memory and visible to the GPU.

The most frequent failure in flushing before execution is that we see
stale PTE values and execute the wrong pages.

References: 987abd5c

 ("drm/i915/execlists: Force write serialisation into context image vs execution")
Signed-off-by: default avatarChris Wilson <>
Cc: Mika Kuoppala <>
Cc: Tvrtko Ursulin <>
Cc: Joonas Lahtinen <>
Reviewed-by: default avatarTvrtko Ursulin <>
(cherry picked from commit 490b8c65

Signed-off-by: default avatarJoonas Lahtinen <>
parent d76b21eb
......@@ -442,8 +442,13 @@ static u64 execlists_update_context(struct i915_request *rq)
* may not be visible to the HW prior to the completion of the UC
* register write and that we may begin execution from the context
* before its image is complete leading to invalid PD chasing.
* Furthermore, Braswell, at least, wants a full mb to be sure that
* the writes are coherent in memory (visible to the GPU) prior to
* execution, and not just visible to other CPUs (as is the result of
* wmb).
return ce->lrc_desc;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment